From: Shakeel Butt <shakeelb@google.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Roman Gushchin <guro@fb.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Xiongchun duan <duanxiongchun@bytedance.com>,
fam.zheng@bytedance.com
Subject: Re: [PATCH 5/7] mm: memcontrol: simplify the logic of objcg pinning memcg
Date: Tue, 13 Apr 2021 07:16:58 -0700 [thread overview]
Message-ID: <CALvZod4B3-OREkm2ZVGyueUcJRE2igTjhNHTE3nVDSzTVRDs6Q@mail.gmail.com> (raw)
In-Reply-To: <20210413065153.63431-6-songmuchun@bytedance.com>
On Mon, Apr 12, 2021 at 11:58 PM Muchun Song <songmuchun@bytedance.com> wrote:
>
> The obj_cgroup_release() and memcg_reparent_objcgs() are serialized by
> the css_set_lock. We do not need to care about objcg->memcg being
> released in the process of obj_cgroup_release(). So there is no need
> to pin memcg before releasing objcg. Remove those pinning logic to
> simplfy the code.
>
> There are only two places that modifies the objcg->memcg. One is the
> initialization to objcg->memcg in the memcg_online_kmem(), another
> is objcgs reparenting in the memcg_reparent_objcgs(). It is also
> impossible for the two to run in parallel. So xchg() is unnecessary
> and it is enough to use WRITE_ONCE().
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
next prev parent reply other threads:[~2021-04-13 14:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 6:51 [PATCH 0/7] memcontrol code cleanup and simplification Muchun Song
2021-04-13 6:51 ` [PATCH 1/7] mm: memcontrol: fix page charging in page replacement Muchun Song
2021-04-13 17:45 ` Roman Gushchin
2021-04-14 9:20 ` Michal Hocko
2021-04-13 6:51 ` [PATCH 2/7] mm: memcontrol: bail out early when !mm in get_mem_cgroup_from_mm Muchun Song
2021-04-13 17:47 ` Roman Gushchin
2021-04-14 9:24 ` Michal Hocko
2021-04-14 10:04 ` [External] " Muchun Song
2021-04-14 10:04 ` Muchun Song
2021-04-14 10:15 ` Michal Hocko
2021-04-15 3:13 ` Muchun Song
2021-04-15 3:13 ` Muchun Song
2021-04-15 7:09 ` Michal Hocko
2021-04-13 6:51 ` [PATCH 3/7] mm: memcontrol: remove the pgdata parameter of mem_cgroup_page_lruvec Muchun Song
2021-04-13 13:12 ` Shakeel Butt
2021-04-13 13:12 ` Shakeel Butt
2021-04-13 17:48 ` Roman Gushchin
2021-04-14 9:27 ` Michal Hocko
2021-04-13 6:51 ` [PATCH 4/7] mm: memcontrol: simplify lruvec_holds_page_lru_lock Muchun Song
2021-04-13 13:28 ` Shakeel Butt
2021-04-13 13:28 ` Shakeel Butt
2021-04-13 17:57 ` Roman Gushchin
2021-04-14 9:44 ` Michal Hocko
2021-04-14 10:00 ` [External] " Muchun Song
2021-04-14 10:00 ` Muchun Song
2021-04-14 17:49 ` Johannes Weiner
2021-04-15 7:08 ` Michal Hocko
2021-04-15 10:01 ` Muchun Song
2021-04-15 10:01 ` Muchun Song
2021-04-13 6:51 ` [PATCH 5/7] mm: memcontrol: simplify the logic of objcg pinning memcg Muchun Song
2021-04-13 14:16 ` Shakeel Butt [this message]
2021-04-13 14:16 ` Shakeel Butt
2021-04-13 17:51 ` Roman Gushchin
2021-04-13 6:51 ` [PATCH 6/7] mm: memcontrol: move obj_cgroup_uncharge_pages() out of css_set_lock Muchun Song
2021-04-13 14:18 ` Shakeel Butt
2021-04-13 14:18 ` Shakeel Butt
2021-04-13 17:54 ` Roman Gushchin
2021-04-13 18:03 ` Johannes Weiner
2021-04-13 6:51 ` [PATCH 7/7] mm: vmscan: remove noinline_for_stack Muchun Song
2021-04-14 9:46 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod4B3-OREkm2ZVGyueUcJRE2igTjhNHTE3nVDSzTVRDs6Q@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=duanxiongchun@bytedance.com \
--cc=fam.zheng@bytedance.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.