From: "Hilman, Kevin" <khilman@ti.com>
To: Alessandro Zummo <a.zummo@towertech.it>, rtc-linux@googlegroups.com
Cc: linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT
Date: Fri, 6 Jul 2012 07:25:32 -0700 [thread overview]
Message-ID: <CALyTGOCYJX1St+0XsGujovOn-xFmBVFNpFRzzM9KrL-0qcObqg@mail.gmail.com> (raw)
In-Reply-To: <1340900265-11962-1-git-send-email-khilman@ti.com>
Alessandro,
Gentle reminder ping on this one so it can make it in for v3.5-rc. Thanks.
On Thu, Jun 28, 2012 at 9:17 AM, Kevin Hilman <khilman@ti.com> wrote:
> Requesting a threaded interrupt without a primary handler and without
> IRQF_ONESHOT is dangerous, and after commit 1c6c6952 (genirq: Reject
> bogus threaded irq requests), these requests are rejected. This
> causes ->probe() to fail, and the RTC driver not to be availble.
>
> To fix, add IRQF_ONESHOT to the IRQ flags.
>
> Tested on OMAP3730/OveroSTORM and OMAP4430/Panda board using rtcwake
> to wake from system suspend multiple times.
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
> This fix is needed in v3.5.
> Applies on top of v3.5-rc4.
>
> drivers/rtc/rtc-twl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
> index 258abea..c5d06fe 100644
> --- a/drivers/rtc/rtc-twl.c
> +++ b/drivers/rtc/rtc-twl.c
> @@ -510,7 +510,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
> }
>
> ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
> - IRQF_TRIGGER_RISING,
> + IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> dev_name(&rtc->dev), rtc);
> if (ret < 0) {
> dev_err(&pdev->dev, "IRQ is not free.\n");
> --
> 1.7.9.2
>
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Hilman, Kevin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT
Date: Fri, 6 Jul 2012 07:25:32 -0700 [thread overview]
Message-ID: <CALyTGOCYJX1St+0XsGujovOn-xFmBVFNpFRzzM9KrL-0qcObqg@mail.gmail.com> (raw)
In-Reply-To: <1340900265-11962-1-git-send-email-khilman@ti.com>
Alessandro,
Gentle reminder ping on this one so it can make it in for v3.5-rc. Thanks.
On Thu, Jun 28, 2012 at 9:17 AM, Kevin Hilman <khilman@ti.com> wrote:
> Requesting a threaded interrupt without a primary handler and without
> IRQF_ONESHOT is dangerous, and after commit 1c6c6952 (genirq: Reject
> bogus threaded irq requests), these requests are rejected. This
> causes ->probe() to fail, and the RTC driver not to be availble.
>
> To fix, add IRQF_ONESHOT to the IRQ flags.
>
> Tested on OMAP3730/OveroSTORM and OMAP4430/Panda board using rtcwake
> to wake from system suspend multiple times.
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
> This fix is needed in v3.5.
> Applies on top of v3.5-rc4.
>
> drivers/rtc/rtc-twl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
> index 258abea..c5d06fe 100644
> --- a/drivers/rtc/rtc-twl.c
> +++ b/drivers/rtc/rtc-twl.c
> @@ -510,7 +510,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
> }
>
> ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
> - IRQF_TRIGGER_RISING,
> + IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> dev_name(&rtc->dev), rtc);
> if (ret < 0) {
> dev_err(&pdev->dev, "IRQ is not free.\n");
> --
> 1.7.9.2
>
next prev parent reply other threads:[~2012-07-06 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 16:17 [PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT Kevin Hilman
2012-06-28 16:17 ` Kevin Hilman
2012-07-06 14:25 ` Hilman, Kevin [this message]
2012-07-06 14:25 ` Hilman, Kevin
2012-07-06 16:33 Kevin Hilman
2012-07-06 16:33 ` Kevin Hilman
2012-07-09 22:15 ` Andrew Morton
2012-07-09 22:15 ` Andrew Morton
2012-07-10 7:32 ` Lars-Peter Clausen
2012-07-10 7:32 ` Lars-Peter Clausen
2012-07-10 11:54 ` Mark Brown
2012-07-10 11:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALyTGOCYJX1St+0XsGujovOn-xFmBVFNpFRzzM9KrL-0qcObqg@mail.gmail.com \
--to=khilman@ti.com \
--cc=a.zummo@towertech.it \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.