From: Abhilash Kesavan <kesavan.abhilash@gmail.com> To: Kukjin Kim <kgene.kim@samsung.com> Cc: Nicolas Pitre <nicolas.pitre@linaro.org>, Dave Martin <Dave.Martin@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Tomasz Figa <t.figa@samsung.com>, Andrew Bresticker <abrestic@chromium.org>, Thomas P Abraham <thomas.ab@samsung.com>, "inderpal.s@samsung.com" <inderpal.s@samsung.com>, "mark.rutland" <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, Grant Likely <grant.likely@linaro.org>, robh+dt <robh+dt@kernel.org>, Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>, linux-samsung-soc <linux-samsung-soc@vger.kernel.org>, Jonghwan Choi <jhbird.choi@samsung.com>, skon.hwang@samsung.com Subject: Re: [PATCH v5 2/5] ARM: EXYNOS: use generic exynos cpu power control functions Date: Tue, 13 May 2014 15:43:04 +0530 [thread overview] Message-ID: <CAM4voanOEpe-b98GKant9w+=YMQpE3az7a4=eMGW0aX9NpnO9g@mail.gmail.com> (raw) In-Reply-To: <019c01cf6e53$14eab220$3ec01660$@samsung.com> Hi Kukjin, On Tue, May 13, 2014 at 7:58 AM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Abhilash Kesavan wrote: >> >> From: Leela Krishna Amudala <leela.krishna@linaro.org> >> >> Use generic exynos cpu power control functions to power up/down >> and to know the status of the cpu. >> >> Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org> > > Same as previous comment. > >> --- >> arch/arm/mach-exynos/platsmp.c | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach- >> exynos/platsmp.c >> index 0aac032..d442a66 100644 >> --- a/arch/arm/mach-exynos/platsmp.c >> +++ b/arch/arm/mach-exynos/platsmp.c >> @@ -130,15 +130,12 @@ static int exynos_boot_secondary(unsigned int cpu, >> struct task_struct *idle) >> */ >> write_pen_release(phys_cpu); >> >> - if (!(__raw_readl(S5P_ARM_CORE1_STATUS) & S5P_CORE_LOCAL_PWR_EN)) { >> - __raw_writel(S5P_CORE_LOCAL_PWR_EN, >> - S5P_ARM_CORE1_CONFIGURATION); >> - >> + if (!exynos_cpu_power_state(cpu)) { >> + exynos_cpu_powerup(cpu); >> timeout = 10; >> >> /* wait max 10 ms until cpu1 is on */ >> - while ((__raw_readl(S5P_ARM_CORE1_STATUS) >> - & S5P_CORE_LOCAL_PWR_EN) != S5P_CORE_LOCAL_PWR_EN) { >> + while (exynos_cpu_power_state(cpu) != S5P_CORE_LOCAL_PWR_EN) >> { >> if (timeout-- == 0) >> break; >> >> -- > > You may cleanup the definitions of 'S5P_ARM_CORE1_CONFIGURATION/STATUS' in > regs-pmu.h once hotplug.c uses the generic power control functions. OK, will re-post a new version rebased on your for-next branch soon. Regards, Abhilash > > - Kukjin >
WARNING: multiple messages have this Message-ID (diff)
From: kesavan.abhilash@gmail.com (Abhilash Kesavan) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 2/5] ARM: EXYNOS: use generic exynos cpu power control functions Date: Tue, 13 May 2014 15:43:04 +0530 [thread overview] Message-ID: <CAM4voanOEpe-b98GKant9w+=YMQpE3az7a4=eMGW0aX9NpnO9g@mail.gmail.com> (raw) In-Reply-To: <019c01cf6e53$14eab220$3ec01660$@samsung.com> Hi Kukjin, On Tue, May 13, 2014 at 7:58 AM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Abhilash Kesavan wrote: >> >> From: Leela Krishna Amudala <leela.krishna@linaro.org> >> >> Use generic exynos cpu power control functions to power up/down >> and to know the status of the cpu. >> >> Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org> > > Same as previous comment. > >> --- >> arch/arm/mach-exynos/platsmp.c | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach- >> exynos/platsmp.c >> index 0aac032..d442a66 100644 >> --- a/arch/arm/mach-exynos/platsmp.c >> +++ b/arch/arm/mach-exynos/platsmp.c >> @@ -130,15 +130,12 @@ static int exynos_boot_secondary(unsigned int cpu, >> struct task_struct *idle) >> */ >> write_pen_release(phys_cpu); >> >> - if (!(__raw_readl(S5P_ARM_CORE1_STATUS) & S5P_CORE_LOCAL_PWR_EN)) { >> - __raw_writel(S5P_CORE_LOCAL_PWR_EN, >> - S5P_ARM_CORE1_CONFIGURATION); >> - >> + if (!exynos_cpu_power_state(cpu)) { >> + exynos_cpu_powerup(cpu); >> timeout = 10; >> >> /* wait max 10 ms until cpu1 is on */ >> - while ((__raw_readl(S5P_ARM_CORE1_STATUS) >> - & S5P_CORE_LOCAL_PWR_EN) != S5P_CORE_LOCAL_PWR_EN) { >> + while (exynos_cpu_power_state(cpu) != S5P_CORE_LOCAL_PWR_EN) >> { >> if (timeout-- == 0) >> break; >> >> -- > > You may cleanup the definitions of 'S5P_ARM_CORE1_CONFIGURATION/STATUS' in > regs-pmu.h once hotplug.c uses the generic power control functions. OK, will re-post a new version rebased on your for-next branch soon. Regards, Abhilash > > - Kukjin >
next prev parent reply other threads:[~2014-05-13 10:13 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-05 16:26 [PATCH v5 0/5] MCPM backend for Exynos5420 Abhilash Kesavan 2014-05-05 16:26 ` Abhilash Kesavan [not found] ` <1399307221-8659-1-git-send-email-a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2014-05-05 16:26 ` [PATCH v5 1/5] ARM: EXYNOS: Add generic cpu power control functions for all exynos based SoCs Abhilash Kesavan 2014-05-05 16:26 ` Abhilash Kesavan 2014-05-13 2:24 ` Kukjin Kim 2014-05-13 2:24 ` Kukjin Kim 2014-05-13 10:12 ` Abhilash Kesavan 2014-05-13 10:12 ` Abhilash Kesavan 2014-05-15 21:11 ` Tomasz Figa 2014-05-15 21:11 ` Tomasz Figa 2014-05-16 5:07 ` Abhilash Kesavan 2014-05-16 5:07 ` Abhilash Kesavan 2014-05-17 0:32 ` Tomasz Figa 2014-05-17 0:32 ` Tomasz Figa 2014-05-19 2:42 ` Abhilash Kesavan 2014-05-19 2:42 ` Abhilash Kesavan 2014-05-05 16:26 ` [PATCH v5 2/5] ARM: EXYNOS: use generic exynos cpu power control functions Abhilash Kesavan 2014-05-05 16:26 ` Abhilash Kesavan 2014-05-13 2:28 ` Kukjin Kim 2014-05-13 2:28 ` Kukjin Kim 2014-05-13 10:13 ` Abhilash Kesavan [this message] 2014-05-13 10:13 ` Abhilash Kesavan 2014-05-05 16:27 ` [PATCH v5 4/5] ARM: dts: exynos5420: add CCI node Abhilash Kesavan 2014-05-05 16:27 ` Abhilash Kesavan 2014-05-05 16:26 ` [PATCH v5 3/5] arm: exynos: Add generic cluster power control functions Abhilash Kesavan 2014-05-05 16:26 ` Abhilash Kesavan 2014-05-05 16:27 ` [PATCH v5 5/5] arm: exynos: Add MCPM call-back functions Abhilash Kesavan 2014-05-05 16:27 ` Abhilash Kesavan 2014-05-05 18:12 ` Nicolas Pitre 2014-05-05 18:12 ` Nicolas Pitre 2014-05-27 11:07 ` Arnd Bergmann 2014-05-27 11:07 ` Arnd Bergmann 2014-05-27 11:39 ` Kukjin Kim 2014-05-27 11:39 ` Kukjin Kim 2014-05-27 14:25 ` Abhilash Kesavan 2014-05-27 15:17 ` Kukjin Kim 2014-05-27 15:17 ` Kukjin Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAM4voanOEpe-b98GKant9w+=YMQpE3az7a4=eMGW0aX9NpnO9g@mail.gmail.com' \ --to=kesavan.abhilash@gmail.com \ --cc=Dave.Martin@arm.com \ --cc=abrestic@chromium.org \ --cc=arnd@arndb.de \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=grant.likely@linaro.org \ --cc=inderpal.s@samsung.com \ --cc=jhbird.choi@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=nicolas.pitre@linaro.org \ --cc=robh+dt@kernel.org \ --cc=skon.hwang@samsung.com \ --cc=t.figa@samsung.com \ --cc=thomas.ab@samsung.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.