From: Taehee Yoo <ap420073@gmail.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Netdev <netdev@vger.kernel.org>,
David Laight <David.Laight@aculab.com>,
Johannes Berg <johannes@sipsolutions.net>,
Nicolai Stange <nstange@suse.de>,
derosier@gmail.com, Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org,
michael.hennerich@analog.com, linux-wpan@vger.kernel.org,
stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com,
linux-wimax@intel.com, emmanuel.grumbach@intel.com,
Luciano Coelho <luciano.coelho@intel.com>,
stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org,
ath10k@lists.infradead.org, wcn36xx@lists.infradead.org,
merez@codeaurora.org, pizza@shaftnet.org,
Larry Finger <Larry.Finger@lwfinger.net>,
amitkarwar@gmail.com, ganapathi.bhat@nxp.com,
huxinming820@gmail.com, marcel@holtmann.org,
johan.hedberg@gmail.com, alex.aring@gmail.com,
jukka.rissanen@linux.intel.com, franky.lin@broadcom.com,
hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com,
wright.feng@infineon.com, chi-hsien.lin@infineon.com
Subject: Re: [PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE
Date: Sun, 8 Nov 2020 03:16:37 +0900 [thread overview]
Message-ID: <CAMArcTVgw3hN=ffb88hYrOy5jD1W+V1XKDtd_Rs2mkoOSGj5Vw@mail.gmail.com> (raw)
In-Reply-To: <175a3cc2738.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
On Sun, 8 Nov 2020 at 02:41, Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
Hi Arend,
Thank you for the review!
> On November 7, 2020 6:25:15 PM Taehee Yoo <ap420073@gmail.com> wrote:
>
> > If THIS_MODULE is not set, the module would be removed while debugfs is
> > being used.
> > It eventually makes kernel panic.
>
> Is this really a valid concern in the context of debugs? I tend to say it
> is not. Whenever I am using debugs to debug my driver I make sure to avoid
> removing it.
I think getting rid of every scenario of the kernel panic is the
first priority thing.
So I'm sure that trying to avoid kernel panic is always valid even
in the debugging context.
Thanks a lot!
Taehee Yoo
WARNING: multiple messages have this Message-ID (diff)
From: Taehee Yoo <ap420073@gmail.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: alex.aring@gmail.com, emmanuel.grumbach@intel.com,
chi-hsien.lin@infineon.com, amitkarwar@gmail.com,
ganapathi.bhat@nxp.com, Luciano Coelho <luciano.coelho@intel.com>,
ath10k@lists.infradead.org, wcn36xx@lists.infradead.org,
stefan@datenfreihafen.org, merez@codeaurora.org, stf_xl@wp.pl,
pkshih@realtek.com, Nicolai Stange <nstange@suse.de>,
chung-hsien.hsu@infineon.com, wright.feng@infineon.com,
inaky.perez-gonzalez@intel.com, derosier@gmail.com,
David Laight <David.Laight@aculab.com>,
b43-dev@lists.infradead.org, Jakub Kicinski <kuba@kernel.org>,
ath11k@lists.infradead.org, johan.hedberg@gmail.com,
michael.hennerich@analog.com, marcel@holtmann.org,
hante.meuleman@broadcom.com, linux-wimax@intel.com,
jukka.rissanen@linux.intel.com, Kalle Valo <kvalo@codeaurora.org>,
franky.lin@broadcom.com, huxinming820@gmail.com,
Netdev <netdev@vger.kernel.org>,
linux-wireless@vger.kernel.org, linux-bluetooth@vger.kernel.org,
wil6210@qti.qualcomm.com,
Johannes Berg <johannes@sipsolutions.net>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wpan@vger.kernel.org, David Miller <davem@davemloft.net>,
pizza@shaftnet.org
Subject: Re: [PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE
Date: Sun, 8 Nov 2020 03:16:37 +0900 [thread overview]
Message-ID: <CAMArcTVgw3hN=ffb88hYrOy5jD1W+V1XKDtd_Rs2mkoOSGj5Vw@mail.gmail.com> (raw)
In-Reply-To: <175a3cc2738.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
On Sun, 8 Nov 2020 at 02:41, Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
Hi Arend,
Thank you for the review!
> On November 7, 2020 6:25:15 PM Taehee Yoo <ap420073@gmail.com> wrote:
>
> > If THIS_MODULE is not set, the module would be removed while debugfs is
> > being used.
> > It eventually makes kernel panic.
>
> Is this really a valid concern in the context of debugs? I tend to say it
> is not. Whenever I am using debugs to debug my driver I make sure to avoid
> removing it.
I think getting rid of every scenario of the kernel panic is the
first priority thing.
So I'm sure that trying to avoid kernel panic is always valid even
in the debugging context.
Thanks a lot!
Taehee Yoo
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Taehee Yoo <ap420073@gmail.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: alex.aring@gmail.com, emmanuel.grumbach@intel.com,
chi-hsien.lin@infineon.com, amitkarwar@gmail.com,
ganapathi.bhat@nxp.com, Luciano Coelho <luciano.coelho@intel.com>,
ath10k@lists.infradead.org, wcn36xx@lists.infradead.org,
stefan@datenfreihafen.org, merez@codeaurora.org, stf_xl@wp.pl,
pkshih@realtek.com, Nicolai Stange <nstange@suse.de>,
chung-hsien.hsu@infineon.com, wright.feng@infineon.com,
inaky.perez-gonzalez@intel.com, derosier@gmail.com,
David Laight <David.Laight@aculab.com>,
b43-dev@lists.infradead.org, Jakub Kicinski <kuba@kernel.org>,
ath11k@lists.infradead.org, johan.hedberg@gmail.com,
michael.hennerich@analog.com, marcel@holtmann.org,
hante.meuleman@broadcom.com, linux-wimax@intel.com,
jukka.rissanen@linux.intel.com, Kalle Valo <kvalo@codeaurora.org>,
franky.lin@broadcom.com, huxinming820@gmail.com,
Netdev <netdev@vger.kernel.org>,
linux-wireless@vger.kernel.org, linux-bluetooth@vger.kernel.org,
wil6210@qti.qualcomm.com,
Johannes Berg <johannes@sipsolutions.net>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wpan@vger.kernel.org, David Miller <davem@davemloft.net>,
pizza@shaftnet.org
Subject: Re: [PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE
Date: Sun, 8 Nov 2020 03:16:37 +0900 [thread overview]
Message-ID: <CAMArcTVgw3hN=ffb88hYrOy5jD1W+V1XKDtd_Rs2mkoOSGj5Vw@mail.gmail.com> (raw)
In-Reply-To: <175a3cc2738.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
On Sun, 8 Nov 2020 at 02:41, Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
Hi Arend,
Thank you for the review!
> On November 7, 2020 6:25:15 PM Taehee Yoo <ap420073@gmail.com> wrote:
>
> > If THIS_MODULE is not set, the module would be removed while debugfs is
> > being used.
> > It eventually makes kernel panic.
>
> Is this really a valid concern in the context of debugs? I tend to say it
> is not. Whenever I am using debugs to debug my driver I make sure to avoid
> removing it.
I think getting rid of every scenario of the kernel panic is the
first priority thing.
So I'm sure that trying to avoid kernel panic is always valid even
in the debugging context.
Thanks a lot!
Taehee Yoo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-11-07 18:16 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 17:21 [PATCH net v2 00/21] net: avoid to remove module when its debugfs is being used Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 01/21] net: set .owner to THIS_MODULE Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:48 ` net: avoid to remove module when its debugfs is being used bluez.test.bot
2020-11-07 17:21 ` [PATCH net v2 02/21] mac80211: set .owner to THIS_MODULE Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 03/21] cfg80211: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 04/21] netdevsim: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 05/21] ieee802154: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 06/21] i2400m: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 07/21] wlcore: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 08/21] wl1251: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 09/21] iwlwifi: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 10/21] iwlegacy: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 11/21] rtlwifi: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 12/21] ath11k: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 13/21] ath10k: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 14/21] wcn36xx: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 15/21] wil6210: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 16/21] cw1200: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 17/21] brcmfmac: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:41 ` Arend Van Spriel
2020-11-07 17:41 ` Arend Van Spriel
2020-11-07 17:41 ` Arend Van Spriel
2020-11-07 18:16 ` Taehee Yoo [this message]
2020-11-07 18:16 ` Taehee Yoo
2020-11-07 18:16 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 18/21] b43legacy: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 19/21] b43: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 20/21] mwifiex: mwifiex: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` [PATCH net v2 21/21] Bluetooth: " Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 17:21 ` Taehee Yoo
2020-11-07 19:05 ` [PATCH net v2 00/21] net: avoid to remove module when its debugfs is being used Jakub Kicinski
2020-11-07 19:05 ` Jakub Kicinski
2020-11-07 19:05 ` Jakub Kicinski
2020-11-07 19:52 ` Taehee Yoo
2020-11-07 19:52 ` Taehee Yoo
2020-11-07 19:52 ` Taehee Yoo
2020-11-10 8:32 ` Johannes Berg
2020-11-10 8:32 ` Johannes Berg
2020-11-10 8:32 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMArcTVgw3hN=ffb88hYrOy5jD1W+V1XKDtd_Rs2mkoOSGj5Vw@mail.gmail.com' \
--to=ap420073@gmail.com \
--cc=David.Laight@aculab.com \
--cc=Larry.Finger@lwfinger.net \
--cc=alex.aring@gmail.com \
--cc=amitkarwar@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=b43-dev@lists.infradead.org \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=davem@davemloft.net \
--cc=derosier@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=franky.lin@broadcom.com \
--cc=ganapathi.bhat@nxp.com \
--cc=hante.meuleman@broadcom.com \
--cc=huxinming820@gmail.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=johan.hedberg@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=jukka.rissanen@linux.intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wimax@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=marcel@holtmann.org \
--cc=merez@codeaurora.org \
--cc=michael.hennerich@analog.com \
--cc=netdev@vger.kernel.org \
--cc=nstange@suse.de \
--cc=pizza@shaftnet.org \
--cc=pkshih@realtek.com \
--cc=stefan@datenfreihafen.org \
--cc=stf_xl@wp.pl \
--cc=wcn36xx@lists.infradead.org \
--cc=wil6210@qti.qualcomm.com \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.