From: Jinpu Wang <jinpu.wang@cloud.ionos.com>
To: Viswas G <Viswas.G@microchip.com>
Cc: Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Vasanthalakshmi.Tharmarajan@microchip.com,
Ruksar.devadi@microchip.com,
Vishakha Channapattan <vishakhavc@google.com>,
Radha Ramachandran <radha@google.com>
Subject: Re: [PATCH 6/7] pm80xx: Reset PI and CI memory during re-initialize
Date: Thu, 4 Mar 2021 10:37:08 +0100 [thread overview]
Message-ID: <CAMGffEnmGcP9C3swBDugRAchzwdhrEt0QUz9m96d3SkVLQXR6g@mail.gmail.com> (raw)
In-Reply-To: <20210224155802.13292-7-Viswas.G@microchip.com>
On Wed, Feb 24, 2021 at 4:48 PM Viswas G <Viswas.G@microchip.com> wrote:
>
> Producer index(PI) outbound queue and consumer index(CI)
> for Outbound queue are in DMA memory. These values should
> be reset to 0 during driver reinitialization.
Why "reinitialization", the function init_default_table_values is
called from chip init?
>
> Signed-off-by: Viswas G <Viswas.G@microchip.com>
> Signed-off-by: Ruksar Devadi <Ruksar.devadi@microchip.com>
> Signed-off-by: Ashokkumar N <Ashokkumar.N@microchip.com>
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 2 ++
> drivers/scsi/pm8001/pm80xx_hwi.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
> index 4e0ce044ac69..783149b8b127 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -240,6 +240,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
> pm8001_ha->memoryMap.region[ci_offset + i].phys_addr_lo;
> pm8001_ha->inbnd_q_tbl[i].ci_virt =
> pm8001_ha->memoryMap.region[ci_offset + i].virt_ptr;
> + pm8001_write_32(pm8001_ha->inbnd_q_tbl[i].ci_virt, 0, 0);
> offsetib = i * 0x20;
> pm8001_ha->inbnd_q_tbl[i].pi_pci_bar =
> get_pci_bar_index(pm8001_mr32(addressib,
> @@ -268,6 +269,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
> 0 | (10 << 16) | (i << 24);
> pm8001_ha->outbnd_q_tbl[i].pi_virt =
> pm8001_ha->memoryMap.region[pi_offset + i].virt_ptr;
> + pm8001_write_32(pm8001_ha->outbnd_q_tbl[i].pi_virt, 0, 0);
> offsetob = i * 0x24;
> pm8001_ha->outbnd_q_tbl[i].ci_pci_bar =
> get_pci_bar_index(pm8001_mr32(addressob,
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index 1aa3a499c85a..0f2c57e054ac 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -787,6 +787,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
> pm8001_ha->memoryMap.region[ci_offset + i].phys_addr_lo;
> pm8001_ha->inbnd_q_tbl[i].ci_virt =
> pm8001_ha->memoryMap.region[ci_offset + i].virt_ptr;
> + pm8001_write_32(pm8001_ha->inbnd_q_tbl[i].ci_virt, 0, 0);
> offsetib = i * 0x20;
> pm8001_ha->inbnd_q_tbl[i].pi_pci_bar =
> get_pci_bar_index(pm8001_mr32(addressib,
> @@ -820,6 +821,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
> pm8001_ha->outbnd_q_tbl[i].interrup_vec_cnt_delay = (i << 24);
> pm8001_ha->outbnd_q_tbl[i].pi_virt =
> pm8001_ha->memoryMap.region[pi_offset + i].virt_ptr;
> + pm8001_write_32(pm8001_ha->outbnd_q_tbl[i].pi_virt, 0, 0);
> offsetob = i * 0x24;
> pm8001_ha->outbnd_q_tbl[i].ci_pci_bar =
> get_pci_bar_index(pm8001_mr32(addressob,
> --
> 2.16.3
>
next prev parent reply other threads:[~2021-03-04 9:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 15:57 [PATCH 0/7] pm80xx updates Viswas G
2021-02-24 15:57 ` [PATCH 1/7] pm80xx: Add sysfs attribute to check mpi state Viswas G
2021-03-04 9:27 ` Jinpu Wang
2021-02-24 15:57 ` [PATCH 2/7] pm80xx: Add sysfs attribute to track RAAE count Viswas G
2021-03-04 9:28 ` Jinpu Wang
2021-02-24 15:57 ` [PATCH 3/7] pm80xx: Add sysfs attribute to track iop0 count Viswas G
2021-03-04 9:28 ` Jinpu Wang
2021-02-24 15:57 ` [PATCH 4/7] pm80xx: Add sysfs attribute to track iop1 count Viswas G
2021-03-04 9:28 ` Jinpu Wang
2021-03-05 8:02 ` John Garry
2021-02-24 15:58 ` [PATCH 5/7] pm80xx: Completing pending IO after fatal error Viswas G
2021-03-04 9:32 ` Jinpu Wang
2021-02-24 15:58 ` [PATCH 6/7] pm80xx: Reset PI and CI memory during re-initialize Viswas G
2021-03-04 9:37 ` Jinpu Wang [this message]
2021-03-04 16:40 ` Viswas.G
2021-03-05 6:45 ` Jinpu Wang
2021-02-24 15:58 ` [PATCH 7/7] pm80xx: remove global lock from outbound queue processing Viswas G
2021-03-04 9:39 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMGffEnmGcP9C3swBDugRAchzwdhrEt0QUz9m96d3SkVLQXR6g@mail.gmail.com \
--to=jinpu.wang@cloud.ionos.com \
--cc=Ruksar.devadi@microchip.com \
--cc=Vasanthalakshmi.Tharmarajan@microchip.com \
--cc=Viswas.G@microchip.com \
--cc=linux-scsi@vger.kernel.org \
--cc=radha@google.com \
--cc=vishakhavc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.