From: Maxime Jourdan <mjourdan@baylibre.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Colin King <colin.king@canonical.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@baylibre.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-amlogic@lists.infradead.org, devel@driverdev.osuosl.org,
linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: meson: add missing allocation failure check on new_buf
Date: Fri, 13 Dec 2019 08:47:26 +0100 [thread overview]
Message-ID: <CAMO6naxT0syj74xvcectWXyVGmHfOU341A+15tC+GW4hsq+yJQ@mail.gmail.com> (raw)
In-Reply-To: <20191205080611.GY93017@google.com>
On Thu, Dec 5, 2019 at 9:06 AM Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
>
> On (19/12/04 14:11), Colin King wrote:
> [..]
> > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> > index 0a1a04fd5d13..8dd1396909d7 100644
> > --- a/drivers/staging/media/meson/vdec/vdec.c
> > +++ b/drivers/staging/media/meson/vdec/vdec.c
> > @@ -133,6 +133,8 @@ vdec_queue_recycle(struct amvdec_session *sess, struct vb2_buffer *vb)
> > struct amvdec_buffer *new_buf;
> >
> > new_buf = kmalloc(sizeof(*new_buf), GFP_KERNEL);
> > + if (!new_buf)
> > + return;
> > new_buf->vb = vb;
Thanks for the patch Colin.
>
> So the buffer is not getting recycled? IOW is leaked?
>
> -ss
The "recycle" mechanism in the meson vdec is a way to tell the
firmware that "hey, both userspace and kernel are done using this
buffer, you can start using it again".
Not queuing it for recycling means that the firmware won't use this
buffer again, it's not desirable of course, but if there is no memory
left to allocate a simple list element then there are bigger problems
at hand.
Either way, failing this allocation and returning instantly doesn't
leak anything or do any damage kernel-side.
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Jourdan <mjourdan@baylibre.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: devel@driverdev.osuosl.org, Kevin Hilman <khilman@baylibre.com>,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Colin King <colin.king@canonical.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: meson: add missing allocation failure check on new_buf
Date: Fri, 13 Dec 2019 07:47:26 +0000 [thread overview]
Message-ID: <CAMO6naxT0syj74xvcectWXyVGmHfOU341A+15tC+GW4hsq+yJQ@mail.gmail.com> (raw)
In-Reply-To: <20191205080611.GY93017@google.com>
On Thu, Dec 5, 2019 at 9:06 AM Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
>
> On (19/12/04 14:11), Colin King wrote:
> [..]
> > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> > index 0a1a04fd5d13..8dd1396909d7 100644
> > --- a/drivers/staging/media/meson/vdec/vdec.c
> > +++ b/drivers/staging/media/meson/vdec/vdec.c
> > @@ -133,6 +133,8 @@ vdec_queue_recycle(struct amvdec_session *sess, struct vb2_buffer *vb)
> > struct amvdec_buffer *new_buf;
> >
> > new_buf = kmalloc(sizeof(*new_buf), GFP_KERNEL);
> > + if (!new_buf)
> > + return;
> > new_buf->vb = vb;
Thanks for the patch Colin.
>
> So the buffer is not getting recycled? IOW is leaked?
>
> -ss
The "recycle" mechanism in the meson vdec is a way to tell the
firmware that "hey, both userspace and kernel are done using this
buffer, you can start using it again".
Not queuing it for recycling means that the firmware won't use this
buffer again, it's not desirable of course, but if there is no memory
left to allocate a simple list element then there are bigger problems
at hand.
Either way, failing this allocation and returning instantly doesn't
leak anything or do any damage kernel-side.
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Jourdan <mjourdan@baylibre.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: devel@driverdev.osuosl.org, Kevin Hilman <khilman@baylibre.com>,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Colin King <colin.king@canonical.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: meson: add missing allocation failure check on new_buf
Date: Fri, 13 Dec 2019 08:47:26 +0100 [thread overview]
Message-ID: <CAMO6naxT0syj74xvcectWXyVGmHfOU341A+15tC+GW4hsq+yJQ@mail.gmail.com> (raw)
In-Reply-To: <20191205080611.GY93017@google.com>
On Thu, Dec 5, 2019 at 9:06 AM Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
>
> On (19/12/04 14:11), Colin King wrote:
> [..]
> > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> > index 0a1a04fd5d13..8dd1396909d7 100644
> > --- a/drivers/staging/media/meson/vdec/vdec.c
> > +++ b/drivers/staging/media/meson/vdec/vdec.c
> > @@ -133,6 +133,8 @@ vdec_queue_recycle(struct amvdec_session *sess, struct vb2_buffer *vb)
> > struct amvdec_buffer *new_buf;
> >
> > new_buf = kmalloc(sizeof(*new_buf), GFP_KERNEL);
> > + if (!new_buf)
> > + return;
> > new_buf->vb = vb;
Thanks for the patch Colin.
>
> So the buffer is not getting recycled? IOW is leaked?
>
> -ss
The "recycle" mechanism in the meson vdec is a way to tell the
firmware that "hey, both userspace and kernel are done using this
buffer, you can start using it again".
Not queuing it for recycling means that the firmware won't use this
buffer again, it's not desirable of course, but if there is no memory
left to allocate a simple list element then there are bigger problems
at hand.
Either way, failing this allocation and returning instantly doesn't
leak anything or do any damage kernel-side.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Jourdan <mjourdan@baylibre.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: devel@driverdev.osuosl.org, Kevin Hilman <khilman@baylibre.com>,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Colin King <colin.king@canonical.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: meson: add missing allocation failure check on new_buf
Date: Fri, 13 Dec 2019 08:47:26 +0100 [thread overview]
Message-ID: <CAMO6naxT0syj74xvcectWXyVGmHfOU341A+15tC+GW4hsq+yJQ@mail.gmail.com> (raw)
In-Reply-To: <20191205080611.GY93017@google.com>
On Thu, Dec 5, 2019 at 9:06 AM Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
>
> On (19/12/04 14:11), Colin King wrote:
> [..]
> > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> > index 0a1a04fd5d13..8dd1396909d7 100644
> > --- a/drivers/staging/media/meson/vdec/vdec.c
> > +++ b/drivers/staging/media/meson/vdec/vdec.c
> > @@ -133,6 +133,8 @@ vdec_queue_recycle(struct amvdec_session *sess, struct vb2_buffer *vb)
> > struct amvdec_buffer *new_buf;
> >
> > new_buf = kmalloc(sizeof(*new_buf), GFP_KERNEL);
> > + if (!new_buf)
> > + return;
> > new_buf->vb = vb;
Thanks for the patch Colin.
>
> So the buffer is not getting recycled? IOW is leaked?
>
> -ss
The "recycle" mechanism in the meson vdec is a way to tell the
firmware that "hey, both userspace and kernel are done using this
buffer, you can start using it again".
Not queuing it for recycling means that the firmware won't use this
buffer again, it's not desirable of course, but if there is no memory
left to allocate a simple list element then there are bigger problems
at hand.
Either way, failing this allocation and returning instantly doesn't
leak anything or do any damage kernel-side.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Jourdan <mjourdan@baylibre.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: devel@driverdev.osuosl.org, Kevin Hilman <khilman@baylibre.com>,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Colin King <colin.king@canonical.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: meson: add missing allocation failure check on new_buf
Date: Fri, 13 Dec 2019 08:47:26 +0100 [thread overview]
Message-ID: <CAMO6naxT0syj74xvcectWXyVGmHfOU341A+15tC+GW4hsq+yJQ@mail.gmail.com> (raw)
In-Reply-To: <20191205080611.GY93017@google.com>
On Thu, Dec 5, 2019 at 9:06 AM Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
>
> On (19/12/04 14:11), Colin King wrote:
> [..]
> > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> > index 0a1a04fd5d13..8dd1396909d7 100644
> > --- a/drivers/staging/media/meson/vdec/vdec.c
> > +++ b/drivers/staging/media/meson/vdec/vdec.c
> > @@ -133,6 +133,8 @@ vdec_queue_recycle(struct amvdec_session *sess, struct vb2_buffer *vb)
> > struct amvdec_buffer *new_buf;
> >
> > new_buf = kmalloc(sizeof(*new_buf), GFP_KERNEL);
> > + if (!new_buf)
> > + return;
> > new_buf->vb = vb;
Thanks for the patch Colin.
>
> So the buffer is not getting recycled? IOW is leaked?
>
> -ss
The "recycle" mechanism in the meson vdec is a way to tell the
firmware that "hey, both userspace and kernel are done using this
buffer, you can start using it again".
Not queuing it for recycling means that the firmware won't use this
buffer again, it's not desirable of course, but if there is no memory
left to allocate a simple list element then there are bigger problems
at hand.
Either way, failing this allocation and returning instantly doesn't
leak anything or do any damage kernel-side.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-12-13 7:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 14:11 [PATCH] media: meson: add missing allocation failure check on new_buf Colin King
2019-12-04 14:11 ` Colin King
2019-12-04 14:11 ` Colin King
2019-12-04 14:11 ` Colin King
2019-12-04 14:11 ` Colin King
2019-12-05 2:39 ` Kevin Hilman
2019-12-05 2:39 ` Kevin Hilman
2019-12-05 2:39 ` Kevin Hilman
2019-12-05 2:39 ` Kevin Hilman
2019-12-05 2:39 ` Kevin Hilman
2019-12-05 8:06 ` Sergey Senozhatsky
2019-12-05 8:06 ` Sergey Senozhatsky
2019-12-05 8:06 ` Sergey Senozhatsky
2019-12-05 8:06 ` Sergey Senozhatsky
2019-12-05 8:06 ` Sergey Senozhatsky
2019-12-13 7:47 ` Maxime Jourdan [this message]
2019-12-13 7:47 ` Maxime Jourdan
2019-12-13 7:47 ` Maxime Jourdan
2019-12-13 7:47 ` Maxime Jourdan
2019-12-13 7:47 ` Maxime Jourdan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMO6naxT0syj74xvcectWXyVGmHfOU341A+15tC+GW4hsq+yJQ@mail.gmail.com \
--to=mjourdan@baylibre.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.