From: Bartosz Golaszewski <brgl@bgdev.pl> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Michal Simek <michal.simek@xilinx.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Guenter Roeck <linux@roeck-us.net>, linux-iio <linux-iio@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: Re: [PATCH v4 1/3] devres: provide devm_krealloc() Date: Tue, 14 Jul 2020 16:48:29 +0200 [thread overview] Message-ID: <CAMRc=Me66Yi-zXVEOgHW3m_TtaEAz4QMQUJRjeS0WKayJBHC9w@mail.gmail.com> (raw) In-Reply-To: <20200713192901.GD3703480@smile.fi.intel.com> On Mon, Jul 13, 2020 at 9:29 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Jul 13, 2020 at 04:59:32PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > Implement the managed variant of krealloc(). This function works with > > all memory allocated by devm_kmalloc() (or devres functions using it > > implicitly like devm_kmemdup(), devm_kstrdup() etc.). > > > > Managed realloc'ed chunks can be manually released with devm_kfree(). > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > --- > > .../driver-api/driver-model/devres.rst | 1 + > > drivers/base/devres.c | 67 +++++++++++++++++++ > > include/linux/device.h | 2 + > > 3 files changed, 70 insertions(+) > > > > diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst > > index eaaaafc21134f..f318a5c0033c1 100644 > > --- a/Documentation/driver-api/driver-model/devres.rst > > +++ b/Documentation/driver-api/driver-model/devres.rst > > @@ -354,6 +354,7 @@ MEM > > devm_kmalloc() > > devm_kmalloc_array() > > devm_kmemdup() > > + devm_krealloc() > > devm_kstrdup() > > devm_kvasprintf() > > devm_kzalloc() > > diff --git a/drivers/base/devres.c b/drivers/base/devres.c > > index ed615d3b9cf15..1775d35462300 100644 > > --- a/drivers/base/devres.c > > +++ b/drivers/base/devres.c > > @@ -837,6 +837,73 @@ void *devm_kmalloc(struct device *dev, size_t size, gfp_t gfp) > > } > > EXPORT_SYMBOL_GPL(devm_kmalloc); > > > > +/** > > + * devm_krealloc - Resource-managed krealloc() > > + * @dev: Device to re-allocate memory for > > + * @ptr: Pointer to the memory chunk to re-allocate > > + * @new_size: New allocation size > > + * @gfp: Allocation gfp flags > > + * > > + * Managed krealloc(). Resizes the memory chunk allocated with devm_kmalloc(). > > + * Behaves similarly to regular krealloc(): if @ptr is NULL or ZERO_SIZE_PTR, > > + * it's the equivalent of devm_kmalloc(). If new_size is zero, it returns > > 'it frees the previously allocated memory and returns' > > > + * ZERO_SIZE_PTR. This function doesn't change the order in which the release > > + * callback for the re-alloc'ed devres will be called (except when falling back > > + * to devm_kmalloc() > > 'or when freeing resources when new_size is zero' > This is nit-picking but ok. :) [snip!] > > +++ b/include/linux/device.h > > @@ -206,6 +206,8 @@ int devres_release_group(struct device *dev, void *id); > > > > /* managed devm_k.alloc/kfree for device drivers */ > > void *devm_kmalloc(struct device *dev, size_t size, gfp_t gfp) __malloc; > > > +void *devm_krealloc(struct device *dev, void *ptr, size_t size, > > + gfp_t gfp) __must_check; > > Strange indentation, also you can move __must_check to the beginning of the > declaration. > There's nothing wrong with this indentation, what do you mean? __must_check is usually put at the end of the line. [snip!] Bart
WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <brgl@bgdev.pl> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>, Lars-Peter Clausen <lars@metafoo.de>, linux-iio <linux-iio@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Michal Simek <michal.simek@xilinx.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Guenter Roeck <linux@roeck-us.net>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Hartmut Knaack <knaack.h@gmx.de>, Jonathan Cameron <jic23@kernel.org> Subject: Re: [PATCH v4 1/3] devres: provide devm_krealloc() Date: Tue, 14 Jul 2020 16:48:29 +0200 [thread overview] Message-ID: <CAMRc=Me66Yi-zXVEOgHW3m_TtaEAz4QMQUJRjeS0WKayJBHC9w@mail.gmail.com> (raw) In-Reply-To: <20200713192901.GD3703480@smile.fi.intel.com> On Mon, Jul 13, 2020 at 9:29 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Jul 13, 2020 at 04:59:32PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > Implement the managed variant of krealloc(). This function works with > > all memory allocated by devm_kmalloc() (or devres functions using it > > implicitly like devm_kmemdup(), devm_kstrdup() etc.). > > > > Managed realloc'ed chunks can be manually released with devm_kfree(). > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > --- > > .../driver-api/driver-model/devres.rst | 1 + > > drivers/base/devres.c | 67 +++++++++++++++++++ > > include/linux/device.h | 2 + > > 3 files changed, 70 insertions(+) > > > > diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst > > index eaaaafc21134f..f318a5c0033c1 100644 > > --- a/Documentation/driver-api/driver-model/devres.rst > > +++ b/Documentation/driver-api/driver-model/devres.rst > > @@ -354,6 +354,7 @@ MEM > > devm_kmalloc() > > devm_kmalloc_array() > > devm_kmemdup() > > + devm_krealloc() > > devm_kstrdup() > > devm_kvasprintf() > > devm_kzalloc() > > diff --git a/drivers/base/devres.c b/drivers/base/devres.c > > index ed615d3b9cf15..1775d35462300 100644 > > --- a/drivers/base/devres.c > > +++ b/drivers/base/devres.c > > @@ -837,6 +837,73 @@ void *devm_kmalloc(struct device *dev, size_t size, gfp_t gfp) > > } > > EXPORT_SYMBOL_GPL(devm_kmalloc); > > > > +/** > > + * devm_krealloc - Resource-managed krealloc() > > + * @dev: Device to re-allocate memory for > > + * @ptr: Pointer to the memory chunk to re-allocate > > + * @new_size: New allocation size > > + * @gfp: Allocation gfp flags > > + * > > + * Managed krealloc(). Resizes the memory chunk allocated with devm_kmalloc(). > > + * Behaves similarly to regular krealloc(): if @ptr is NULL or ZERO_SIZE_PTR, > > + * it's the equivalent of devm_kmalloc(). If new_size is zero, it returns > > 'it frees the previously allocated memory and returns' > > > + * ZERO_SIZE_PTR. This function doesn't change the order in which the release > > + * callback for the re-alloc'ed devres will be called (except when falling back > > + * to devm_kmalloc() > > 'or when freeing resources when new_size is zero' > This is nit-picking but ok. :) [snip!] > > +++ b/include/linux/device.h > > @@ -206,6 +206,8 @@ int devres_release_group(struct device *dev, void *id); > > > > /* managed devm_k.alloc/kfree for device drivers */ > > void *devm_kmalloc(struct device *dev, size_t size, gfp_t gfp) __malloc; > > > +void *devm_krealloc(struct device *dev, void *ptr, size_t size, > > + gfp_t gfp) __must_check; > > Strange indentation, also you can move __must_check to the beginning of the > declaration. > There's nothing wrong with this indentation, what do you mean? __must_check is usually put at the end of the line. [snip!] Bart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-14 14:48 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-13 14:59 [PATCH v4 0/3] devres: provide and use devm_krealloc() Bartosz Golaszewski 2020-07-13 14:59 ` Bartosz Golaszewski 2020-07-13 14:59 ` [PATCH v4 1/3] devres: provide devm_krealloc() Bartosz Golaszewski 2020-07-13 14:59 ` Bartosz Golaszewski 2020-07-13 19:29 ` Andy Shevchenko 2020-07-13 19:29 ` Andy Shevchenko 2020-07-14 14:48 ` Bartosz Golaszewski [this message] 2020-07-14 14:48 ` Bartosz Golaszewski 2020-07-13 14:59 ` [PATCH v4 2/3] hwmon: pmbus: use more devres helpers Bartosz Golaszewski 2020-07-13 14:59 ` Bartosz Golaszewski 2020-07-13 14:59 ` [PATCH v4 3/3] iio: adc: xilinx-xadc: use devm_krealloc() Bartosz Golaszewski 2020-07-13 14:59 ` Bartosz Golaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMRc=Me66Yi-zXVEOgHW3m_TtaEAz4QMQUJRjeS0WKayJBHC9w@mail.gmail.com' \ --to=brgl@bgdev.pl \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bgolaszewski@baylibre.com \ --cc=gregkh@linuxfoundation.org \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=michal.simek@xilinx.com \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.