From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
dev@lists.96boards.org, Rob Herring <robh+dt@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Andy Shevchenko <andy@infradead.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Frank Rowand <frowand.list@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-i2c <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 1/4] eeprom: at24: Allow passing gpiodesc from pdata
Date: Thu, 23 Aug 2018 13:14:32 +0200 [thread overview]
Message-ID: <CAMRc=MeR242hFhk4Nts9Fo2110NYAKoULDZPpe_mTrpdA2CNSw@mail.gmail.com> (raw)
In-Reply-To: <20180823103332.32047-2-linus.walleij@linaro.org>
2018-08-23 12:33 GMT+02:00 Linus Walleij <linus.walleij@linaro.org>:
> This makes it possible to pass an initialized GPIO descriptor
> to the driver through platform data.
>
> This is useful when we are dealing with EEPROMs on expansion
> boards where the GPIO has to be looked up indirectly using a
> connector abstraction (several systems using the same
> connector) so the machine descriptor tables cannot be used
> to associate the descriptor with the device and we then want
> to pass this descriptor on to the EEPROM driver this way
> instead.
>
Ugh I don't like this at all. In fact I'm right now trying to *get
rid* of platform_data from at24 in favor of device properties[1].
Part of the changes from my series actually removes the setup function
from at24 and replaces it with a notifier fired by the nvmem
framework.
I would really prefer that we introduce some generic way of handling
write-protect mechanisms in nvmem. Maybe starting by moving the
wp_gpio to nvmem and then passing it in nvmem_config?
Best regards,
Bartosz Golaszewski
[1] https://patchwork.kernel.org/cover/10562365/
WARNING: multiple messages have this Message-ID (diff)
From: brgl@bgdev.pl (Bartosz Golaszewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] eeprom: at24: Allow passing gpiodesc from pdata
Date: Thu, 23 Aug 2018 13:14:32 +0200 [thread overview]
Message-ID: <CAMRc=MeR242hFhk4Nts9Fo2110NYAKoULDZPpe_mTrpdA2CNSw@mail.gmail.com> (raw)
In-Reply-To: <20180823103332.32047-2-linus.walleij@linaro.org>
2018-08-23 12:33 GMT+02:00 Linus Walleij <linus.walleij@linaro.org>:
> This makes it possible to pass an initialized GPIO descriptor
> to the driver through platform data.
>
> This is useful when we are dealing with EEPROMs on expansion
> boards where the GPIO has to be looked up indirectly using a
> connector abstraction (several systems using the same
> connector) so the machine descriptor tables cannot be used
> to associate the descriptor with the device and we then want
> to pass this descriptor on to the EEPROM driver this way
> instead.
>
Ugh I don't like this at all. In fact I'm right now trying to *get
rid* of platform_data from at24 in favor of device properties[1].
Part of the changes from my series actually removes the setup function
from at24 and replaces it with a notifier fired by the nvmem
framework.
I would really prefer that we introduce some generic way of handling
write-protect mechanisms in nvmem. Maybe starting by moving the
wp_gpio to nvmem and then passing it in nvmem_config?
Best regards,
Bartosz Golaszewski
[1] https://patchwork.kernel.org/cover/10562365/
next prev parent reply other threads:[~2018-08-23 11:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 10:33 [PATCH 0/4 v1] Mezzanine Low Speed connector bus Linus Walleij
2018-08-23 10:33 ` Linus Walleij
2018-08-23 10:33 ` [PATCH 1/4] eeprom: at24: Allow passing gpiodesc from pdata Linus Walleij
2018-08-23 10:33 ` Linus Walleij
2018-08-23 11:14 ` Bartosz Golaszewski [this message]
2018-08-23 11:14 ` Bartosz Golaszewski
2018-08-23 10:33 ` [PATCH 2/4] spi: Make of_find_spi_device_by_node() available Linus Walleij
2018-08-23 10:33 ` Linus Walleij
2018-08-23 10:33 ` [PATCH 3/4] bus: Add DT bindings for 96Boards low speed connector Linus Walleij
2018-08-23 10:33 ` Linus Walleij
2018-08-23 13:45 ` Rob Herring
2018-08-23 13:45 ` Rob Herring
2018-09-05 9:05 ` Linus Walleij
2018-09-05 9:05 ` Linus Walleij
2018-08-23 10:33 ` [PATCH 4/4] bus: 96boards Low-Speed Connector Linus Walleij
2018-08-23 10:33 ` Linus Walleij
2018-08-23 23:06 ` [PATCH 0/4 v1] Mezzanine Low Speed connector bus Frank Rowand
2018-08-23 23:06 ` Frank Rowand
2018-08-24 7:28 ` Linus Walleij
2018-08-24 7:28 ` Linus Walleij
2018-11-15 16:26 ` Frank Rowand
2018-11-15 16:26 ` Frank Rowand
2018-11-15 22:59 ` Linus Walleij
2018-11-15 22:59 ` Linus Walleij
2018-11-16 0:16 ` Frank Rowand
2018-11-16 0:16 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MeR242hFhk4Nts9Fo2110NYAKoULDZPpe_mTrpdA2CNSw@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dev@lists.96boards.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.