From: Bartosz Golaszewski <brgl@bgdev.pl> To: Jakub Kicinski <kuba@kernel.org> Cc: Jonathan Corbet <corbet@lwn.net>, Jeff Kirsher <jeffrey.t.kirsher@intel.com>, "David S . Miller" <davem@davemloft.net>, John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>, Mark Lee <Mark-MC.Lee@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Russell King <linux@armlinux.org.uk>, Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, linux-doc <linux-doc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, intel-wired-lan@lists.osuosl.org, netdev <netdev@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, "moderated list:ARM/Mediatek SoC..." <linux-mediatek@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Fabien Parent <fparent@baylibre.com>, Stephane Le Provost <stephane.leprovost@mediatek.com>, Pedro Tsai <pedro.tsai@mediatek.com>, Andrew Perepech <andrew.perepech@mediatek.com>, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: Re: [PATCH 03/11] net: devres: relax devm_register_netdev() Date: Tue, 23 Jun 2020 11:12:24 +0200 [thread overview] Message-ID: <CAMRc=MfF1RbQCJ62QhscFLu1HKYRc9M-2SMep1_vTJ2xhKjLAA@mail.gmail.com> (raw) In-Reply-To: <20200622154943.02782b5a@kicinski-fedora-PC1C0HJN> wt., 23 cze 2020 o 00:49 Jakub Kicinski <kuba@kernel.org> napisał(a): > > On Mon, 22 Jun 2020 12:00:48 +0200 Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > This devres helper registers a release callback that only unregisters > > the net_device. It works perfectly fine with netdev structs that are > > not managed on their own. There's no reason to check this - drop the > > warning. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > I think the reasoning for this suggestion was to catch possible UAF > errors. The netdev doesn't necessarily has to be from devm_alloc_* > but it has to be part of devm-ed memory or memory which is freed > after driver's remove callback. > Yes I understand that UAF was the concern here, but this limitation is unnecessary. In its current form devm_register_netdev() only works for struct net_device allocated with devm_alloc_etherdev(). Meanwhile calling alloc_netdev() (which doesn't have its devm counterpart yet - I may look into it shortly), then registering a devm action with devm_add_action_or_reset() which would free this memory is a perfectly fine use case. This patch would make it possible. > Are there cases in practice where you've seen the netdev not being > devm allocated? As I said above - alloc_netdev() used by wireless, can, usb etc. drivers doesn't have a devres variant. Bartosz
WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <brgl@bgdev.pl> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH 03/11] net: devres: relax devm_register_netdev() Date: Tue, 23 Jun 2020 11:12:24 +0200 [thread overview] Message-ID: <CAMRc=MfF1RbQCJ62QhscFLu1HKYRc9M-2SMep1_vTJ2xhKjLAA@mail.gmail.com> (raw) In-Reply-To: <20200622154943.02782b5a@kicinski-fedora-PC1C0HJN> wt., 23 cze 2020 o 00:49 Jakub Kicinski <kuba@kernel.org> napisa?(a): > > On Mon, 22 Jun 2020 12:00:48 +0200 Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > This devres helper registers a release callback that only unregisters > > the net_device. It works perfectly fine with netdev structs that are > > not managed on their own. There's no reason to check this - drop the > > warning. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > I think the reasoning for this suggestion was to catch possible UAF > errors. The netdev doesn't necessarily has to be from devm_alloc_* > but it has to be part of devm-ed memory or memory which is freed > after driver's remove callback. > Yes I understand that UAF was the concern here, but this limitation is unnecessary. In its current form devm_register_netdev() only works for struct net_device allocated with devm_alloc_etherdev(). Meanwhile calling alloc_netdev() (which doesn't have its devm counterpart yet - I may look into it shortly), then registering a devm action with devm_add_action_or_reset() which would free this memory is a perfectly fine use case. This patch would make it possible. > Are there cases in practice where you've seen the netdev not being > devm allocated? As I said above - alloc_netdev() used by wireless, can, usb etc. drivers doesn't have a devres variant. Bartosz
next prev parent reply other threads:[~2020-06-23 9:12 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-22 10:00 [PATCH 00/11] net: improve devres helpers Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 01/11] net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init() Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 02/11] net: ethernet: ixgbe: don't call devm_mdiobus_free() Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 03/11] net: devres: relax devm_register_netdev() Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 22:49 ` Jakub Kicinski 2020-06-22 22:49 ` [Intel-wired-lan] " Jakub Kicinski 2020-06-23 9:12 ` Bartosz Golaszewski [this message] 2020-06-23 9:12 ` Bartosz Golaszewski 2020-06-23 20:16 ` Jakub Kicinski 2020-06-23 20:16 ` [Intel-wired-lan] " Jakub Kicinski 2020-06-23 20:16 ` Jakub Kicinski 2020-06-23 20:16 ` Jakub Kicinski 2020-06-22 10:00 ` [PATCH 04/11] net: devres: rename the release callback of devm_register_netdev() Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 05/11] Documentation: devres: add missing mdio helper Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 06/11] phy: un-inline devm_mdiobus_register() Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 23:55 ` Florian Fainelli 2020-06-22 23:55 ` [Intel-wired-lan] " Florian Fainelli 2020-06-25 9:16 ` Bartosz Golaszewski 2020-06-25 9:16 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-25 9:16 ` Bartosz Golaszewski 2020-06-25 9:16 ` Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 07/11] phy: mdio: add kerneldoc for __devm_mdiobus_register() Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 08/11] net: phy: don't abuse devres in devm_mdiobus_register() Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 09/11] of: mdio: remove the 'extern' keyword from function declarations Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 10/11] of: mdio: provide devm_of_mdiobus_register() Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski 2020-06-22 10:00 ` [PATCH 11/11] net: ethernet: mtk-star-emac: use devm_of_mdiobus_register() Bartosz Golaszewski 2020-06-22 10:00 ` [Intel-wired-lan] " Bartosz Golaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMRc=MfF1RbQCJ62QhscFLu1HKYRc9M-2SMep1_vTJ2xhKjLAA@mail.gmail.com' \ --to=brgl@bgdev.pl \ --cc=Mark-MC.Lee@mediatek.com \ --cc=andrew.perepech@mediatek.com \ --cc=andrew@lunn.ch \ --cc=bgolaszewski@baylibre.com \ --cc=corbet@lwn.net \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=fparent@baylibre.com \ --cc=frowand.list@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=john@phrozen.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=matthias.bgg@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=pedro.tsai@mediatek.com \ --cc=robh+dt@kernel.org \ --cc=sean.wang@mediatek.com \ --cc=stephane.leprovost@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.