From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
Date: Mon, 2 May 2022 14:02:03 +0200 [thread overview]
Message-ID: <CAMRc=MfrvUn8w_aPL0_kej83-tf06GTUcJJ3bC0p8O8rd2Ae0Q@mail.gmail.com> (raw)
In-Reply-To: <20220426175938.2262966-1-robh@kernel.org>
On Tue, Apr 26, 2022 at 8:00 PM Rob Herring <robh@kernel.org> wrote:
>
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix the example in samsung,s3c2410-i2c.yaml
>
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
For at24 part:
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
> .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 6b61a8cf6137..d14e0accbda8 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -120,7 +120,9 @@ properties:
> - const: giantec,gt24c32a
> - const: atmel,24c32
> - items:
> - - const: renesas,r1ex24128
> + - enum:
> + - renesas,r1ex24128
> + - samsung,s524ad0xd1
> - const: atmel,24c128
>
> label:
> diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> index c26230518957..3d5782deb97d 100644
> --- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> @@ -123,7 +123,7 @@ examples:
> samsung,i2c-slave-addr = <0x66>;
>
> eeprom@50 {
> - compatible = "samsung,s524ad0xd1";
> + compatible = "samsung,s524ad0xd1", "atmel,24c128";
> reg = <0x50>;
> };
> };
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: eeprom/at24: Add samsung, s524ad0xd1 compatible
Date: Mon, 2 May 2022 14:02:03 +0200 [thread overview]
Message-ID: <CAMRc=MfrvUn8w_aPL0_kej83-tf06GTUcJJ3bC0p8O8rd2Ae0Q@mail.gmail.com> (raw)
In-Reply-To: <20220426175938.2262966-1-robh@kernel.org>
On Tue, Apr 26, 2022 at 8:00 PM Rob Herring <robh@kernel.org> wrote:
>
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix the example in samsung,s3c2410-i2c.yaml
>
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
For at24 part:
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
> .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 6b61a8cf6137..d14e0accbda8 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -120,7 +120,9 @@ properties:
> - const: giantec,gt24c32a
> - const: atmel,24c32
> - items:
> - - const: renesas,r1ex24128
> + - enum:
> + - renesas,r1ex24128
> + - samsung,s524ad0xd1
> - const: atmel,24c128
>
> label:
> diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> index c26230518957..3d5782deb97d 100644
> --- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> @@ -123,7 +123,7 @@ examples:
> samsung,i2c-slave-addr = <0x66>;
>
> eeprom@50 {
> - compatible = "samsung,s524ad0xd1";
> + compatible = "samsung,s524ad0xd1", "atmel,24c128";
> reg = <0x50>;
> };
> };
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-02 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 17:59 [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible Rob Herring
2022-04-26 17:59 ` [PATCH v2] dt-bindings: eeprom/at24: Add samsung, s524ad0xd1 compatible Rob Herring
2022-04-26 18:31 ` [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible Krzysztof Kozlowski
2022-04-26 18:31 ` Krzysztof Kozlowski
2022-05-02 12:02 ` Bartosz Golaszewski [this message]
2022-05-02 12:02 ` [PATCH v2] dt-bindings: eeprom/at24: Add samsung, s524ad0xd1 compatible Bartosz Golaszewski
2022-05-02 18:40 ` [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible Rob Herring
2022-05-02 18:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MfrvUn8w_aPL0_kej83-tf06GTUcJJ3bC0p8O8rd2Ae0Q@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=alim.akhtar@samsung.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.