From: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> To: Chen Zhou <chenzhou10@huawei.com> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel <dri-devel@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH next] drm/gma500: remove set but not used variables 'hist_reg' Date: Wed, 8 Jan 2020 10:12:35 +0100 [thread overview] Message-ID: <CAMeQTsY2+9Z1ShVrp1AbQo4+VbVymHrv2meg7353=YDoWbFeLw@mail.gmail.com> (raw) In-Reply-To: <20191227114811.14907-1-chenzhou10@huawei.com> On Fri, Dec 27, 2019 at 12:52 PM Chen Zhou <chenzhou10@huawei.com> wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/gma500/psb_irq.c: In function psb_irq_turn_off_dpst: > drivers/gpu/drm/gma500/psb_irq.c:473:6: > warning: variable hist_reg set but not used [-Wunused-but-set-variable] > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Chen Zhou <chenzhou10@huawei.com> Applied to drm-misc-next Thanks Patrik > --- > drivers/gpu/drm/gma500/psb_irq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c > index 40a37e4..91f9001 100644 > --- a/drivers/gpu/drm/gma500/psb_irq.c > +++ b/drivers/gpu/drm/gma500/psb_irq.c > @@ -470,12 +470,11 @@ void psb_irq_turn_off_dpst(struct drm_device *dev) > { > struct drm_psb_private *dev_priv = > (struct drm_psb_private *) dev->dev_private; > - u32 hist_reg; > u32 pwm_reg; > > if (gma_power_begin(dev, false)) { > PSB_WVDC32(0x00000000, HISTOGRAM_INT_CONTROL); > - hist_reg = PSB_RVDC32(HISTOGRAM_INT_CONTROL); > + PSB_RVDC32(HISTOGRAM_INT_CONTROL); > > psb_disable_pipestat(dev_priv, 0, PIPE_DPST_EVENT_ENABLE); > > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> To: Chen Zhou <chenzhou10@huawei.com> Cc: David Airlie <airlied@linux.ie>, dri-devel <dri-devel@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH next] drm/gma500: remove set but not used variables 'hist_reg' Date: Wed, 8 Jan 2020 10:12:35 +0100 [thread overview] Message-ID: <CAMeQTsY2+9Z1ShVrp1AbQo4+VbVymHrv2meg7353=YDoWbFeLw@mail.gmail.com> (raw) In-Reply-To: <20191227114811.14907-1-chenzhou10@huawei.com> On Fri, Dec 27, 2019 at 12:52 PM Chen Zhou <chenzhou10@huawei.com> wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/gma500/psb_irq.c: In function psb_irq_turn_off_dpst: > drivers/gpu/drm/gma500/psb_irq.c:473:6: > warning: variable hist_reg set but not used [-Wunused-but-set-variable] > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Chen Zhou <chenzhou10@huawei.com> Applied to drm-misc-next Thanks Patrik > --- > drivers/gpu/drm/gma500/psb_irq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c > index 40a37e4..91f9001 100644 > --- a/drivers/gpu/drm/gma500/psb_irq.c > +++ b/drivers/gpu/drm/gma500/psb_irq.c > @@ -470,12 +470,11 @@ void psb_irq_turn_off_dpst(struct drm_device *dev) > { > struct drm_psb_private *dev_priv = > (struct drm_psb_private *) dev->dev_private; > - u32 hist_reg; > u32 pwm_reg; > > if (gma_power_begin(dev, false)) { > PSB_WVDC32(0x00000000, HISTOGRAM_INT_CONTROL); > - hist_reg = PSB_RVDC32(HISTOGRAM_INT_CONTROL); > + PSB_RVDC32(HISTOGRAM_INT_CONTROL); > > psb_disable_pipestat(dev_priv, 0, PIPE_DPST_EVENT_ENABLE); > > -- > 2.7.4 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-08 9:12 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-27 11:48 [PATCH next] drm/gma500: remove set but not used variables 'hist_reg' Chen Zhou 2019-12-27 11:48 ` Chen Zhou 2020-01-08 9:12 ` Patrik Jakobsson [this message] 2020-01-08 9:12 ` Patrik Jakobsson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMeQTsY2+9Z1ShVrp1AbQo4+VbVymHrv2meg7353=YDoWbFeLw@mail.gmail.com' \ --to=patrik.r.jakobsson@gmail.com \ --cc=airlied@linux.ie \ --cc=chenzhou10@huawei.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.