From: Zheyu Ma <zheyuma97@gmail.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, patches@opensource.cirrus.com,
alsa-devel@alsa-project.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: wm8731: Disable the regulator when probing fails
Date: Wed, 6 Apr 2022 19:25:04 +0800 [thread overview]
Message-ID: <CAMhUBj=RMT_jOkzsET2jx3Opihz6P+sNczZrNK+efkWr0SN2LQ@mail.gmail.com> (raw)
In-Reply-To: <20220406100121.GV38351@ediswmail.ad.cirrus.com>
Hi Charles,
On Wed, Apr 6, 2022 at 6:01 PM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
>
> On Tue, Apr 05, 2022 at 08:10:38PM +0800, Zheyu Ma wrote:
> > When the driver fails during probing, the driver should disable the
> > regulator, not just handle it in wm8731_hw_init().
> >
> > The following log reveals it:
> >
> > [ 17.812483] WARNING: CPU: 1 PID: 364 at drivers/regulator/core.c:2257 _regulator_put+0x3ec/0x4e0
> > [ 17.815958] RIP: 0010:_regulator_put+0x3ec/0x4e0
> > [ 17.824467] Call Trace:
> > [ 17.824774] <TASK>
> > [ 17.825040] regulator_bulk_free+0x82/0xe0
> > [ 17.825514] devres_release_group+0x319/0x3d0
> > [ 17.825882] i2c_device_probe+0x766/0x940
> > [ 17.829198] i2c_register_driver+0xb5/0x130
> >
> > Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> > ---
>
> Mark just merged a big chain overhauling a lot of this driver, at
> the very least this patch is going to require a rebase on top of
> that lot.
Thanks for your reminder, this bug has been fixed in the latest code.
Regards,
Zheyu Ma
WARNING: multiple messages have this Message-ID (diff)
From: Zheyu Ma <zheyuma97@gmail.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: wm8731: Disable the regulator when probing fails
Date: Wed, 6 Apr 2022 19:25:04 +0800 [thread overview]
Message-ID: <CAMhUBj=RMT_jOkzsET2jx3Opihz6P+sNczZrNK+efkWr0SN2LQ@mail.gmail.com> (raw)
In-Reply-To: <20220406100121.GV38351@ediswmail.ad.cirrus.com>
Hi Charles,
On Wed, Apr 6, 2022 at 6:01 PM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
>
> On Tue, Apr 05, 2022 at 08:10:38PM +0800, Zheyu Ma wrote:
> > When the driver fails during probing, the driver should disable the
> > regulator, not just handle it in wm8731_hw_init().
> >
> > The following log reveals it:
> >
> > [ 17.812483] WARNING: CPU: 1 PID: 364 at drivers/regulator/core.c:2257 _regulator_put+0x3ec/0x4e0
> > [ 17.815958] RIP: 0010:_regulator_put+0x3ec/0x4e0
> > [ 17.824467] Call Trace:
> > [ 17.824774] <TASK>
> > [ 17.825040] regulator_bulk_free+0x82/0xe0
> > [ 17.825514] devres_release_group+0x319/0x3d0
> > [ 17.825882] i2c_device_probe+0x766/0x940
> > [ 17.829198] i2c_register_driver+0xb5/0x130
> >
> > Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> > ---
>
> Mark just merged a big chain overhauling a lot of this driver, at
> the very least this patch is going to require a rebase on top of
> that lot.
Thanks for your reminder, this bug has been fixed in the latest code.
Regards,
Zheyu Ma
next prev parent reply other threads:[~2022-04-06 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 12:10 [PATCH] ASoC: wm8731: Disable the regulator when probing fails Zheyu Ma
2022-04-05 12:10 ` Zheyu Ma
2022-04-06 10:01 ` Charles Keepax
2022-04-06 10:01 ` Charles Keepax
2022-04-06 11:25 ` Zheyu Ma [this message]
2022-04-06 11:25 ` Zheyu Ma
2022-04-08 11:24 ` Mark Brown
2022-04-08 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMhUBj=RMT_jOkzsET2jx3Opihz6P+sNczZrNK+efkWr0SN2LQ@mail.gmail.com' \
--to=zheyuma97@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.