All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-efi <linux-efi@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Nicolas Pitre <nico@fluxnic.net>,
	Linus Walleij <linus.walleij@linaro.org>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 1/5] ARM: decompressor: move headroom variable out of LC0
Date: Fri, 27 Mar 2020 14:59:23 +0100	[thread overview]
Message-ID: <CAMj1kXF2nqGNL+YnfrPqRH3+ceYkpUqJzU4wbR1HMdmPZ+crqA@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWewhg9nDNrKw7F6f3uajxvw_mBZs17cZL64FQ8VrvrNA@mail.gmail.com>

Hallo Geert,

On Fri, 27 Mar 2020 at 14:23, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Ard,
>
> Thanks for your patch!
>
> On Fri, Mar 27, 2020 at 11:59 AM Ard Biesheuvel <ardb@kernel.org> wrote:
> > Before breaking up LC0 into different pieces, move out the variable
> > that is already place relative (given that it subtracts 'restart' in
>
> placed
>

Actually, what I meant here was 'place-relative', i.e., the expression
subtracts two symbol offsets, whereas the others are absolute, link
time values that need to be fixed up according to the actual runtime
location of the code.


> > the expression) and so its value does not need to be added to the
> > runtime address of the LC0 symbol itself.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>

Thanks,
Ard.

WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-efi <linux-efi@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Nicolas Pitre <nico@fluxnic.net>,
	Linus Walleij <linus.walleij@linaro.org>,
	Russell King <linux@armlinux.org.uk>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/5] ARM: decompressor: move headroom variable out of LC0
Date: Fri, 27 Mar 2020 14:59:23 +0100	[thread overview]
Message-ID: <CAMj1kXF2nqGNL+YnfrPqRH3+ceYkpUqJzU4wbR1HMdmPZ+crqA@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWewhg9nDNrKw7F6f3uajxvw_mBZs17cZL64FQ8VrvrNA@mail.gmail.com>

Hallo Geert,

On Fri, 27 Mar 2020 at 14:23, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Ard,
>
> Thanks for your patch!
>
> On Fri, Mar 27, 2020 at 11:59 AM Ard Biesheuvel <ardb@kernel.org> wrote:
> > Before breaking up LC0 into different pieces, move out the variable
> > that is already place relative (given that it subtracts 'restart' in
>
> placed
>

Actually, what I meant here was 'place-relative', i.e., the expression
subtracts two symbol offsets, whereas the others are absolute, link
time values that need to be fixed up according to the actual runtime
location of the code.


> > the expression) and so its value does not need to be added to the
> > runtime address of the LC0 symbol itself.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>

Thanks,
Ard.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-03-27 13:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 10:59 [PATCH 0/5] ARM: simplify handover from UEFI to decompressor Ard Biesheuvel
2020-03-27 10:59 ` Ard Biesheuvel
2020-03-27 10:59 ` [PATCH 1/5] ARM: decompressor: move headroom variable out of LC0 Ard Biesheuvel
2020-03-27 10:59   ` Ard Biesheuvel
2020-03-27 13:23   ` Geert Uytterhoeven
2020-03-27 13:23     ` Geert Uytterhoeven
2020-03-27 13:59     ` Ard Biesheuvel [this message]
2020-03-27 13:59       ` Ard Biesheuvel
2020-03-27 10:59 ` [PATCH 2/5] ARM: decompressor: split off _edata and stack base into separate object Ard Biesheuvel
2020-03-27 10:59   ` Ard Biesheuvel
2020-03-27 13:23   ` Geert Uytterhoeven
2020-03-27 13:23     ` Geert Uytterhoeven
2020-03-27 10:59 ` [PATCH 3/5] ARM: decompressor: defer loading of the contents of the LC0 structure Ard Biesheuvel
2020-03-27 10:59   ` Ard Biesheuvel
2020-03-27 13:24   ` Geert Uytterhoeven
2020-03-27 13:24     ` Geert Uytterhoeven
2020-03-27 10:59 ` [PATCH 4/5] ARM: decompressor: move GOT into .data for EFI enabled builds Ard Biesheuvel
2020-03-27 10:59   ` Ard Biesheuvel
2020-03-27 10:59 ` [PATCH 5/5] ARM: decompressor: run decompressor in place if loaded via UEFI Ard Biesheuvel
2020-03-27 10:59   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXF2nqGNL+YnfrPqRH3+ceYkpUqJzU4wbR1HMdmPZ+crqA@mail.gmail.com \
    --to=ardb@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.