From: Ard Biesheuvel <ardb@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Russell King <linux@armlinux.org.uk>,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org
Subject: Re: [PATCH] lib/xor: use r10 rather than r7 in xor_arm4regs_{2|3}
Date: Mon, 17 Oct 2022 15:49:42 +0200 [thread overview]
Message-ID: <CAMj1kXFpBH-aOR47fONFdt3B_w7WkmveD2PcS4AbEE=ZqAHX+A@mail.gmail.com> (raw)
In-Reply-To: <20221010175134.2671410-1-ndesaulniers@google.com>
On Mon, 10 Oct 2022 at 19:51, Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> kbuild test robot reports:
> In file included from crypto/xor.c:17:
> ./arch/arm/include/asm/xor.h:61:3: error: write to reserved register 'R7'
> GET_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:20:10: note: expanded from macro 'GET_BLOCK_4'
> __asm__("ldmia %0, {%1, %2, %3, %4}" \
> ^
> ./arch/arm/include/asm/xor.h:63:3: error: write to reserved register 'R7'
> PUT_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:42:23: note: expanded from macro 'PUT_BLOCK_4'
> __asm__ __volatile__("stmia %0!, {%2, %3, %4, %5}" \
> ^
> ./arch/arm/include/asm/xor.h:83:3: error: write to reserved register 'R7'
> GET_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:20:10: note: expanded from macro 'GET_BLOCK_4'
> __asm__("ldmia %0, {%1, %2, %3, %4}" \
> ^
> ./arch/arm/include/asm/xor.h:86:3: error: write to reserved register 'R7'
> PUT_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:42:23: note: expanded from macro 'PUT_BLOCK_4'
> __asm__ __volatile__("stmia %0!, {%2, %3, %4, %5}" \
> ^
> Thumb2 uses r7 rather than r11 as the frame pointer. Let's use r10
> rather than r7 for these temporaries.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1732
> Link: https://lore.kernel.org/llvm/202210072120.V1O2SuKY-lkp@intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm/include/asm/xor.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/xor.h b/arch/arm/include/asm/xor.h
> index 669cad5194d3..934b549905f5 100644
> --- a/arch/arm/include/asm/xor.h
> +++ b/arch/arm/include/asm/xor.h
> @@ -51,7 +51,7 @@ xor_arm4regs_2(unsigned long bytes, unsigned long * __restrict p1,
> register unsigned int a1 __asm__("r4");
> register unsigned int a2 __asm__("r5");
> register unsigned int a3 __asm__("r6");
> - register unsigned int a4 __asm__("r7");
> + register unsigned int a4 __asm__("r10");
> register unsigned int b1 __asm__("r8");
> register unsigned int b2 __asm__("r9");
> register unsigned int b3 __asm__("ip");
> @@ -73,7 +73,7 @@ xor_arm4regs_3(unsigned long bytes, unsigned long * __restrict p1,
> register unsigned int a1 __asm__("r4");
> register unsigned int a2 __asm__("r5");
> register unsigned int a3 __asm__("r6");
> - register unsigned int a4 __asm__("r7");
> + register unsigned int a4 __asm__("r10");
> register unsigned int b1 __asm__("r8");
> register unsigned int b2 __asm__("r9");
> register unsigned int b3 __asm__("ip");
> --
> 2.38.0.rc2.412.g84df46c1b4-goog
>
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Russell King <linux@armlinux.org.uk>,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org
Subject: Re: [PATCH] lib/xor: use r10 rather than r7 in xor_arm4regs_{2|3}
Date: Mon, 17 Oct 2022 15:49:42 +0200 [thread overview]
Message-ID: <CAMj1kXFpBH-aOR47fONFdt3B_w7WkmveD2PcS4AbEE=ZqAHX+A@mail.gmail.com> (raw)
In-Reply-To: <20221010175134.2671410-1-ndesaulniers@google.com>
On Mon, 10 Oct 2022 at 19:51, Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> kbuild test robot reports:
> In file included from crypto/xor.c:17:
> ./arch/arm/include/asm/xor.h:61:3: error: write to reserved register 'R7'
> GET_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:20:10: note: expanded from macro 'GET_BLOCK_4'
> __asm__("ldmia %0, {%1, %2, %3, %4}" \
> ^
> ./arch/arm/include/asm/xor.h:63:3: error: write to reserved register 'R7'
> PUT_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:42:23: note: expanded from macro 'PUT_BLOCK_4'
> __asm__ __volatile__("stmia %0!, {%2, %3, %4, %5}" \
> ^
> ./arch/arm/include/asm/xor.h:83:3: error: write to reserved register 'R7'
> GET_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:20:10: note: expanded from macro 'GET_BLOCK_4'
> __asm__("ldmia %0, {%1, %2, %3, %4}" \
> ^
> ./arch/arm/include/asm/xor.h:86:3: error: write to reserved register 'R7'
> PUT_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:42:23: note: expanded from macro 'PUT_BLOCK_4'
> __asm__ __volatile__("stmia %0!, {%2, %3, %4, %5}" \
> ^
> Thumb2 uses r7 rather than r11 as the frame pointer. Let's use r10
> rather than r7 for these temporaries.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1732
> Link: https://lore.kernel.org/llvm/202210072120.V1O2SuKY-lkp@intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm/include/asm/xor.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/xor.h b/arch/arm/include/asm/xor.h
> index 669cad5194d3..934b549905f5 100644
> --- a/arch/arm/include/asm/xor.h
> +++ b/arch/arm/include/asm/xor.h
> @@ -51,7 +51,7 @@ xor_arm4regs_2(unsigned long bytes, unsigned long * __restrict p1,
> register unsigned int a1 __asm__("r4");
> register unsigned int a2 __asm__("r5");
> register unsigned int a3 __asm__("r6");
> - register unsigned int a4 __asm__("r7");
> + register unsigned int a4 __asm__("r10");
> register unsigned int b1 __asm__("r8");
> register unsigned int b2 __asm__("r9");
> register unsigned int b3 __asm__("ip");
> @@ -73,7 +73,7 @@ xor_arm4regs_3(unsigned long bytes, unsigned long * __restrict p1,
> register unsigned int a1 __asm__("r4");
> register unsigned int a2 __asm__("r5");
> register unsigned int a3 __asm__("r6");
> - register unsigned int a4 __asm__("r7");
> + register unsigned int a4 __asm__("r10");
> register unsigned int b1 __asm__("r8");
> register unsigned int b2 __asm__("r9");
> register unsigned int b3 __asm__("ip");
> --
> 2.38.0.rc2.412.g84df46c1b4-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] lib/xor: use r10 rather than r7 in xor_arm4regs_{2|3}
Date: Mon, 17 Oct 2022 15:49:42 +0200 [thread overview]
Message-ID: <CAMj1kXFpBH-aOR47fONFdt3B_w7WkmveD2PcS4AbEE=ZqAHX+A@mail.gmail.com> (raw)
In-Reply-To: <20221010175134.2671410-1-ndesaulniers@google.com>
[-- Attachment #1: Type: text/plain, Size: 3146 bytes --]
On Mon, 10 Oct 2022 at 19:51, Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> kbuild test robot reports:
> In file included from crypto/xor.c:17:
> ./arch/arm/include/asm/xor.h:61:3: error: write to reserved register 'R7'
> GET_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:20:10: note: expanded from macro 'GET_BLOCK_4'
> __asm__("ldmia %0, {%1, %2, %3, %4}" \
> ^
> ./arch/arm/include/asm/xor.h:63:3: error: write to reserved register 'R7'
> PUT_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:42:23: note: expanded from macro 'PUT_BLOCK_4'
> __asm__ __volatile__("stmia %0!, {%2, %3, %4, %5}" \
> ^
> ./arch/arm/include/asm/xor.h:83:3: error: write to reserved register 'R7'
> GET_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:20:10: note: expanded from macro 'GET_BLOCK_4'
> __asm__("ldmia %0, {%1, %2, %3, %4}" \
> ^
> ./arch/arm/include/asm/xor.h:86:3: error: write to reserved register 'R7'
> PUT_BLOCK_4(p1);
> ^
> ./arch/arm/include/asm/xor.h:42:23: note: expanded from macro 'PUT_BLOCK_4'
> __asm__ __volatile__("stmia %0!, {%2, %3, %4, %5}" \
> ^
> Thumb2 uses r7 rather than r11 as the frame pointer. Let's use r10
> rather than r7 for these temporaries.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1732
> Link: https://lore.kernel.org/llvm/202210072120.V1O2SuKY-lkp(a)intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm/include/asm/xor.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/xor.h b/arch/arm/include/asm/xor.h
> index 669cad5194d3..934b549905f5 100644
> --- a/arch/arm/include/asm/xor.h
> +++ b/arch/arm/include/asm/xor.h
> @@ -51,7 +51,7 @@ xor_arm4regs_2(unsigned long bytes, unsigned long * __restrict p1,
> register unsigned int a1 __asm__("r4");
> register unsigned int a2 __asm__("r5");
> register unsigned int a3 __asm__("r6");
> - register unsigned int a4 __asm__("r7");
> + register unsigned int a4 __asm__("r10");
> register unsigned int b1 __asm__("r8");
> register unsigned int b2 __asm__("r9");
> register unsigned int b3 __asm__("ip");
> @@ -73,7 +73,7 @@ xor_arm4regs_3(unsigned long bytes, unsigned long * __restrict p1,
> register unsigned int a1 __asm__("r4");
> register unsigned int a2 __asm__("r5");
> register unsigned int a3 __asm__("r6");
> - register unsigned int a4 __asm__("r7");
> + register unsigned int a4 __asm__("r10");
> register unsigned int b1 __asm__("r8");
> register unsigned int b2 __asm__("r9");
> register unsigned int b3 __asm__("ip");
> --
> 2.38.0.rc2.412.g84df46c1b4-goog
>
next prev parent reply other threads:[~2022-10-17 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 13:15 arch/arm/include/asm/xor.h:60:3: error: write to reserved register 'R7' kernel test robot
2022-10-10 17:03 ` Nick Desaulniers
2022-10-10 17:03 ` Nick Desaulniers
2022-10-10 17:51 ` [PATCH] lib/xor: use r10 rather than r7 in xor_arm4regs_{2|3} Nick Desaulniers
2022-10-10 17:51 ` Nick Desaulniers
2022-10-10 17:51 ` Nick Desaulniers
2022-10-17 13:49 ` Ard Biesheuvel [this message]
2022-10-17 13:49 ` Ard Biesheuvel
2022-10-17 13:49 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXFpBH-aOR47fONFdt3B_w7WkmveD2PcS4AbEE=ZqAHX+A@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rostedt@goodmis.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.