From: Max Filippov <jcmvbkbc@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Mike Snitzer <snitzer@kernel.org>,
Joern Engel <joern@lazybastard.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Loic Poulain <loic.poulain@linaro.org>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 08/24] init: pass root_device_name explicitly
Date: Tue, 27 Jun 2023 03:38:50 -0700 [thread overview]
Message-ID: <CAMo8BfLtEw2jdRC-pK4kYuqmgEy-0QgXDodiF+gZEMygNQQBbA@mail.gmail.com> (raw)
In-Reply-To: <7e708dfa-4019-fe28-afbd-91ad847fada0@roeck-us.net>
On Mon, Jun 26, 2023 at 8:10 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 6/26/23 00:53, Christoph Hellwig wrote:
> > On Fri, Jun 23, 2023 at 05:08:59PM -0700, Guenter Roeck wrote:
> >> Hi,
> >>
> >> On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote:
> >>> Instead of declaring root_device_name as a global variable pass it as an
> >>> argument to the functions using it.
> >>>
> >>> Signed-off-by: Christoph Hellwig <hch@lst.de>
> >>
> >> This patch results in the following build error when trying to build
> >> xtensa:tinyconfig.
> >>
> >> WARNING: modpost: vmlinux: section mismatch in reference: strcpy.isra.0+0x14 (section: .text.unlikely) -> initcall_level_names (section: .init.data)
> >> ERROR: modpost: Section mismatches detected.
> >
> > I can reproduce these with gcc 13.1 on xtensa, but the report makes
> > no sense to me. If I disable CONFIG_CC_OPTIMIZE_FOR_SIZE it now reports
> > a similar warning for put_page intead of strcpy which seems just as
> > arcance.
> >
>
> I don't see that (I tried 11.3, 11.4, 12.3, and 13.1), but then I am not sure
> if this is worth tracking down. I just force CONFIG_SECTION_MISMATCH_WARN_ONLY=y
> for xtensa builds instead.
I believe it's yet another manifestation of the following issue:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938
Hunting is still on my todo list, but it's quite low, so I guess
forcing CONFIG_SECTION_MISMATCH_WARN_ONLY=y for xtensa
is the right thing to do for now.
--
Thanks.
-- Max
WARNING: multiple messages have this Message-ID (diff)
From: Max Filippov <jcmvbkbc@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Mike Snitzer <snitzer@kernel.org>,
Joern Engel <joern@lazybastard.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Loic Poulain <loic.poulain@linaro.org>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 08/24] init: pass root_device_name explicitly
Date: Tue, 27 Jun 2023 03:38:50 -0700 [thread overview]
Message-ID: <CAMo8BfLtEw2jdRC-pK4kYuqmgEy-0QgXDodiF+gZEMygNQQBbA@mail.gmail.com> (raw)
In-Reply-To: <7e708dfa-4019-fe28-afbd-91ad847fada0@roeck-us.net>
On Mon, Jun 26, 2023 at 8:10 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 6/26/23 00:53, Christoph Hellwig wrote:
> > On Fri, Jun 23, 2023 at 05:08:59PM -0700, Guenter Roeck wrote:
> >> Hi,
> >>
> >> On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote:
> >>> Instead of declaring root_device_name as a global variable pass it as an
> >>> argument to the functions using it.
> >>>
> >>> Signed-off-by: Christoph Hellwig <hch@lst.de>
> >>
> >> This patch results in the following build error when trying to build
> >> xtensa:tinyconfig.
> >>
> >> WARNING: modpost: vmlinux: section mismatch in reference: strcpy.isra.0+0x14 (section: .text.unlikely) -> initcall_level_names (section: .init.data)
> >> ERROR: modpost: Section mismatches detected.
> >
> > I can reproduce these with gcc 13.1 on xtensa, but the report makes
> > no sense to me. If I disable CONFIG_CC_OPTIMIZE_FOR_SIZE it now reports
> > a similar warning for put_page intead of strcpy which seems just as
> > arcance.
> >
>
> I don't see that (I tried 11.3, 11.4, 12.3, and 13.1), but then I am not sure
> if this is worth tracking down. I just force CONFIG_SECTION_MISMATCH_WARN_ONLY=y
> for xtensa builds instead.
I believe it's yet another manifestation of the following issue:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938
Hunting is still on my todo list, but it's quite low, so I guess
forcing CONFIG_SECTION_MISMATCH_WARN_ONLY=y for xtensa
is the right thing to do for now.
--
Thanks.
-- Max
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Max Filippov <jcmvbkbc@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jens Axboe <axboe@kernel.dk>,
Loic Poulain <loic.poulain@linaro.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, Joern Engel <joern@lazybastard.org>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Richard Weinberger <richard@nod.at>,
dm-devel@redhat.com, Mike Snitzer <snitzer@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [dm-devel] [PATCH 08/24] init: pass root_device_name explicitly
Date: Tue, 27 Jun 2023 03:38:50 -0700 [thread overview]
Message-ID: <CAMo8BfLtEw2jdRC-pK4kYuqmgEy-0QgXDodiF+gZEMygNQQBbA@mail.gmail.com> (raw)
In-Reply-To: <7e708dfa-4019-fe28-afbd-91ad847fada0@roeck-us.net>
On Mon, Jun 26, 2023 at 8:10 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 6/26/23 00:53, Christoph Hellwig wrote:
> > On Fri, Jun 23, 2023 at 05:08:59PM -0700, Guenter Roeck wrote:
> >> Hi,
> >>
> >> On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote:
> >>> Instead of declaring root_device_name as a global variable pass it as an
> >>> argument to the functions using it.
> >>>
> >>> Signed-off-by: Christoph Hellwig <hch@lst.de>
> >>
> >> This patch results in the following build error when trying to build
> >> xtensa:tinyconfig.
> >>
> >> WARNING: modpost: vmlinux: section mismatch in reference: strcpy.isra.0+0x14 (section: .text.unlikely) -> initcall_level_names (section: .init.data)
> >> ERROR: modpost: Section mismatches detected.
> >
> > I can reproduce these with gcc 13.1 on xtensa, but the report makes
> > no sense to me. If I disable CONFIG_CC_OPTIMIZE_FOR_SIZE it now reports
> > a similar warning for put_page intead of strcpy which seems just as
> > arcance.
> >
>
> I don't see that (I tried 11.3, 11.4, 12.3, and 13.1), but then I am not sure
> if this is worth tracking down. I just force CONFIG_SECTION_MISMATCH_WARN_ONLY=y
> for xtensa builds instead.
I believe it's yet another manifestation of the following issue:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938
Hunting is still on my todo list, but it's quite low, so I guess
forcing CONFIG_SECTION_MISMATCH_WARN_ONLY=y for xtensa
is the right thing to do for now.
--
Thanks.
-- Max
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2023-06-27 10:39 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 12:55 fix the name_to_dev_t mess v2 Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 01/24] driver core: return bool from driver_probe_done Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-06-05 17:22 ` Jens Axboe
2023-06-05 17:22 ` [dm-devel] " Jens Axboe
2023-06-05 17:22 ` Jens Axboe
2023-05-31 12:55 ` [PATCH 02/24] PM: hibernate: factor out a helper to find the resume device Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 03/24] PM: hibernate: remove the global snapshot_test variable Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 04/24] PM: hibernate: move finding the resume device out of software_resume Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-08-03 8:27 ` Vlastimil Babka
2023-08-03 8:27 ` [dm-devel] " Vlastimil Babka
2023-08-03 8:27 ` Vlastimil Babka
2023-08-04 10:31 ` Christoph Hellwig
2023-08-04 10:31 ` [dm-devel] " Christoph Hellwig
2023-08-04 10:31 ` Christoph Hellwig
2023-08-04 13:30 ` Greg Kroah-Hartman
2023-08-04 13:30 ` [dm-devel] " Greg Kroah-Hartman
2023-08-04 13:30 ` Greg Kroah-Hartman
2023-08-05 13:07 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-08-05 13:07 ` [dm-devel] " Linux regression tracking #adding (Thorsten Leemhuis)
2023-08-05 13:07 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-05-31 12:55 ` [PATCH 05/24] init: remove pointless Root_* values Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 06/24] init: rename mount_block_root to mount_root_generic Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 07/24] init: refactor mount_root Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 08/24] init: pass root_device_name explicitly Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-06-24 0:08 ` Guenter Roeck
2023-06-24 0:08 ` [dm-devel] " Guenter Roeck
2023-06-24 0:08 ` Guenter Roeck
2023-06-26 7:53 ` Christoph Hellwig
2023-06-26 7:53 ` [dm-devel] " Christoph Hellwig
2023-06-26 7:53 ` Christoph Hellwig
2023-06-26 14:50 ` Guenter Roeck
2023-06-26 14:50 ` [dm-devel] " Guenter Roeck
2023-06-26 14:50 ` Guenter Roeck
2023-06-27 10:38 ` Max Filippov [this message]
2023-06-27 10:38 ` [dm-devel] " Max Filippov
2023-06-27 10:38 ` Max Filippov
2023-05-31 12:55 ` [PATCH 09/24] init: don't remove the /dev/ prefix from error messages Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 10/24] init: handle ubi/mtd root mounting like all other root types Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` [PATCH 11/24] init: factor the root_wait logic in prepare_namespace into a helper Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 12/24] init: move the nfs/cifs/ram special cases out of name_to_dev_t Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 13/24] init: improve the name_to_dev_t interface Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` [PATCH 14/24] init: clear root_wait on all invalid root= strings Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 15/24] block: move the code to do early boot lookup of block devices to block/ Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 16/24] block: move more code to early-lookup.c Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` [PATCH 17/24] dm-snap: simplify the origin_dev == cow_dev check in snapshot_ctr Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` [PATCH 18/24] dm: open code dm_get_dev_t in dm_init_init Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 19/24] dm: remove dm_get_dev_t Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 20/24] dm: only call early_lookup_bdev from early boot context Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 21/24] PM: hibernate: don't use early_lookup_bdev in resume_store Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 22/24] mtd: block2mtd: factor the early block device open logic into a helper Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [PATCH 23/24] mtd: block2mtd: don't call early_lookup_bdev after the system is running Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` [PATCH 24/24] block: mark early_lookup_bdev as __init Christoph Hellwig
2023-05-31 12:55 ` [dm-devel] " Christoph Hellwig
2023-05-31 12:55 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-05-23 7:45 fix the name_to_dev_t mess Christoph Hellwig
2023-05-23 7:45 ` [PATCH 08/24] init: pass root_device_name explicitly Christoph Hellwig
2023-05-23 7:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8BfLtEw2jdRC-pK4kYuqmgEy-0QgXDodiF+gZEMygNQQBbA@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=joern@lazybastard.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=loic.poulain@linaro.org \
--cc=miquel.raynal@bootlin.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=richard@nod.at \
--cc=snitzer@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.