From: Jagan Teki <jagan@amarulasolutions.com>
To: Marek Vasut <marex@denx.de>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Inki Dae <inki.dae@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Fancy Fang <chen.fang@nxp.com>,
Tim Harvey <tharvey@gateworks.com>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Adam Ford <aford173@gmail.com>,
Neil Armstrong <narmstrong@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>,
linux-amarula <linux-amarula@amarulasolutions.com>
Subject: Re: [PATCH v7 01/10] drm: bridge: Add Samsung DSIM bridge driver
Date: Mon, 17 Oct 2022 13:13:17 +0530 [thread overview]
Message-ID: <CAMty3ZBLQu8YijrSVdt84-J9hoOx8qcRSaGF-FvZVsJEWVaXjQ@mail.gmail.com> (raw)
In-Reply-To: <bad48f67-5fe6-d69c-51b0-bac3fa9d2719@denx.de>
On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut <marex@denx.de> wrote:
>
> On 10/17/22 04:49, Jagan Teki wrote:
> > On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote:
> >>
> >> On 10/5/22 17:13, Jagan Teki wrote:
> >>> Samsung MIPI DSIM controller is common DSI IP that can be used in various
> >>> SoCs like Exynos, i.MX8M Mini/Nano.
> >>>
> >>> In order to access this DSI controller between various platform SoCs,
> >>> the ideal way to incorporate this in the drm stack is via the drm bridge
> >>> driver.
> >>>
> >>> This patch is trying to differentiate platform-specific and bridge driver
> >>> code by maintaining exynos platform glue code in exynos_drm_dsi.c driver
> >>> and common bridge driver code in samsung-dsim.c providing that the new
> >>> platform-specific glue should be supported in the bridge driver, unlike
> >>> exynos platform drm drivers.
> >>>
> >>> - Add samsung_dsim_plat_data for keeping platform-specific attributes like
> >>> host_ops, irq_ops, and hw_type.
> >>>
> >>> - Initialize the plat_data hooks for exynos platform in exynos_drm_dsi.c.
> >>>
> >>> - samsung_dsim_probe is the common probe call across exynos_drm_dsi.c and
> >>> samsung-dsim.c.
> >>>
> >>> - plat_data hooks like host_ops and irq_ops are invoked during the
> >>> respective bridge call chains.
> >>
> >> Maybe the Subject should say "Split ... driver" or "Move ... driver" ,
> >> since it is not adding a new driver here ?
> >
> > Though it is not added a completely new driver, it is adding more
> > infrastructure platform code to be compatible with both Exynos and
> > i.MX8M. This is the prime reason for adding that commit head and
> > explaining the same in the commit body.
>
> Diffstat looks like this:
>
> drivers/gpu/drm/bridge/samsung-dsim.c | 1703 ++++++++++++++++++++++
> drivers/gpu/drm/exynos/Kconfig | 1 +
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 ++---------------------
> include/drm/bridge/samsung-dsim.h | 113 ++
> 7 files changed, 1952 insertions(+), 1653 deletions(-)
>
> Looks to me like most of the code is just moved from existing driver in
> this patch.
Yeah, as I explained (from commit) it is moved, updated, and written
the plat code. How about this head?
"drm: bridge: Add Samsung DSIM bridge (Split from exynos_drm_dsi)"
Jagan.
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Marek Vasut <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
linux-amarula <linux-amarula@amarulasolutions.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Neil Armstrong <narmstrong@linaro.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Kyungmin Park <kyungmin.park@samsung.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
Robert Foss <robert.foss@linaro.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
NXP Linux Team <linux-imx@nxp.com>,
Fancy Fang <chen.fang@nxp.com>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Adam Ford <aford173@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v7 01/10] drm: bridge: Add Samsung DSIM bridge driver
Date: Mon, 17 Oct 2022 13:13:17 +0530 [thread overview]
Message-ID: <CAMty3ZBLQu8YijrSVdt84-J9hoOx8qcRSaGF-FvZVsJEWVaXjQ@mail.gmail.com> (raw)
In-Reply-To: <bad48f67-5fe6-d69c-51b0-bac3fa9d2719@denx.de>
On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut <marex@denx.de> wrote:
>
> On 10/17/22 04:49, Jagan Teki wrote:
> > On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote:
> >>
> >> On 10/5/22 17:13, Jagan Teki wrote:
> >>> Samsung MIPI DSIM controller is common DSI IP that can be used in various
> >>> SoCs like Exynos, i.MX8M Mini/Nano.
> >>>
> >>> In order to access this DSI controller between various platform SoCs,
> >>> the ideal way to incorporate this in the drm stack is via the drm bridge
> >>> driver.
> >>>
> >>> This patch is trying to differentiate platform-specific and bridge driver
> >>> code by maintaining exynos platform glue code in exynos_drm_dsi.c driver
> >>> and common bridge driver code in samsung-dsim.c providing that the new
> >>> platform-specific glue should be supported in the bridge driver, unlike
> >>> exynos platform drm drivers.
> >>>
> >>> - Add samsung_dsim_plat_data for keeping platform-specific attributes like
> >>> host_ops, irq_ops, and hw_type.
> >>>
> >>> - Initialize the plat_data hooks for exynos platform in exynos_drm_dsi.c.
> >>>
> >>> - samsung_dsim_probe is the common probe call across exynos_drm_dsi.c and
> >>> samsung-dsim.c.
> >>>
> >>> - plat_data hooks like host_ops and irq_ops are invoked during the
> >>> respective bridge call chains.
> >>
> >> Maybe the Subject should say "Split ... driver" or "Move ... driver" ,
> >> since it is not adding a new driver here ?
> >
> > Though it is not added a completely new driver, it is adding more
> > infrastructure platform code to be compatible with both Exynos and
> > i.MX8M. This is the prime reason for adding that commit head and
> > explaining the same in the commit body.
>
> Diffstat looks like this:
>
> drivers/gpu/drm/bridge/samsung-dsim.c | 1703 ++++++++++++++++++++++
> drivers/gpu/drm/exynos/Kconfig | 1 +
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 ++---------------------
> include/drm/bridge/samsung-dsim.h | 113 ++
> 7 files changed, 1952 insertions(+), 1653 deletions(-)
>
> Looks to me like most of the code is just moved from existing driver in
> this patch.
Yeah, as I explained (from commit) it is moved, updated, and written
the plat code. How about this head?
"drm: bridge: Add Samsung DSIM bridge (Split from exynos_drm_dsi)"
Jagan.
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Marek Vasut <marex@denx.de>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Inki Dae <inki.dae@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Fancy Fang <chen.fang@nxp.com>,
Tim Harvey <tharvey@gateworks.com>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Adam Ford <aford173@gmail.com>,
Neil Armstrong <narmstrong@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>,
linux-amarula <linux-amarula@amarulasolutions.com>
Subject: Re: [PATCH v7 01/10] drm: bridge: Add Samsung DSIM bridge driver
Date: Mon, 17 Oct 2022 13:13:17 +0530 [thread overview]
Message-ID: <CAMty3ZBLQu8YijrSVdt84-J9hoOx8qcRSaGF-FvZVsJEWVaXjQ@mail.gmail.com> (raw)
In-Reply-To: <bad48f67-5fe6-d69c-51b0-bac3fa9d2719@denx.de>
On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut <marex@denx.de> wrote:
>
> On 10/17/22 04:49, Jagan Teki wrote:
> > On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote:
> >>
> >> On 10/5/22 17:13, Jagan Teki wrote:
> >>> Samsung MIPI DSIM controller is common DSI IP that can be used in various
> >>> SoCs like Exynos, i.MX8M Mini/Nano.
> >>>
> >>> In order to access this DSI controller between various platform SoCs,
> >>> the ideal way to incorporate this in the drm stack is via the drm bridge
> >>> driver.
> >>>
> >>> This patch is trying to differentiate platform-specific and bridge driver
> >>> code by maintaining exynos platform glue code in exynos_drm_dsi.c driver
> >>> and common bridge driver code in samsung-dsim.c providing that the new
> >>> platform-specific glue should be supported in the bridge driver, unlike
> >>> exynos platform drm drivers.
> >>>
> >>> - Add samsung_dsim_plat_data for keeping platform-specific attributes like
> >>> host_ops, irq_ops, and hw_type.
> >>>
> >>> - Initialize the plat_data hooks for exynos platform in exynos_drm_dsi.c.
> >>>
> >>> - samsung_dsim_probe is the common probe call across exynos_drm_dsi.c and
> >>> samsung-dsim.c.
> >>>
> >>> - plat_data hooks like host_ops and irq_ops are invoked during the
> >>> respective bridge call chains.
> >>
> >> Maybe the Subject should say "Split ... driver" or "Move ... driver" ,
> >> since it is not adding a new driver here ?
> >
> > Though it is not added a completely new driver, it is adding more
> > infrastructure platform code to be compatible with both Exynos and
> > i.MX8M. This is the prime reason for adding that commit head and
> > explaining the same in the commit body.
>
> Diffstat looks like this:
>
> drivers/gpu/drm/bridge/samsung-dsim.c | 1703 ++++++++++++++++++++++
> drivers/gpu/drm/exynos/Kconfig | 1 +
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 ++---------------------
> include/drm/bridge/samsung-dsim.h | 113 ++
> 7 files changed, 1952 insertions(+), 1653 deletions(-)
>
> Looks to me like most of the code is just moved from existing driver in
> this patch.
Yeah, as I explained (from commit) it is moved, updated, and written
the plat code. How about this head?
"drm: bridge: Add Samsung DSIM bridge (Split from exynos_drm_dsi)"
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-17 7:43 UTC|newest]
Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221005151323eucas1p2c69fc9989b84a9d74d568469ccd81f35@eucas1p2.samsung.com>
2022-10-05 15:12 ` [PATCH v7 00/10] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
2022-10-05 15:12 ` Jagan Teki
2022-10-05 15:12 ` Jagan Teki
2022-10-05 15:13 ` [PATCH v7 01/10] drm: bridge: Add Samsung DSIM bridge driver Jagan Teki
2022-10-15 21:46 ` Marek Vasut
2022-10-15 21:46 ` Marek Vasut
2022-10-15 21:46 ` Marek Vasut
2022-10-17 2:49 ` Jagan Teki
2022-10-17 2:49 ` Jagan Teki
2022-10-17 2:49 ` Jagan Teki
2022-10-17 7:19 ` Marek Vasut
2022-10-17 7:19 ` Marek Vasut
2022-10-17 7:19 ` Marek Vasut
2022-10-17 7:43 ` Jagan Teki [this message]
2022-10-17 7:43 ` Jagan Teki
2022-10-17 7:43 ` Jagan Teki
2022-10-17 8:48 ` Marek Vasut
2022-10-17 8:48 ` Marek Vasut
2022-10-17 8:48 ` Marek Vasut
2022-10-17 9:01 ` Marek Szyprowski
2022-10-17 9:01 ` Marek Szyprowski
2022-10-17 9:01 ` Marek Szyprowski
2022-10-18 3:05 ` Jagan Teki
2022-10-18 3:05 ` Jagan Teki
2022-10-18 3:05 ` Jagan Teki
2022-10-28 12:12 ` Jagan Teki
2022-10-28 12:12 ` Jagan Teki
2022-10-28 12:12 ` Jagan Teki
2022-10-05 15:13 ` [PATCH v7 02/10] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-15 21:48 ` Marek Vasut
2022-10-15 21:48 ` Marek Vasut
2022-10-15 21:48 ` Marek Vasut
2022-10-17 2:52 ` Jagan Teki
2022-10-17 2:52 ` Jagan Teki
2022-10-17 2:52 ` Jagan Teki
2022-10-05 15:13 ` [PATCH v7 03/10] drm: bridge: samsung-dsim: Mark PHY as optional Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-15 21:50 ` Marek Vasut
2022-10-15 21:50 ` Marek Vasut
2022-10-15 21:50 ` Marek Vasut
2022-10-05 15:13 ` [PATCH v7 04/10] drm: bridge: samsung-dsim: Handle proper DSI host initialization Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` [PATCH v7 05/10] drm: bridge: samsung-dsim: Add atomic_check Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-15 21:23 ` Marek Vasut
2022-10-15 21:23 ` Marek Vasut
2022-10-15 21:23 ` Marek Vasut
2022-10-17 3:54 ` Jagan Teki
2022-10-17 3:54 ` Jagan Teki
2022-10-17 3:54 ` Jagan Teki
2022-10-17 7:23 ` Marek Vasut
2022-10-17 7:23 ` Marek Vasut
2022-10-17 7:23 ` Marek Vasut
2022-10-17 7:51 ` Jagan Teki
2022-10-17 7:51 ` Jagan Teki
2022-10-17 7:51 ` Jagan Teki
2022-10-05 15:13 ` [PATCH v7 06/10] drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-15 21:56 ` Marek Vasut
2022-10-15 21:56 ` Marek Vasut
2022-10-15 21:56 ` Marek Vasut
2022-10-05 15:13 ` [PATCH v7 07/10] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-15 22:01 ` Marek Vasut
2022-10-15 22:01 ` Marek Vasut
2022-10-15 22:01 ` Marek Vasut
2022-10-17 3:58 ` Jagan Teki
2022-10-17 3:58 ` Jagan Teki
2022-10-17 3:58 ` Jagan Teki
2022-10-17 7:24 ` Marek Vasut
2022-10-17 7:24 ` Marek Vasut
2022-10-17 7:24 ` Marek Vasut
2022-11-03 7:40 ` Jagan Teki
2022-11-03 7:40 ` Jagan Teki
2022-11-03 7:40 ` Jagan Teki
2022-11-03 16:03 ` Marek Vasut
2022-11-03 16:03 ` Marek Vasut
2022-11-03 16:03 ` Marek Vasut
2022-11-03 9:39 ` Jagan Teki
2022-11-03 9:39 ` Jagan Teki
2022-11-03 9:39 ` Jagan Teki
2022-11-03 16:02 ` Marek Vasut
2022-11-03 16:02 ` Marek Vasut
2022-11-03 16:02 ` Marek Vasut
2022-11-03 17:27 ` Jagan Teki
2022-11-03 17:27 ` Jagan Teki
2022-11-03 17:27 ` Jagan Teki
2022-11-03 18:58 ` Marek Vasut
2022-11-03 18:58 ` Marek Vasut
2022-11-03 18:58 ` Marek Vasut
2022-11-07 17:00 ` Jagan Teki
2022-11-07 17:00 ` Jagan Teki
2022-11-07 17:00 ` Jagan Teki
2022-10-05 15:13 ` [PATCH v7 08/10] drm: bridge: samsung-dsim: Add input_bus_flags Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-15 21:37 ` Marek Vasut
2022-10-15 21:37 ` Marek Vasut
2022-10-15 21:37 ` Marek Vasut
2022-10-05 15:13 ` [PATCH v7 09/10] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-15 22:02 ` Marek Vasut
2022-10-15 22:02 ` Marek Vasut
2022-10-15 22:02 ` Marek Vasut
2022-10-05 15:13 ` [PATCH v7 10/10] drm: bridge: samsung-dsim: Add " Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-05 15:13 ` Jagan Teki
2022-10-15 21:30 ` Marek Vasut
2022-10-15 21:30 ` Marek Vasut
2022-10-15 21:30 ` Marek Vasut
2022-10-05 20:51 ` [PATCH v7 00/10] drm: bridge: Add Samsung MIPI DSIM bridge Marek Szyprowski
2022-10-05 20:51 ` Marek Szyprowski
2022-10-05 20:51 ` Marek Szyprowski
2022-10-06 14:21 ` Jagan Teki
2022-10-06 14:21 ` Jagan Teki
2022-10-06 14:21 ` Jagan Teki
2022-10-06 15:26 ` Tim Harvey
2022-10-06 15:26 ` Tim Harvey
2022-10-06 15:26 ` Tim Harvey
2022-10-19 10:16 ` Marcel Ziswiler
2022-10-19 10:16 ` Marcel Ziswiler
2022-10-19 10:16 ` Marcel Ziswiler
2022-10-20 9:20 ` Robert Foss
2022-10-20 9:20 ` Robert Foss
2022-10-20 9:20 ` Robert Foss
2022-10-24 8:44 ` Alexander Stein
2022-10-24 8:44 ` Alexander Stein
2022-10-24 8:44 ` Alexander Stein
2022-10-28 14:37 ` Sébastien Szymanski
2022-10-28 14:37 ` Sébastien Szymanski
2022-10-28 14:37 ` Sébastien Szymanski
2022-11-07 16:34 ` Frieder Schrempf
2022-11-07 16:34 ` Frieder Schrempf
2022-11-07 16:34 ` Frieder Schrempf
2022-11-10 15:54 ` Fabio Estevam
2022-11-10 15:54 ` Fabio Estevam
2022-11-10 15:54 ` Fabio Estevam
2022-11-10 16:03 ` Jagan Teki
2022-11-10 16:03 ` Jagan Teki
2022-11-10 16:03 ` Jagan Teki
2022-11-10 16:59 ` Marek Vasut
2022-11-10 16:59 ` Marek Vasut
2022-11-10 16:59 ` Marek Vasut
2022-11-10 17:37 ` Jagan Teki
2022-11-10 17:37 ` Jagan Teki
2022-11-10 17:37 ` Jagan Teki
2022-11-10 17:41 ` Marek Vasut
2022-11-10 17:41 ` Marek Vasut
2022-11-10 17:41 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMty3ZBLQu8YijrSVdt84-J9hoOx8qcRSaGF-FvZVsJEWVaXjQ@mail.gmail.com \
--to=jagan@amarulasolutions.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aford173@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=chen.fang@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frieder.schrempf@kontron.de \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=marex@denx.de \
--cc=matteo.lisi@engicam.com \
--cc=michael@amarulasolutions.com \
--cc=narmstrong@linaro.org \
--cc=robert.foss@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=tharvey@gateworks.com \
--cc=tommaso.merciai@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.