From: Jagan Teki <jagan@amarulasolutions.com> To: Kever Yang <kever.yang@rock-chips.com>, Tom Rini <trini@konsulko.com> Cc: "Matwey V . Kornilov" <matwey.kornilov@gmail.com>, U-Boot-Denx <u-boot@lists.denx.de>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org> Subject: Re: [PATCH v3 2/5] Makefile: Rename idbloader.img with u-boot-spl-rockchip.bin Date: Mon, 21 Oct 2019 10:56:39 +0530 [thread overview] Message-ID: <CAMty3ZDZ_P-soW2poo3nJ8PF=3Wxe0RoGzW7B_xDTkZx8UCm8Q@mail.gmail.com> (raw) In-Reply-To: <7e1e42fd-a4e3-4b3c-8d7b-82f3ad7551cd@rock-chips.com> Hi Kever, On Fri, Oct 18, 2019 at 4:26 PM Kever Yang <kever.yang@rock-chips.com> wrote: > > Jagan, > > > On 2019/10/18 上午3:07, Jagan Teki wrote: > > idbloader.img name is specific to rockchip, > > This is specific for rockchip, like rksd, rkspi type in mkimage, since > it's clear for what it stands for, > > I think it can also used in U-Boot. > > > where it usually > > created using rockchip tools. > > > No, idbloader stands for the image with idb header packaged with two > stage loader, eg. TPL+SPL > > or ddr.bin+miniloader.bin, and maybe ddr.bin + SPL, TPL+miniloader.bin, > > not related to rockchip tools, it can also be created with U-Boot > mkimage tool. I understand what idbloader contains, it is like rockchip SPL. but the main concern here is the naming convention used in U-Boot. It would be a standard way of using naming conventions where the final output naming conventions should have u-boot support stages(TPL, SPL, U-Boot) and platform specific name. This way it is less confused what exactly it contains. Moreover most of the platform specific bin ended up using this type of conventions. - u-boot-spl-mtk.bin - Mediatek SPL bin - u-boot-mtk.bin - Mediatek U-Boot bin (would be final image) - u-boot-sunxi-with-spl.bin - Allwinner U-Boot with SPL - u-boot-x86-start16-tpl.bin Similar naming conventions used for tegra, x86 etc. I'm completely aware of what you're trying to abbreviate idbloader.img, but having u-boot-spl-rockchip.bin is more readable and understand than idbloader. > > > Since the image is created as > > per U-Boot generic builds like SPL, better to follow the > > generic U-Boot naming notation like other SoC's following. > > > > Enable idbloader.img with u-boot-spl-rockchip.bin and create > > the same in spl directory since it is SPL file and Makefile.spl > > will clean it by default. > > > > Cc: Kever Yang <kever.yang@rock-chips.com> > > Cc: Matwey V. Kornilov <matwey.kornilov@gmail.com> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index ec55e0f6a4..918b5d53e0 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -887,7 +887,7 @@ ALL-y += u-boot-with-dtb.bin > > endif > > > > ifeq ($(CONFIG_ARCH_ROCKCHIP)$(CONFIG_SPL)$(CONFIG_TPL),yyy) > > -ALL-y += idbloader.img > > +ALL-y += spl/u-boot-spl-rockchip.bin > > > This idbloader including IDB header, TPL, and SPL, I don't think name it > as spl and > > put it in spl directory make any sense. > > I though the origin output file use postfix '.bin' and those image after > pack and can be > > dd to storage directly better to use postfix '.img'. > > About the clean, it will be better to be clean like other '.img' file in > the Makefile. This make sense, I have next version set where it used handle these so carefully. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com> To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v3 2/5] Makefile: Rename idbloader.img with u-boot-spl-rockchip.bin Date: Mon, 21 Oct 2019 10:56:39 +0530 [thread overview] Message-ID: <CAMty3ZDZ_P-soW2poo3nJ8PF=3Wxe0RoGzW7B_xDTkZx8UCm8Q@mail.gmail.com> (raw) In-Reply-To: <7e1e42fd-a4e3-4b3c-8d7b-82f3ad7551cd@rock-chips.com> Hi Kever, On Fri, Oct 18, 2019 at 4:26 PM Kever Yang <kever.yang@rock-chips.com> wrote: > > Jagan, > > > On 2019/10/18 上午3:07, Jagan Teki wrote: > > idbloader.img name is specific to rockchip, > > This is specific for rockchip, like rksd, rkspi type in mkimage, since > it's clear for what it stands for, > > I think it can also used in U-Boot. > > > where it usually > > created using rockchip tools. > > > No, idbloader stands for the image with idb header packaged with two > stage loader, eg. TPL+SPL > > or ddr.bin+miniloader.bin, and maybe ddr.bin + SPL, TPL+miniloader.bin, > > not related to rockchip tools, it can also be created with U-Boot > mkimage tool. I understand what idbloader contains, it is like rockchip SPL. but the main concern here is the naming convention used in U-Boot. It would be a standard way of using naming conventions where the final output naming conventions should have u-boot support stages(TPL, SPL, U-Boot) and platform specific name. This way it is less confused what exactly it contains. Moreover most of the platform specific bin ended up using this type of conventions. - u-boot-spl-mtk.bin - Mediatek SPL bin - u-boot-mtk.bin - Mediatek U-Boot bin (would be final image) - u-boot-sunxi-with-spl.bin - Allwinner U-Boot with SPL - u-boot-x86-start16-tpl.bin Similar naming conventions used for tegra, x86 etc. I'm completely aware of what you're trying to abbreviate idbloader.img, but having u-boot-spl-rockchip.bin is more readable and understand than idbloader. > > > Since the image is created as > > per U-Boot generic builds like SPL, better to follow the > > generic U-Boot naming notation like other SoC's following. > > > > Enable idbloader.img with u-boot-spl-rockchip.bin and create > > the same in spl directory since it is SPL file and Makefile.spl > > will clean it by default. > > > > Cc: Kever Yang <kever.yang@rock-chips.com> > > Cc: Matwey V. Kornilov <matwey.kornilov@gmail.com> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index ec55e0f6a4..918b5d53e0 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -887,7 +887,7 @@ ALL-y += u-boot-with-dtb.bin > > endif > > > > ifeq ($(CONFIG_ARCH_ROCKCHIP)$(CONFIG_SPL)$(CONFIG_TPL),yyy) > > -ALL-y += idbloader.img > > +ALL-y += spl/u-boot-spl-rockchip.bin > > > This idbloader including IDB header, TPL, and SPL, I don't think name it > as spl and > > put it in spl directory make any sense. > > I though the origin output file use postfix '.bin' and those image after > pack and can be > > dd to storage directly better to use postfix '.img'. > > About the clean, it will be better to be clean like other '.img' file in > the Makefile. This make sense, I have next version set where it used handle these so carefully.
next prev parent reply other threads:[~2019-10-21 5:26 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-17 19:07 [PATCH v3 0/5] rockchip: Add Binman support Jagan Teki 2019-10-17 19:07 ` [U-Boot] " Jagan Teki [not found] ` <20191017190710.29985-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-10-17 19:07 ` [PATCH v3 1/5] Makefile: Add rockchip image type Jagan Teki 2019-10-17 19:07 ` [U-Boot] " Jagan Teki 2019-11-10 14:16 ` Kever Yang 2019-11-10 14:16 ` [U-Boot] " Kever Yang 2019-10-17 19:07 ` [PATCH v3 2/5] Makefile: Rename idbloader.img with u-boot-spl-rockchip.bin Jagan Teki 2019-10-17 19:07 ` [U-Boot] " Jagan Teki 2019-10-18 10:56 ` Kever Yang 2019-10-18 10:56 ` [U-Boot] " Kever Yang 2019-10-21 5:26 ` Jagan Teki [this message] 2019-10-21 5:26 ` Jagan Teki 2019-10-21 8:13 ` Mark Kettenis 2019-10-21 8:13 ` [U-Boot] " Mark Kettenis 2019-10-22 10:10 ` Jagan Teki 2019-10-22 10:10 ` [U-Boot] " Jagan Teki 2019-11-15 6:34 ` Kever Yang 2019-11-15 6:34 ` [U-Boot] " Kever Yang 2019-10-17 19:07 ` [PATCH v3 3/5] arm: dts: rk3368: Add rk3368-u-boot.dtsi Jagan Teki 2019-10-17 19:07 ` [U-Boot] " Jagan Teki 2019-10-17 19:07 ` [PATCH v3 4/5] rockchip: Add Binman support Jagan Teki 2019-10-17 19:07 ` [U-Boot] " Jagan Teki [not found] ` <20191017190710.29985-5-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-10-21 8:16 ` Jagan Teki 2019-10-21 8:16 ` [U-Boot] " Jagan Teki 2019-10-17 19:07 ` [PATCH v3 5/5] doc: boards: Add rockchip documentation Jagan Teki 2019-10-17 19:07 ` [U-Boot] " Jagan Teki [not found] ` <20191017190710.29985-6-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-10-18 12:20 ` Robin Murphy 2019-10-18 12:20 ` [U-Boot] " Robin Murphy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMty3ZDZ_P-soW2poo3nJ8PF=3Wxe0RoGzW7B_xDTkZx8UCm8Q@mail.gmail.com' \ --to=jagan@amarulasolutions.com \ --cc=kever.yang@rock-chips.com \ --cc=linux-rockchip@lists.infradead.org \ --cc=matwey.kornilov@gmail.com \ --cc=trini@konsulko.com \ --cc=u-boot@lists.denx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.