Re: [PATCH 1/2] arm64: dts: renesas: r8a77961: Add CAN-FD node

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Subject: Re: [PATCH 1/2] arm64: dts: renesas: r8a77961: Add CAN-FD node
Date: Fri, 1 Apr 2022 14:26:18 +0200	[thread overview]
Message-ID: <CAMuHMdUc_MUXFPmkEzHaTGG5oyJNS2QROpe-RdgTpfRcOstU6Q@mail.gmail.com> (raw)
In-Reply-To: <20220319223306.60782-2-wsa+renesas@sang-engineering.com>

Hi Wolfram,

Thanks for your patch!

On Sun, Mar 20, 2022 at 11:48 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>
> It was forgotten when adding the other CAN nodes, add it now.
>
> Fixes: 92c406ed0a7f ("arm64: dts: renesas: r8a77961: Add CAN nodes")

I don't think it was forgotten, and think this is not really a fix:
CAN and CAN-FD are two different devices, with different drivers.

> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a77961.dtsi | 25 +++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index ac9b587f6fc5..87bb903954ed 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -1222,6 +1222,31 @@ can1: can@e6c38000 {
>                         status = "disabled";
>                 };
>
> +               canfd: can@e66c0000 {
> +                       compatible = "renesas,r8a77961-canfd",

Can you please send a patch to augment the DT bindings?

> +                                    "renesas,rcar-gen3-canfd";

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.19, with the Fixes tag removed.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds