All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	LUU HOAI <hoai.luu.ub@renesas.com>
Subject: Re: [PATCH 2/2] arm64: dts: renesas: r8a77961: Add i2c aliases
Date: Wed, 30 Mar 2022 12:12:44 +0200	[thread overview]
Message-ID: <CAMuHMdVTDZ+_4in0x6vJViw2d-gjWfXSVyA0cV=3AZZ3kXpAEw@mail.gmail.com> (raw)
In-Reply-To: <20220319223306.60782-3-wsa+renesas@sang-engineering.com>

Hi Wolfram,

On Mon, Mar 21, 2022 at 11:00 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> From: LUU HOAI <hoai.luu.ub@renesas.com>
>
> Keep aligned with other Gen3 SoCs and sort the I2C busses.
>
> Signed-off-by: LUU HOAI <hoai.luu.ub@renesas.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Do we really need them?
Aliases are meant to refer to labels on physical ports on boards,
so even if these labels would be present, they do not belong to
.dtsi files.
Unless you have a good reason to keep them, I'd rather remove them
everywhere.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2022-03-30 10:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-19 22:33 [PATCH 0/2] arm64: dts: renesas: r8a77961: improvements from BSP Wolfram Sang
2022-03-19 22:33 ` [PATCH 1/2] arm64: dts: renesas: r8a77961: Add CAN-FD node Wolfram Sang
2022-04-01 12:26   ` Geert Uytterhoeven
2022-04-01 15:23     ` Wolfram Sang
2022-03-19 22:33 ` [PATCH 2/2] arm64: dts: renesas: r8a77961: Add i2c aliases Wolfram Sang
2022-03-30 10:12   ` Geert Uytterhoeven [this message]
2022-04-01 15:25     ` Wolfram Sang
2022-04-01 15:47       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVTDZ+_4in0x6vJViw2d-gjWfXSVyA0cV=3AZZ3kXpAEw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=hoai.luu.ub@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.