From: Geert Uytterhoeven <geert@linux-m68k.org> To: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: linux-kbuild <linux-kbuild@vger.kernel.org>, Linux-Arch <linux-arch@vger.kernel.org>, Ulf Magnusson <ulfalizer@gmail.com>, Herbert Xu <herbert@gondor.apana.org.au>, Wolfram Sang <wsa+renesas@sang-engineering.com>, Will Deacon <will.deacon@arm.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, David Howells <dhowells@redhat.com>, Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, "David S. Miller" <davem@davemloft.net>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 21/27] treewide: surround file paths in Kconfig files with double quotes Date: Tue, 11 Dec 2018 12:25:59 +0100 [thread overview] Message-ID: <CAMuHMdUcyzoMkiu-XaD5hM3uxhh+G3wMWWkVrFRNBkv5GbDGmA@mail.gmail.com> (raw) In-Reply-To: <1544526070-16690-22-git-send-email-yamada.masahiro@socionext.com> On Tue, Dec 11, 2018 at 12:03 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > The Kconfig lexer supports special characters such as '.' and '/' in > the parameter context. In my understanding, the reason is just to > support bare file paths in the source statement. > > I do not see a good reason to complicate Kconfig for the room of > ambiguity. > > The majority of code already surround file paths with double quotes, > and it makes sense since the included file paths are constant string > literals. > > Make it treewide consistent now. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > arch/m68k/Kconfig | 6 +++--- Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Linux-Arch <linux-arch@vger.kernel.org>, Ulf Magnusson <ulfalizer@gmail.com>, Herbert Xu <herbert@gondor.apana.org.au>, linux-kbuild <linux-kbuild@vger.kernel.org>, Will Deacon <will.deacon@arm.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, David Howells <dhowells@redhat.com>, Wolfram Sang <wsa+renesas@sang-engineering.com>, Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, "David S. Miller" <davem@davemloft.net>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 21/27] treewide: surround file paths in Kconfig files with double quotes Date: Tue, 11 Dec 2018 12:25:59 +0100 [thread overview] Message-ID: <CAMuHMdUcyzoMkiu-XaD5hM3uxhh+G3wMWWkVrFRNBkv5GbDGmA@mail.gmail.com> (raw) In-Reply-To: <1544526070-16690-22-git-send-email-yamada.masahiro@socionext.com> On Tue, Dec 11, 2018 at 12:03 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > The Kconfig lexer supports special characters such as '.' and '/' in > the parameter context. In my understanding, the reason is just to > support bare file paths in the source statement. > > I do not see a good reason to complicate Kconfig for the room of > ambiguity. > > The majority of code already surround file paths with double quotes, > and it makes sense since the included file paths are constant string > literals. > > Make it treewide consistent now. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > arch/m68k/Kconfig | 6 +++--- Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-11 11:26 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-11 11:00 [PATCH 00/27] kconfig: remove all reduce/shift conflicts, refactor lexer, fix various issues Masahiro Yamada 2018-12-11 11:00 ` Masahiro Yamada 2018-12-11 11:00 ` Masahiro Yamada 2018-12-11 11:00 ` [PATCH 01/27] kconfig: fix file name and line number of warn_ignored_character() Masahiro Yamada 2018-12-11 11:00 ` [PATCH 02/27] kconfig: fix memory leak when EOF is encountered in quotation Masahiro Yamada 2018-12-11 11:00 ` [PATCH 03/27] kconfig: require T_EOL to reduce visible statement Masahiro Yamada 2018-12-11 11:00 ` [PATCH 04/27] kconfig: remove unneeded pattern matching to whitespaces Masahiro Yamada 2018-12-11 11:00 ` [PATCH 05/27] kconfig: refactor pattern matching in STRING state Masahiro Yamada 2018-12-11 11:00 ` [PATCH 06/27] kconfig: fix ambiguous grammar in terms of new lines Masahiro Yamada 2018-12-11 11:00 ` [PATCH 07/27] kconfig: clean up EOF handling in the lexer Masahiro Yamada 2018-12-11 11:00 ` [PATCH 08/27] kconfig: warn no new line at end of file Masahiro Yamada 2018-12-11 11:00 ` [PATCH 09/27] kconfig: remove grammatically ambiguous "unexpected option" diagnostic Masahiro Yamada 2018-12-11 11:00 ` [PATCH 10/27] kconfig: remove grammatically ambiguous option_error Masahiro Yamada 2018-12-11 11:00 ` [PATCH 11/27] kconfig: remove redundant if_block rule Masahiro Yamada 2018-12-11 11:00 ` [PATCH 12/27] kconfig: remove redundant menu_block rule Masahiro Yamada 2018-12-11 11:00 ` [PATCH 13/27] kconfig: loosen the order of "visible" and "depends on" in menu entry Masahiro Yamada 2018-12-11 11:00 ` [PATCH 14/27] kconfig: rename depends_list to comment_option_list Masahiro Yamada 2018-12-11 11:00 ` [PATCH 15/27] kconfig: remove redundant token defines Masahiro Yamada 2018-12-11 11:00 ` [PATCH 16/27] kconfig: use distinct tokens for type and default properties Masahiro Yamada 2018-12-11 11:01 ` [PATCH 17/27] kconfig: refactor scanning and parsing "option" properties Masahiro Yamada 2018-12-11 11:01 ` [PATCH 18/27] kconfig: use specific tokens instead of T_ASSIGN for assignments Masahiro Yamada 2018-12-11 11:01 ` [PATCH 19/27] kconfig: use T_WORD instead of T_VARIABLE for variables Masahiro Yamada 2018-12-11 11:01 ` [PATCH 20/27] microblaze: surround string default in Kconfig with double quotes Masahiro Yamada 2018-12-12 8:28 ` Michal Simek 2018-12-11 11:01 ` [PATCH 21/27] treewide: surround file paths in Kconfig files " Masahiro Yamada 2018-12-11 11:01 ` Masahiro Yamada 2018-12-11 11:01 ` Masahiro Yamada 2018-12-11 11:19 ` Wolfram Sang 2018-12-11 11:19 ` Wolfram Sang 2018-12-11 11:25 ` Geert Uytterhoeven [this message] 2018-12-11 11:25 ` Geert Uytterhoeven 2018-12-11 14:43 ` Ingo Molnar 2018-12-11 14:43 ` Ingo Molnar 2018-12-11 11:01 ` [PATCH 22/27] kconfig: ban the use of '.' and '/' in unquoted words Masahiro Yamada 2018-12-11 11:01 ` [PATCH 23/27] kconfig: refactor end token rules Masahiro Yamada 2018-12-11 11:01 ` [PATCH 24/27] kconfig: stop associating kconf_id with yylval Masahiro Yamada 2018-12-11 11:01 ` [PATCH 25/27] kconfig: switch to ASSIGN_VAL state in the second lexer Masahiro Yamada 2018-12-11 11:01 ` [PATCH 26/27] kconfig: update current_pos " Masahiro Yamada 2018-12-11 11:01 ` [PATCH 27/27] kconfig: remove keyword lookup table entirely Masahiro Yamada 2018-12-19 14:59 ` [PATCH 00/27] kconfig: remove all reduce/shift conflicts, refactor lexer, fix various issues Masahiro Yamada 2018-12-19 14:59 ` Masahiro Yamada
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdUcyzoMkiu-XaD5hM3uxhh+G3wMWWkVrFRNBkv5GbDGmA@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=davem@davemloft.net \ --cc=dhowells@redhat.com \ --cc=herbert@gondor.apana.org.au \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=tglx@linutronix.de \ --cc=ulfalizer@gmail.com \ --cc=will.deacon@arm.com \ --cc=wsa+renesas@sang-engineering.com \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.