Re: [PATCH 1/9] sh: defconfig: migor: Update defconfig

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] sh: defconfig: migor: Update defconfig
Date: Wed, 04 Jul 2018 11:54:45 +0000	[thread overview]
Message-ID: <CAMuHMdUtUEUsJ=fCmu_e6BtM=wrxVTMVe-QEp-rWK=NPVmTeZQ@mail.gmail.com> (raw)
In-Reply-To: <20180704115208.GE4463@w540>

Hi Jacopo,

On Wed, Jul 4, 2018 at 1:52 PM jacopo mondi <jacopo@jmondi.org> wrote:
> On Wed, Jul 04, 2018 at 01:08:59PM +0200, Geert Uytterhoeven wrote:
> > On Wed, Jul 4, 2018 at 12:23 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> > > Update defconfig to Linux v4.18-rc2.
> > >
> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> >
> > Thanks for your patch!
> >
> > > ---
> > > The updated config file generated by:
> > >
> > > make ARCH=sh migor_defconfig
> > > make ARCH=sh menuconfig
> >
> > Which changes have you made here?
>
> mmm, I haven't made any explicit change, I just used the defconfig for
> each board, run 'make menuconfig; make savedefconfig' that for my
> understanding removes the obsolated options and defaults the newly
> introduced ones.

IC. In that case "make migor_defconfig; make savedefconfig" is sufficient,
and there was no need to run menuconfig ;-)

> The only changes I have introduced are the enablement of the new CEU
> driver and the associated sensor/video decoder drivers.

OK, that's done in a subsequent patch.

> > It's a good idea to always list the net changes induced by your defconfig patch.
> >
> > > make ARCH=sh savedefconfig
> > > cp defconfig arch/sh/configs/migor_defconfig

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds