Re: [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
	David Airlie <airlied@linux.ie>
Subject: Re: [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU
Date: Fri, 6 Mar 2020 09:00:12 +0100	[thread overview]
Message-ID: <CAMuHMdV8pKP3_6sO+BSyqde9J_qkac7+nc8RnTZwOuphqAnTSQ@mail.gmail.com> (raw)
In-Reply-To: <4b50cc9f-1434-b78a-d56a-fadfd030f002@infradead.org>

Hi Randy,

Thanks for your patch!

On Fri, Mar 6, 2020 at 4:18 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
> symbols do not depend on DRM_RCAR_DU, the menu presentation is
> broken for these and following non-R-Car Kconfig symbols.
>
> Is it safe/appropriate to make all of these symbols depend on
> DRM_RCAR_DU?  It make the kconfig menu presentation much cleaner.

I think it is.
But I'd use a big "#if DRM_RCAR_DU" block instead of individual dependencies.

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> --- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig
> +++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig
> @@ -24,6 +24,7 @@ config DRM_RCAR_CMM
>  config DRM_RCAR_DW_HDMI
>         tristate "R-Car DU Gen3 HDMI Encoder Support"
>         depends on DRM && OF
> +       depends on DRM_RCAR_DU
>         select DRM_DW_HDMI
>         help
>           Enable support for R-Car Gen3 internal HDMI encoder.
> @@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI
>  config DRM_RCAR_LVDS
>         tristate "R-Car DU LVDS Encoder Support"
>         depends on DRM && DRM_BRIDGE && OF
> +       depends on DRM_RCAR_DU
>         select DRM_PANEL
>         select OF_FLATTREE
>         select OF_OVERLAY
> @@ -47,4 +49,5 @@ config DRM_RCAR_VSP
>
>  config DRM_RCAR_WRITEBACK
>         bool
> +       depends on DRM_RCAR_DU
>         default y if ARM64

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds