Re: [PATCH 1/4] arm64: dts: renesas: rzg2l-smarc: Add common dtsi file

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>
Subject: Re: [PATCH 1/4] arm64: dts: renesas: rzg2l-smarc: Add common dtsi file
Date: Tue, 1 Feb 2022 17:46:52 +0100	[thread overview]
Message-ID: <CAMuHMdVJD8FFy2aXRpsfvhHL4zTGG8nyGp==q2VzT5k-eNh2pw@mail.gmail.com> (raw)
In-Reply-To: <20220119095245.5611-1-biju.das.jz@bp.renesas.com>

Hi Biju, Prabhakar,

On Wed, Jan 19, 2022 at 10:52 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> RZ/G2L and RZ/G2LC SoC use the same carrier board, but the SoM is
> different.
>
> Different pin mapping is possible on SoM. For eg:- RZ/G2L SMARC EVK
> uses SCIF2, whereas RZ/G2LC uses SCIF1 for the serial interface available
> on PMOD1.
>
> This patch adds support for handling the pin mapping differences by moving
> definitions common to RZ/G2L and RZ/G2LC to a common dtsi file.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a07g044c2-smarc.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044c2-smarc.dts

> @@ -66,11 +65,6 @@
>         status = "disabled";
>  };
>
> -&scif2 {
> -       /delete-property/ pinctrl-0;

In the meantime, one more line for pinctrl-names should be deleted.

> -       status = "disabled";
> -};
> -
>  &spi1 {
>         /delete-property/ pinctrl-0;
>         status = "disabled";

The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>  /*
> - * Device Tree Source for the RZ/G2L SMARC EVK common parts
> + * Device Tree Source for the RZ/G2L SMARC EVK parts
>   *
>   * Copyright (C) 2021 Renesas Electronics Corp.
>   */

Note that the above conflicts with "[PATCH v2 11/12] arm64: dts:
renesas: Add initial device tree for RZ/V2L SMARC EVK"[1], which
I had queued in renesas-devel, but dropped again due to a missing
dependency on the clock bindings include file.  In the meantime,
the updated clock bindings include file is ready.

So, which one has the highest priority: this series, or RZ/V2L?

[1] https://lore.kernel.org/all/20220110134659.30424-12-prabhakar.mahadev-lad.rj@bp.renesas.com/

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds