From: Geert Uytterhoeven <geert@linux-m68k.org> To: Bjorn Helgaas <helgaas@kernel.org> Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Rob Herring" <robh@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com> Subject: Re: [PATCH 2/2] PCI: Drop controller CONFIG_OF dependencies Date: Tue, 15 Nov 2022 16:56:10 +0100 [thread overview] Message-ID: <CAMuHMdVnJZGqwnC0fZTwyb1GT5Nu+4K9LND4CXU96cvYG+qEgg@mail.gmail.com> (raw) In-Reply-To: <20221025191339.667614-3-helgaas@kernel.org> Hi Bjorn, On Tue, Oct 25, 2022 at 9:16 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > Many drivers depend on OF interfaces, so they won't be functional if > CONFIG_OF is not set. But OF provides stub functions in that case, so drop > the OF dependencies so we can at least compile-test the drivers. > > This means we can compile-test the following drivers even without CONFIG_OF > enabled (many still require either CONFIG_COMPILE_TEST or the relevant > arch): > > aardvark > al > apple > brcmstb > cadence-host > cadence-platform-host > cadence-ep > dra7xx-host > dra7xx-ep > dw-rockchip > ftpci100 > hisi > intel-gw > ixp4xx > j721e-host > j721e-ep > kirin > layerscape-host > layerscape-ep > mediatek > microchip-host > mobiveil > mvebu > qcom-host > qcom-ep > rockchip-host > rockchip-ep > rockchip-dwc > pci-host-generic > uniphier-host > uniphier-ep > v3-semi > xilinx > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Thanks for your patch, which is now commit 51dfb612ab3becf9 ("PCI: Drop controller CONFIG_OF dependencies") in pci/next. > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -8,7 +8,6 @@ config PCI_MVEBU > depends on ARCH_MVEBU || ARCH_DOVE || COMPILE_TEST > depends on MVEBU_MBUS > depends on ARM > - depends on OF This is exactly why we have the COMPILE_TEST symbol. There is no point in bothering all users who configure kernels with questions about drivers that won't function anyway due to missing dependencies, unless the user explicitly wants to do compile-testing. So all of these should become: depends on OF || COMPILE_TEST > select PCI_BRIDGE_EMUL > help > Add support for Marvell EBU PCIe controller. This PCIe controller > @@ -98,7 +94,6 @@ config PCI_HOST_GENERIC > > config PCIE_XILINX > bool "Xilinx AXI PCIe host bridge support" > - depends on OF || COMPILE_TEST This one was fine. > depends on PCI_MSI_IRQ_DOMAIN > help > Say 'Y' here if you want kernel to support the Xilinx AXI PCIe Thanks in advance for reverting or fixing! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Bjorn Helgaas <helgaas@kernel.org> Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>, "Rob Herring" <robh@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com> Subject: Re: [PATCH 2/2] PCI: Drop controller CONFIG_OF dependencies Date: Tue, 15 Nov 2022 16:56:10 +0100 [thread overview] Message-ID: <CAMuHMdVnJZGqwnC0fZTwyb1GT5Nu+4K9LND4CXU96cvYG+qEgg@mail.gmail.com> (raw) In-Reply-To: <20221025191339.667614-3-helgaas@kernel.org> Hi Bjorn, On Tue, Oct 25, 2022 at 9:16 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > Many drivers depend on OF interfaces, so they won't be functional if > CONFIG_OF is not set. But OF provides stub functions in that case, so drop > the OF dependencies so we can at least compile-test the drivers. > > This means we can compile-test the following drivers even without CONFIG_OF > enabled (many still require either CONFIG_COMPILE_TEST or the relevant > arch): > > aardvark > al > apple > brcmstb > cadence-host > cadence-platform-host > cadence-ep > dra7xx-host > dra7xx-ep > dw-rockchip > ftpci100 > hisi > intel-gw > ixp4xx > j721e-host > j721e-ep > kirin > layerscape-host > layerscape-ep > mediatek > microchip-host > mobiveil > mvebu > qcom-host > qcom-ep > rockchip-host > rockchip-ep > rockchip-dwc > pci-host-generic > uniphier-host > uniphier-ep > v3-semi > xilinx > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Thanks for your patch, which is now commit 51dfb612ab3becf9 ("PCI: Drop controller CONFIG_OF dependencies") in pci/next. > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -8,7 +8,6 @@ config PCI_MVEBU > depends on ARCH_MVEBU || ARCH_DOVE || COMPILE_TEST > depends on MVEBU_MBUS > depends on ARM > - depends on OF This is exactly why we have the COMPILE_TEST symbol. There is no point in bothering all users who configure kernels with questions about drivers that won't function anyway due to missing dependencies, unless the user explicitly wants to do compile-testing. So all of these should become: depends on OF || COMPILE_TEST > select PCI_BRIDGE_EMUL > help > Add support for Marvell EBU PCIe controller. This PCIe controller > @@ -98,7 +94,6 @@ config PCI_HOST_GENERIC > > config PCIE_XILINX > bool "Xilinx AXI PCIe host bridge support" > - depends on OF || COMPILE_TEST This one was fine. > depends on PCI_MSI_IRQ_DOMAIN > help > Say 'Y' here if you want kernel to support the Xilinx AXI PCIe Thanks in advance for reverting or fixing! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-15 15:56 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-25 19:13 [PATCH 0/2] PCI: Drop controller CONFIG_OF dependencies Bjorn Helgaas 2022-10-25 19:13 ` Bjorn Helgaas 2022-10-25 19:13 ` [PATCH 1/2] PCI: Drop of_match_ptr() to avoid unused variables Bjorn Helgaas 2022-10-25 19:13 ` Bjorn Helgaas 2022-10-25 19:13 ` [PATCH 2/2] PCI: Drop controller CONFIG_OF dependencies Bjorn Helgaas 2022-10-25 19:13 ` Bjorn Helgaas 2022-11-15 15:56 ` Geert Uytterhoeven [this message] 2022-11-15 15:56 ` Geert Uytterhoeven 2022-11-15 18:07 ` Bjorn Helgaas 2022-11-15 18:07 ` Bjorn Helgaas 2022-11-15 19:27 ` Geert Uytterhoeven 2022-11-15 19:27 ` Geert Uytterhoeven 2022-11-15 19:31 ` Pali Rohár 2022-11-15 19:31 ` Pali Rohár 2022-11-15 20:53 ` Bjorn Helgaas 2022-11-15 20:53 ` Bjorn Helgaas 2022-11-15 21:04 ` Pali Rohár 2022-11-15 21:04 ` Pali Rohár 2022-11-10 21:03 ` [PATCH 0/2] " Bjorn Helgaas 2022-11-10 21:03 ` Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdVnJZGqwnC0fZTwyb1GT5Nu+4K9LND4CXU96cvYG+qEgg@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=bhelgaas@google.com \ --cc=helgaas@kernel.org \ --cc=kw@linux.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lpieralisi@kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.