From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Greg Ungerer <gerg@linux-m68k.org>,
iommu@lists.linux.dev, Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Conor Dooley <conor@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-m68k@lists.linux-m68k.org, netdev@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
Jim Quinlan <james.quinlan@broadcom.com>
Subject: Re: [PATCH 09/12] m68k: use the coherent DMA code for coldfire without data cache
Date: Tue, 17 Oct 2023 10:40:32 +0200 [thread overview]
Message-ID: <CAMuHMdVq0ihLthVQF-2v4_E=m7jdOZty8b69eizJyWoU+0CFCw@mail.gmail.com> (raw)
In-Reply-To: <20231016054755.915155-10-hch@lst.de>
On Mon, Oct 16, 2023 at 7:48 AM Christoph Hellwig <hch@lst.de> wrote:
> Coldfire cores configured without a data cache are DMA coherent and
> should thus simply use the simple coherent version of dma-direct.
>
> Introduce a new COLDFIRE_COHERENT_DMA Kconfig symbol as a convenient
> short hand for such configurations, and a M68K_NONCOHERENT_DMA symbol
> for all cases where we need to build non-coherent DMA infrastructure
> to simplify the Kconfig and code conditionals.
>
> Not building the non-coherent DMA code slightly reduces the code
> size for such configurations.
>
> Numers for m5249evb_defconfig below:
>
> text data bss dec hex filename
> 2896158 401052 65392 3362602 334f2a vmlinux.before
> 2895166 400988 65392 3361546 334b0a vmlinux.after
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
The m68kclassic-with-MMU parts look fine to me, so
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
I'll defer to Greg for the nommu and Coldfire parts...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Greg Ungerer <gerg@linux-m68k.org>,
iommu@lists.linux.dev, Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Conor Dooley <conor@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-m68k@lists.linux-m68k.org, netdev@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
Jim Quinlan <james.quinlan@broadcom.com>
Subject: Re: [PATCH 09/12] m68k: use the coherent DMA code for coldfire without data cache
Date: Tue, 17 Oct 2023 10:40:32 +0200 [thread overview]
Message-ID: <CAMuHMdVq0ihLthVQF-2v4_E=m7jdOZty8b69eizJyWoU+0CFCw@mail.gmail.com> (raw)
In-Reply-To: <20231016054755.915155-10-hch@lst.de>
On Mon, Oct 16, 2023 at 7:48 AM Christoph Hellwig <hch@lst.de> wrote:
> Coldfire cores configured without a data cache are DMA coherent and
> should thus simply use the simple coherent version of dma-direct.
>
> Introduce a new COLDFIRE_COHERENT_DMA Kconfig symbol as a convenient
> short hand for such configurations, and a M68K_NONCOHERENT_DMA symbol
> for all cases where we need to build non-coherent DMA infrastructure
> to simplify the Kconfig and code conditionals.
>
> Not building the non-coherent DMA code slightly reduces the code
> size for such configurations.
>
> Numers for m5249evb_defconfig below:
>
> text data bss dec hex filename
> 2896158 401052 65392 3362602 334f2a vmlinux.before
> 2895166 400988 65392 3361546 334b0a vmlinux.after
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
The m68kclassic-with-MMU parts look fine to me, so
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
I'll defer to Greg for the nommu and Coldfire parts...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-10-17 8:40 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 5:47 fix the non-coherent coldfire dma_alloc_coherent v2 Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 5:47 ` [PATCH 01/12] riscv: RISCV_NONSTANDARD_CACHE_OPS shouldn't depend on RISCV_DMA_NONCOHERENT Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 12:49 ` Conor Dooley
2023-10-16 12:49 ` Conor Dooley
2023-10-16 13:17 ` Christoph Hellwig
2023-10-16 13:17 ` Christoph Hellwig
2023-10-16 17:16 ` Conor Dooley
2023-10-16 17:16 ` Conor Dooley
2023-10-16 5:47 ` [PATCH 02/12] riscv: only select DMA_DIRECT_REMAP from RISCV_ISA_ZICBOM Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 11:18 ` Robin Murphy
2023-10-16 11:18 ` Robin Murphy
2023-10-16 12:55 ` Conor Dooley
2023-10-16 12:55 ` Conor Dooley
2023-10-16 15:39 ` Lad, Prabhakar
2023-10-16 15:39 ` Lad, Prabhakar
2023-10-16 5:47 ` [PATCH 03/12] soc: renesas: ARCH_R9A07G043 depends on !RISCV_ISA_ZICBOM Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 12:53 ` Conor Dooley
2023-10-16 12:53 ` Conor Dooley
2023-10-16 15:40 ` Lad, Prabhakar
2023-10-16 15:40 ` Lad, Prabhakar
2023-10-17 7:59 ` Geert Uytterhoeven
2023-10-17 7:59 ` Geert Uytterhoeven
2023-10-16 5:47 ` [PATCH 04/12] soc: renesas: select RISCV_DMA_NONCOHERENT from ARCH_R9A07G043 Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 12:52 ` Conor Dooley
2023-10-16 12:52 ` Conor Dooley
2023-10-16 13:17 ` Christoph Hellwig
2023-10-16 13:17 ` Christoph Hellwig
2023-10-17 10:44 ` Geert Uytterhoeven
2023-10-17 10:44 ` Geert Uytterhoeven
2023-10-17 12:46 ` Christoph Hellwig
2023-10-17 12:46 ` Christoph Hellwig
2023-10-17 13:12 ` Geert Uytterhoeven
2023-10-17 13:12 ` Geert Uytterhoeven
2023-10-16 15:42 ` Lad, Prabhakar
2023-10-16 15:42 ` Lad, Prabhakar
2023-10-17 8:20 ` Geert Uytterhoeven
2023-10-17 8:20 ` Geert Uytterhoeven
2023-10-16 5:47 ` [PATCH 05/12] dma-direct: add depdenencies to CONFIG_DMA_GLOBAL_POOL Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 11:18 ` Robin Murphy
2023-10-16 11:18 ` Robin Murphy
2023-10-16 15:44 ` Lad, Prabhakar
2023-10-16 15:44 ` Lad, Prabhakar
2023-10-16 5:47 ` [PATCH 06/12] dma-direct: add a CONFIG_ARCH_DMA_ALLOC symbol Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 11:33 ` Robin Murphy
2023-10-16 11:33 ` Robin Murphy
2023-10-16 5:47 ` [PATCH 07/12] dma-direct: simplify the use atomic pool logic in dma_direct_alloc Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 11:58 ` Robin Murphy
2023-10-16 11:58 ` Robin Murphy
2023-10-16 5:47 ` [PATCH 08/12] dma-direct: warn when coherent allocations aren't supported Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 11:59 ` Robin Murphy
2023-10-16 11:59 ` Robin Murphy
2023-10-16 5:47 ` [PATCH 09/12] m68k: use the coherent DMA code for coldfire without data cache Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-17 8:40 ` Geert Uytterhoeven [this message]
2023-10-17 8:40 ` Geert Uytterhoeven
2023-10-19 12:50 ` Greg Ungerer
2023-10-19 12:50 ` Greg Ungerer
2023-10-16 5:47 ` [PATCH 10/12] net: fec: use dma_alloc_noncoherent for data cache enabled coldfire Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-17 8:43 ` Geert Uytterhoeven
2023-10-17 8:43 ` Geert Uytterhoeven
2023-10-16 5:47 ` [PATCH 11/12] m68k: don't provide arch_dma_alloc for nommu/coldfire Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-16 5:47 ` [PATCH 12/12] m68k: remove unused includes from dma.c Christoph Hellwig
2023-10-16 5:47 ` Christoph Hellwig
2023-10-17 8:48 ` Geert Uytterhoeven
2023-10-17 8:48 ` Geert Uytterhoeven
2023-10-19 13:09 ` fix the non-coherent coldfire dma_alloc_coherent v2 Greg Ungerer
2023-10-19 13:09 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVq0ihLthVQF-2v4_E=m7jdOZty8b69eizJyWoU+0CFCw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=conor@kernel.org \
--cc=gerg@linux-m68k.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=james.quinlan@broadcom.com \
--cc=linux-imx@nxp.com \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robin.murphy@arm.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.