Re: [PATCH 2/2] watchdog: rzg2l_wdt: Add rzv2m compatible string

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 2/2] watchdog: rzg2l_wdt: Add rzv2m compatible string
Date: Thu, 9 Jun 2022 12:11:23 +0200	[thread overview]
Message-ID: <CAMuHMdVyeB+2Sx072igo1uFmAgYoJWABSX2Ks851=tzNUrKzEw@mail.gmail.com> (raw)
In-Reply-To: <20220607135619.174110-3-phil.edworthy@renesas.com>

Hi Phil,

Thanks for your patch!

On Tue, Jun 7, 2022 at 3:59 PM Phil Edworthy <phil.edworthy@renesas.com> wrote:
> The WDT on RZ/V2M devices is basically the same as RZ/G2L, with the
> exception that the RZ/V2M has a single combined interrupt, whereas the
> RZ/G2L has time out and error interrupts.

... and that the RZ/V2M watchdog does not have the parity error
handling.

> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

> --- a/drivers/watchdog/rzg2l_wdt.c
> +++ b/drivers/watchdog/rzg2l_wdt.c
> @@ -256,6 +256,7 @@ static int rzg2l_wdt_probe(struct platform_device *pdev)
>
>  static const struct of_device_id rzg2l_wdt_ids[] = {
>         { .compatible = "renesas,rzg2l-wdt", },
> +       { .compatible = "renesas,rzv2m-wdt", },

Hence this is not sufficient, as you need to prevent writing to the
parity registers on RZ/V2M.

>         { /* sentinel */ }
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds