RE: [PATCH 1/2] dt-bindings: watchdog: renesas,wdt: Add r9a09g011 (RZ/V2M) support

From: Phil Edworthy <phil.edworthy@renesas.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	Biju Das <biju.das.jz@bp.renesas.com>
Subject: RE: [PATCH 1/2] dt-bindings: watchdog: renesas,wdt: Add r9a09g011 (RZ/V2M) support
Date: Fri, 10 Jun 2022 14:41:50 +0000	[thread overview]
Message-ID: <TYYPR01MB7086617456CBDB2E596E82CEF5A69@TYYPR01MB7086.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <TYYPR01MB7086EFE64F1DF8C6141E8719F5A69@TYYPR01MB7086.jpnprd01.prod.outlook.com>

Hi Krzysztof,

On 10 June 2022 15:38 Phil Edworthy wrote:
> On 08 June 2022 11:52 Krzysztof Kozlowski wrote:
> > On 07/06/2022 15:56, Phil Edworthy wrote:
> > > Add the documentation for the r9a09g011 SoC, but in doing so also
> > > reorganise the doc to make it easier to read.
> > > Additionally, make the binding require an interrupt to be specified.
> > > Whilst the driver does not need an interrupt, all of the SoCs that use
> > > this binding actually provide one.
> > >
> > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > >  .../bindings/watchdog/renesas,wdt.yaml        | 63 ++++++++++++------
> -
> > >  1 file changed, 42 insertions(+), 21 deletions(-)
> > >
> > > diff --git
> a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> > b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> > > index a8d7dde5271b..6473734921e3 100644
> > > --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> > > +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> > > @@ -31,6 +31,11 @@ properties:
> > >                - renesas,r9a07g054-wdt    # RZ/V2L
> > >            - const: renesas,rzg2l-wdt
> > >
> > > +      - items:
> > > +          - enum:
> > > +              - renesas,r9a09g011-wdt    # RZ/V2M
> > > +          - const: renesas,rzv2m-wdt     # RZ/V2M
> > > +
> > >        - items:
> > >            - enum:
> > >                - renesas,r8a7742-wdt      # RZ/G1H
> > > @@ -70,13 +75,27 @@ properties:
> > >    reg:
> > >      maxItems: 1
> > >
> > > -  interrupts: true
> > > +  interrupts:
> > > +    minItems: 1
> > > +    items:
> > > +      - description: Timeout
> > > +      - description: Parity error
> > >
> > > -  interrupt-names: true
> > > +  interrupt-names:
> >
> > This also needs minItems
> I left minItems off for interrupt-names and clock-names on the basis that
> they are only needed if you have more than one interrupt or clock.
> 
> After adding the lines you suggested (minItems: 1), I find that
> 'make dtbs_check' passes even if there are no interrupt-names or
> clock-names specified. Is this expected?
> 
> minItems: 0 makes more sense to me, but it is required to be greater than
> or equal 1

Immediately after sending this I realised that minItems: 1 is correct as
interrupt-names and clock-names are _not_ in required. So when they are
specified, the minimum is 1.

Sorry for the noise.
Phil