Re: [PATCH v18 5/8] hwmon: sy7636a: Add temperature driver for sy7636a

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	linux-hwmon@vger.kernel.org,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, NXP Linux Team <linux-imx@nxp.com>,
	Zhang Rui <rui.zhang@intel.com>, Amit Kucheria <amitk@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Andreas Kemnade <andreas@kemnade.info>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v18 5/8] hwmon: sy7636a: Add temperature driver for sy7636a
Date: Mon, 21 Mar 2022 09:02:57 +0100	[thread overview]
Message-ID: <CAMuHMdWF5z7oYpsBybeAGRA2jWToZD=7wnvtiULg9irQ=rbQSQ@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKNtE8=Jna78+L2a8BwsgM+LZVPi4ppg8Z0RGJ-21RqPtw@mail.gmail.com>

Hi Alistair,

On Mon, Mar 21, 2022 at 8:35 AM Alistair Francis <alistair23@gmail.com> wrote:
> On Tue, Mar 8, 2022 at 9:21 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Mon, Jan 24, 2022 at 1:25 PM Alistair Francis <alistair@alistair23.me> wrote:
> > > This is a multi-function device to interface with the sy7636a
> > > EPD PMIC chip from Silergy.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > Acked-by: Guenter Roeck <linux@roeck-us.net>
> >
> > Thanks for your patch, which is now commit de34a40532507814 ("hwmon:
> > sy7636a: Add temperature driver for sy7636a") in mfd/for-mfd-next.
> >
> > > --- a/drivers/hwmon/Kconfig
> > > +++ b/drivers/hwmon/Kconfig
> > > @@ -1672,6 +1672,15 @@ config SENSORS_SIS5595
> > >           This driver can also be built as a module. If so, the module
> > >           will be called sis5595.
> > >
> > > +config SENSORS_SY7636A
> > > +       tristate "Silergy SY7636A"
> > > +       help
> > > +         If you say yes here you get support for the thermistor readout of
> > > +         the Silergy SY7636A PMIC.
> >
> > As this is an i2c mfd device, you do need a dependency on MFD and I2C,
> > or some other symbol, unless compile-testing?
>
> It doesn't depend on either to build though. It can be built independently.

That is true.

But do you think all users configuring their kernel should be asked
about all (thousands) of config symbols for drivers that can be built,
but won't work or are irrelevant otherwise?

Please read
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.rst#n541

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds