From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tomasz Figa <tfiga@chromium.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
Caesar Wang <wxt@rock-chips.com>,
Elaine Zhang <zhangqing@rock-chips.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] soc: rockchip: power-domain: remove PM clocks
Date: Wed, 28 Feb 2018 13:17:39 +0100 [thread overview]
Message-ID: <CAMuHMdWLL9CxmxSLsqs1QX0dDHVhp4NrW4Me2EZaZE_bJ330bA@mail.gmail.com> (raw)
In-Reply-To: <20180228111113.13639-1-jeffy.chen@rock-chips.com>
Hi Jeffy,
On Wed, Feb 28, 2018 at 12:11 PM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
> Currently we are adding all of the attached devices' clocks as pm clocks
> and enable them when powering on the power domain.
>
> This seems unnecessary, because those clocks are already controlled in
> the devices' drivers with better error handling.
>
> Tested on my chromebook minnie(rk3288) and chromebook kevin(rk3399).
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Thanks for your patch!
Just wondering: so you prefer to handle the clocks explicitly in all drivers,
instead of delegating this task to Runtime PM?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: rockchip: power-domain: remove PM clocks
Date: Wed, 28 Feb 2018 13:17:39 +0100 [thread overview]
Message-ID: <CAMuHMdWLL9CxmxSLsqs1QX0dDHVhp4NrW4Me2EZaZE_bJ330bA@mail.gmail.com> (raw)
In-Reply-To: <20180228111113.13639-1-jeffy.chen@rock-chips.com>
Hi Jeffy,
On Wed, Feb 28, 2018 at 12:11 PM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
> Currently we are adding all of the attached devices' clocks as pm clocks
> and enable them when powering on the power domain.
>
> This seems unnecessary, because those clocks are already controlled in
> the devices' drivers with better error handling.
>
> Tested on my chromebook minnie(rk3288) and chromebook kevin(rk3399).
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Thanks for your patch!
Just wondering: so you prefer to handle the clocks explicitly in all drivers,
instead of delegating this task to Runtime PM?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-02-28 12:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 11:11 [PATCH] soc: rockchip: power-domain: remove PM clocks Jeffy Chen
2018-02-28 11:11 ` Jeffy Chen
2018-02-28 11:59 ` Heiko Stübner
2018-02-28 11:59 ` Heiko Stübner
2018-02-28 12:17 ` Geert Uytterhoeven [this message]
2018-02-28 12:17 ` Geert Uytterhoeven
2018-02-28 12:29 ` Tomasz Figa
2018-02-28 12:29 ` Tomasz Figa
2018-02-28 12:32 ` Geert Uytterhoeven
2018-02-28 12:32 ` Geert Uytterhoeven
2018-02-28 12:49 ` Tomasz Figa
2018-02-28 12:49 ` Tomasz Figa
2018-02-28 13:11 ` Geert Uytterhoeven
2018-02-28 13:11 ` Geert Uytterhoeven
2018-02-28 14:07 ` Tomasz Figa
2018-02-28 14:07 ` Tomasz Figa
2018-03-01 3:40 ` JeffyChen
2018-03-01 3:40 ` JeffyChen
2018-03-01 8:33 ` Geert Uytterhoeven
2018-03-01 8:33 ` Geert Uytterhoeven
2018-03-01 9:09 ` JeffyChen
2018-03-01 9:09 ` JeffyChen
2018-03-01 10:18 ` Ulf Hansson
2018-03-01 10:18 ` Ulf Hansson
2018-03-01 10:37 ` Geert Uytterhoeven
2018-03-01 10:37 ` Geert Uytterhoeven
2018-03-01 11:22 ` Ulf Hansson
2018-03-01 11:22 ` Ulf Hansson
2018-03-01 11:54 ` Geert Uytterhoeven
2018-03-01 11:54 ` Geert Uytterhoeven
2018-02-28 12:36 ` JeffyChen
2018-02-28 12:36 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWLL9CxmxSLsqs1QX0dDHVhp4NrW4Me2EZaZE_bJ330bA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=tfiga@chromium.org \
--cc=ulf.hansson@linaro.org \
--cc=wxt@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.