From: Geert Uytterhoeven <geert@linux-m68k.org> To: Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, "open list:DRM DRIVERS FOR RENESAS" <dri-devel@lists.freedesktop.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 1/6] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 Date: Thu, 23 Sep 2021 09:43:07 +0200 [thread overview] Message-ID: <CAMuHMdWfcxb+5uOnPMiB2Z9rUfnRAg2Pzz--H16fOoVoASP=Kw@mail.gmail.com> (raw) In-Reply-To: <20210922234726.3337265-2-kieran.bingham@ideasonboard.com> Hi Kieran, On Thu, Sep 23, 2021 at 1:47 AM Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > --- > v2: > - Collected Laurent's tag > - Remove clock-names requirement > - Specify only a single clock > > v3: > - Use clocknames: 'du.0' instead of 'du' to remain consistent Thanks for the update! > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -39,6 +39,7 @@ properties: > - renesas,du-r8a77980 # for R-Car V3H compatible DU > - renesas,du-r8a77990 # for R-Car E3 compatible DU > - renesas,du-r8a77995 # for R-Car D3 compatible DU > + - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > reg: > maxItems: 1 > @@ -773,6 +774,55 @@ allOf: > - reset-names > - renesas,vsps > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,du-r8a779a0 > + then: > + properties: > + clocks: > + items: > + - description: Functional clock > + > + clock-names: > + maxItems: 1 > + items: > + - const: du.0 > + > + interrupts: > + maxItems: 2 > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: du.0 > + > + ports: > + properties: > + port@0: > + description: DSI 0 > + port@1: > + description: DSI 1 > + port@2: false > + port@3: false > + > + required: > + - port@0 > + - port@1 > + > + renesas,vsps: > + minItems: 2 > + > + required: > + - interrupts > + - resets > + - reset-names > + - renesas,vsps clock-names, for consistency? > + > additionalProperties: false > > examples: With the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, "open list:DRM DRIVERS FOR RENESAS" <dri-devel@lists.freedesktop.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 1/6] dt-bindings: display: renesas, du: Provide bindings for r8a779a0 Date: Thu, 23 Sep 2021 09:43:07 +0200 [thread overview] Message-ID: <CAMuHMdWfcxb+5uOnPMiB2Z9rUfnRAg2Pzz--H16fOoVoASP=Kw@mail.gmail.com> (raw) In-Reply-To: <20210922234726.3337265-2-kieran.bingham@ideasonboard.com> Hi Kieran, On Thu, Sep 23, 2021 at 1:47 AM Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > --- > v2: > - Collected Laurent's tag > - Remove clock-names requirement > - Specify only a single clock > > v3: > - Use clocknames: 'du.0' instead of 'du' to remain consistent Thanks for the update! > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -39,6 +39,7 @@ properties: > - renesas,du-r8a77980 # for R-Car V3H compatible DU > - renesas,du-r8a77990 # for R-Car E3 compatible DU > - renesas,du-r8a77995 # for R-Car D3 compatible DU > + - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > reg: > maxItems: 1 > @@ -773,6 +774,55 @@ allOf: > - reset-names > - renesas,vsps > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,du-r8a779a0 > + then: > + properties: > + clocks: > + items: > + - description: Functional clock > + > + clock-names: > + maxItems: 1 > + items: > + - const: du.0 > + > + interrupts: > + maxItems: 2 > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: du.0 > + > + ports: > + properties: > + port@0: > + description: DSI 0 > + port@1: > + description: DSI 1 > + port@2: false > + port@3: false > + > + required: > + - port@0 > + - port@1 > + > + renesas,vsps: > + minItems: 2 > + > + required: > + - interrupts > + - resets > + - reset-names > + - renesas,vsps clock-names, for consistency? > + > additionalProperties: false > > examples: With the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2021-09-23 7:43 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-22 23:47 [PATCH v3 0/6] drm: rcar-du: V3U Support Kieran Bingham 2021-09-22 23:47 ` [PATCH v3 1/6] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 Kieran Bingham 2021-09-22 23:47 ` [PATCH v3 1/6] dt-bindings: display: renesas, du: " Kieran Bingham 2021-09-23 7:43 ` Geert Uytterhoeven [this message] 2021-09-23 7:43 ` Geert Uytterhoeven 2021-09-23 13:01 ` [PATCH v3.1] dt-bindings: display: renesas,du: " Kieran Bingham 2021-09-23 13:01 ` [PATCH v3.1] dt-bindings: display: renesas, du: " Kieran Bingham 2021-09-27 20:57 ` [PATCH v3.1] dt-bindings: display: renesas,du: " Rob Herring 2021-09-28 1:11 ` Laurent Pinchart 2021-09-22 23:47 ` [PATCH v3 2/6] drm: rcar-du: Sort the DU outputs Kieran Bingham 2021-09-22 23:47 ` [PATCH v3 3/6] drm: rcar-du: Only initialise TVM_TVSYNC mode when supported Kieran Bingham 2021-09-22 23:47 ` [PATCH v3 4/6] drm: rcar-du: Fix DIDSR field name Kieran Bingham 2021-09-22 23:47 ` [PATCH v3 5/6] drm: rcar-du: Split CRTC IRQ and Clock features Kieran Bingham 2021-09-22 23:47 ` [PATCH v3 6/6] drm: rcar-du: Add r8a779a0 device support Kieran Bingham 2021-09-22 23:59 ` Laurent Pinchart 2021-09-23 0:32 ` Kieran Bingham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdWfcxb+5uOnPMiB2Z9rUfnRAg2Pzz--H16fOoVoASP=Kw@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=kieran.bingham@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.