Re: [PATCH] arm64: renesas: r8a77990-ebisu: remove clkout-lr-synchronous from rcar_sound

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Patrice Chotard <patrice.chotard@st.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux-DT <devicetree@vger.kernel.org>,
	Linux-ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: renesas: r8a77990-ebisu: remove clkout-lr-synchronous from rcar_sound
Date: Mon, 16 Dec 2019 09:10:20 +0100	[thread overview]
Message-ID: <CAMuHMdWgPJ-m+sphVi5RDDqg=T3-v1h5aDkVCxmfjENx54DVTg@mail.gmail.com> (raw)
In-Reply-To: <87mubt3tux.wl-kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

On Mon, Dec 16, 2019 at 3:08 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> rcar_sound doesn't support clkout-lr-synchronous in upstream.
> It was supported under out-of-tree rcar_sound.
> upstream rcar_sound is supporting
>         - clkout-lr-synchronous
>         + clkout-lr-asynchronous
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks for your patch!

IIUIC, as no upstream code looks at this property, there is no need to
apply this as a fix for v5.5, and it is safe to queue this for v5.6?

Nevertheless, I think it is good to add
Fixes: 56629fcba94c698d ("arm64: dts: renesas: ebisu: Enable Audio")
No need to resend, I can add that while applying.

Thank you!

> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -636,7 +636,6 @@
>         /* audio_clkout0/1/2/3 */
>         #clock-cells = <1>;
>         clock-frequency = <12288000 11289600>;
> -       clkout-lr-synchronous;
>
>         status = "okay";

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds