From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/2] arm64: dts: renesas: rcar-gen4: Correct avb[01] reg sizes
Date: Sun, 11 Feb 2024 19:17:07 +0100 [thread overview]
Message-ID: <CAMuHMdWqn8vtucjpo28Tw1atSTVKZrKRKPJL1FqdG2h_RMDfPw@mail.gmail.com> (raw)
In-Reply-To: <2ad6b391-c27a-389d-1933-a6e12c21f713@omp.ru>
Hi Sergey,
On Sun, Feb 11, 2024 at 6:01 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
> On 2/11/24 5:21 PM, Geert Uytterhoeven wrote:
> > All Ethernet AVB instances on R-Car Gen4 SoCs have registers related to
> > UDP/IP support, starting at offset 0x800. However, the register blocks
>
> TCP/UDP/ICMP, actually.
I think you are mixing up Ether AVB on R-Car and GbEth on RZ/G2L...
> > for some (but not all) instances are too small to cover them.
> >
> > This patch series fixes this by extending the register block sizes where
> > needed. Note that this has no immediate impact on actual operation, as
> > the Linux driver does not use the UDP/IP registers. Besides, ioremap()
>
> In fact, it does write to CSR0 at offset 0x800... and in the net-next.git
> the checksum offload is now used.
It only does so on GbEth.
While Ether AVB on R-Car Gen4 has both CSR0 and CSR2 (but no CSR1),
and the register descriptions are the same, the documentation for the
bits is completely different. And later registers differ even more...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/2] arm64: dts: renesas: rcar-gen4: Correct avb[01] reg sizes
Date: Sun, 11 Feb 2024 19:17:07 +0100 [thread overview]
Message-ID: <CAMuHMdWqn8vtucjpo28Tw1atSTVKZrKRKPJL1FqdG2h_RMDfPw@mail.gmail.com> (raw)
In-Reply-To: <2ad6b391-c27a-389d-1933-a6e12c21f713@omp.ru>
Hi Sergey,
On Sun, Feb 11, 2024 at 6:01 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
> On 2/11/24 5:21 PM, Geert Uytterhoeven wrote:
> > All Ethernet AVB instances on R-Car Gen4 SoCs have registers related to
> > UDP/IP support, starting at offset 0x800. However, the register blocks
>
> TCP/UDP/ICMP, actually.
I think you are mixing up Ether AVB on R-Car and GbEth on RZ/G2L...
> > for some (but not all) instances are too small to cover them.
> >
> > This patch series fixes this by extending the register block sizes where
> > needed. Note that this has no immediate impact on actual operation, as
> > the Linux driver does not use the UDP/IP registers. Besides, ioremap()
>
> In fact, it does write to CSR0 at offset 0x800... and in the net-next.git
> the checksum offload is now used.
It only does so on GbEth.
While Ether AVB on R-Car Gen4 has both CSR0 and CSR2 (but no CSR1),
and the register descriptions are the same, the documentation for the
bits is completely different. And later registers differ even more...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2024-02-11 18:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 14:21 [PATCH 0/2] arm64: dts: renesas: rcar-gen4: Correct avb[01] reg sizes Geert Uytterhoeven
2024-02-11 14:21 ` Geert Uytterhoeven
2024-02-11 14:21 ` [PATCH 1/2] arm64: dts: renesas: r8a779a0: " Geert Uytterhoeven
2024-02-11 14:21 ` Geert Uytterhoeven
2024-02-11 14:21 ` [PATCH 2/2] arm64: dts: renesas: r8a779g0: " Geert Uytterhoeven
2024-02-11 14:21 ` Geert Uytterhoeven
2024-02-11 17:01 ` [PATCH 0/2] arm64: dts: renesas: rcar-gen4: " Sergey Shtylyov
2024-02-11 17:01 ` Sergey Shtylyov
2024-02-11 18:17 ` Geert Uytterhoeven [this message]
2024-02-11 18:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWqn8vtucjpo28Tw1atSTVKZrKRKPJL1FqdG2h_RMDfPw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.