Re: [PATCH 05/12] bus: simple-pm-bus: Convert to platform remove callback returning void

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Liu Ying <victor.liu@nxp.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Nick Alcock <nick.alcock@oracle.com>,
	Rob Herring <robh@kernel.org>,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 05/12] bus: simple-pm-bus: Convert to platform remove callback returning void
Date: Fri, 10 Nov 2023 08:51:51 +0100	[thread overview]
Message-ID: <CAMuHMdXQ1obmXwtFAic39t93pMdhOTjk_Rxz70_zx7et6g4=7w@mail.gmail.com> (raw)
In-Reply-To: <20231109202830.4124591-6-u.kleine-koenig@pengutronix.de>

On Thu, Nov 9, 2023 at 9:29 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds