From: "Jernej Škrabec" <jernej.skrabec@gmail.com> To: "Arnd Bergmann" <arnd@arndb.de>, "Chen-Yu Tsai" <wens@csie.org>, "Samuel Holland" <samuel@sholland.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Hans de Goede" <hdegoede@redhat.com>, "Laurentiu Tudor" <laurentiu.tudor@nxp.com>, "Rob Herring" <robh@kernel.org>, "Yangtao Li" <frank.li@vivo.com>, "Yuan Can" <yuancan@huawei.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 07/12] bus: sunxi-rsb: Convert to platform remove callback returning void Date: Sat, 18 Nov 2023 22:51:10 +0100 [thread overview] Message-ID: <4874510.31r3eYUQgx@jernej-laptop> (raw) In-Reply-To: <20231109202830.4124591-8-u.kleine-koenig@pengutronix.de> Dne četrtek, 09. november 2023 ob 21:28:37 CET je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > drivers/bus/sunxi-rsb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c > index db0ed4e5d315..fd3e9d82340a 100644 > --- a/drivers/bus/sunxi-rsb.c > +++ b/drivers/bus/sunxi-rsb.c > @@ -817,15 +817,13 @@ static int sunxi_rsb_probe(struct platform_device *pdev) > return 0; > } > > -static int sunxi_rsb_remove(struct platform_device *pdev) > +static void sunxi_rsb_remove(struct platform_device *pdev) > { > struct sunxi_rsb *rsb = platform_get_drvdata(pdev); > > device_for_each_child(rsb->dev, NULL, sunxi_rsb_remove_devices); > pm_runtime_disable(&pdev->dev); > sunxi_rsb_hw_exit(rsb); > - > - return 0; > } > > static const struct dev_pm_ops sunxi_rsb_dev_pm_ops = { > @@ -842,7 +840,7 @@ MODULE_DEVICE_TABLE(of, sunxi_rsb_of_match_table); > > static struct platform_driver sunxi_rsb_driver = { > .probe = sunxi_rsb_probe, > - .remove = sunxi_rsb_remove, > + .remove_new = sunxi_rsb_remove, > .driver = { > .name = RSB_CTRL_NAME, > .of_match_table = sunxi_rsb_of_match_table, >
WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com> To: "Arnd Bergmann" <arnd@arndb.de>, "Chen-Yu Tsai" <wens@csie.org>, "Samuel Holland" <samuel@sholland.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Hans de Goede" <hdegoede@redhat.com>, "Laurentiu Tudor" <laurentiu.tudor@nxp.com>, "Rob Herring" <robh@kernel.org>, "Yangtao Li" <frank.li@vivo.com>, "Yuan Can" <yuancan@huawei.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 07/12] bus: sunxi-rsb: Convert to platform remove callback returning void Date: Sat, 18 Nov 2023 22:51:10 +0100 [thread overview] Message-ID: <4874510.31r3eYUQgx@jernej-laptop> (raw) In-Reply-To: <20231109202830.4124591-8-u.kleine-koenig@pengutronix.de> Dne četrtek, 09. november 2023 ob 21:28:37 CET je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > drivers/bus/sunxi-rsb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c > index db0ed4e5d315..fd3e9d82340a 100644 > --- a/drivers/bus/sunxi-rsb.c > +++ b/drivers/bus/sunxi-rsb.c > @@ -817,15 +817,13 @@ static int sunxi_rsb_probe(struct platform_device *pdev) > return 0; > } > > -static int sunxi_rsb_remove(struct platform_device *pdev) > +static void sunxi_rsb_remove(struct platform_device *pdev) > { > struct sunxi_rsb *rsb = platform_get_drvdata(pdev); > > device_for_each_child(rsb->dev, NULL, sunxi_rsb_remove_devices); > pm_runtime_disable(&pdev->dev); > sunxi_rsb_hw_exit(rsb); > - > - return 0; > } > > static const struct dev_pm_ops sunxi_rsb_dev_pm_ops = { > @@ -842,7 +840,7 @@ MODULE_DEVICE_TABLE(of, sunxi_rsb_of_match_table); > > static struct platform_driver sunxi_rsb_driver = { > .probe = sunxi_rsb_probe, > - .remove = sunxi_rsb_remove, > + .remove_new = sunxi_rsb_remove, > .driver = { > .name = RSB_CTRL_NAME, > .of_match_table = sunxi_rsb_of_match_table, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-18 21:51 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-09 20:28 [PATCH 00/12] bus: Convert to platform remove callback returning void Uwe Kleine-König 2023-11-09 20:28 ` Uwe Kleine-König 2023-11-09 20:28 ` [PATCH 01/12] bus: hisi_lpc: " Uwe Kleine-König 2023-11-09 20:28 ` [PATCH 02/12] bus: omap-ocp2scp: " Uwe Kleine-König 2023-11-09 20:28 ` [PATCH 03/12] bus: omap_l3_smx: " Uwe Kleine-König 2023-11-13 8:34 ` Tony Lindgren 2023-11-09 20:28 ` [PATCH 04/12] bus: qcom-ssc-block-bus: " Uwe Kleine-König 2023-11-09 20:28 ` [PATCH 05/12] bus: simple-pm-bus: " Uwe Kleine-König 2023-11-10 7:51 ` Geert Uytterhoeven 2023-11-09 20:28 ` [PATCH 06/12] bus: sun50i-de2: " Uwe Kleine-König 2023-11-09 20:28 ` Uwe Kleine-König 2023-11-10 10:18 ` Andre Przywara 2023-11-10 10:18 ` Andre Przywara 2023-11-18 21:50 ` Jernej Škrabec 2023-11-18 21:50 ` Jernej Škrabec 2023-11-09 20:28 ` [PATCH 07/12] bus: sunxi-rsb: " Uwe Kleine-König 2023-11-09 20:28 ` Uwe Kleine-König 2023-11-10 10:20 ` Andre Przywara 2023-11-10 10:20 ` Andre Przywara 2023-11-18 21:51 ` Jernej Škrabec [this message] 2023-11-18 21:51 ` Jernej Škrabec 2023-11-09 20:28 ` [PATCH 08/12] bus: tegra-aconnect: " Uwe Kleine-König 2023-11-09 20:28 ` [PATCH 09/12] bus: tegra-gmi: " Uwe Kleine-König 2023-11-09 20:28 ` [PATCH 10/12] bus: ti-pwmss: " Uwe Kleine-König 2023-11-09 20:28 ` [PATCH 11/12] bus: ti-sysc: " Uwe Kleine-König 2023-11-10 6:59 ` Tony Lindgren 2023-11-09 20:28 ` [PATCH 12/12] bus: ts-nbus: " Uwe Kleine-König 2023-11-10 6:32 ` [PATCH 00/12] bus: " Arnd Bergmann 2023-11-10 6:32 ` Arnd Bergmann 2023-11-16 11:53 ` [PULL] " Uwe Kleine-König 2023-11-28 17:49 ` [PULL v2] " Uwe Kleine-König 2023-12-06 17:17 ` patchwork-bot+linux-soc
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4874510.31r3eYUQgx@jernej-laptop \ --to=jernej.skrabec@gmail.com \ --cc=arnd@arndb.de \ --cc=frank.li@vivo.com \ --cc=gregkh@linuxfoundation.org \ --cc=hdegoede@redhat.com \ --cc=kernel@pengutronix.de \ --cc=laurentiu.tudor@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=robh@kernel.org \ --cc=samuel@sholland.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wens@csie.org \ --cc=yuancan@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.