From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] ARM: shmobile: Add support SOC_BUS to R-Car Gen2
Date: Fri, 27 Feb 2015 10:41:04 +0000 [thread overview]
Message-ID: <CAMuHMdXU6xTNec=82wXuBqh68qt8Amc1mo2c7nGYKDQO=rqTKQ@mail.gmail.com> (raw)
In-Reply-To: <2088679.zVJXCDlFW0@wuerfel>
Hi Arnd,
On Fri, Feb 27, 2015 at 10:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 27 February 2015 09:52:23 Simon Horman wrote:
>>
>> On Thu, Feb 26, 2015 at 04:53:39PM +0100, Arnd Bergmann wrote:
>> > On Thursday 26 February 2015 15:22:44 Simon Horman wrote:
>> > > From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> > >
>> > > This provides information through SOC_BUS to sysfs.
>> > > And this moves all on-SoC devices from /sys/devices/platform to
>> > > /sys/devices/socX/.
>> > >
>> > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> > > ---
>> > > arch/arm/mach-shmobile/Kconfig | 1 +
>> > > arch/arm/mach-shmobile/setup-rcar-gen2.c | 38 ++++++++++++++++++++++++++++----
>> > > 2 files changed, 35 insertions(+), 4 deletions(-)
>> >
>> > I think this would be better done as a standalone driver in drivers/soc,
>> > to avoid having to add the init_machine callbacks in patch 3.
>>
>> Could we handle this as follow-up work?
>
> That was my first idea when I looked at patch 3, but then I had the other
> comment below:
>
>> > > + soc_dev_attr->machine = of_flat_dt_get_machine_name();
>> I would not duplicate that information here. Can you find out the SoC
>> name from registers and put it here?
>
> We must not introduce the user interface in one kernel and then change
> it in the next one, so I'm cautious about taking the pull request in
> the current form. Once we have agreed on what the contents of the sysfs
> files should be, I can take the patches, and then we are free to move
> the implementation later.
Currently machine contains e.g. "Koelsch", which is the name of the board,
not of the SoC.
We can derive the SoC name from soc_id, e.g. 0x47 = "R-Car M2-W".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: shmobile: Add support SOC_BUS to R-Car Gen2
Date: Fri, 27 Feb 2015 11:41:04 +0100 [thread overview]
Message-ID: <CAMuHMdXU6xTNec=82wXuBqh68qt8Amc1mo2c7nGYKDQO=rqTKQ@mail.gmail.com> (raw)
In-Reply-To: <2088679.zVJXCDlFW0@wuerfel>
Hi Arnd,
On Fri, Feb 27, 2015 at 10:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 27 February 2015 09:52:23 Simon Horman wrote:
>>
>> On Thu, Feb 26, 2015 at 04:53:39PM +0100, Arnd Bergmann wrote:
>> > On Thursday 26 February 2015 15:22:44 Simon Horman wrote:
>> > > From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> > >
>> > > This provides information through SOC_BUS to sysfs.
>> > > And this moves all on-SoC devices from /sys/devices/platform to
>> > > /sys/devices/socX/.
>> > >
>> > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> > > ---
>> > > arch/arm/mach-shmobile/Kconfig | 1 +
>> > > arch/arm/mach-shmobile/setup-rcar-gen2.c | 38 ++++++++++++++++++++++++++++----
>> > > 2 files changed, 35 insertions(+), 4 deletions(-)
>> >
>> > I think this would be better done as a standalone driver in drivers/soc,
>> > to avoid having to add the init_machine callbacks in patch 3.
>>
>> Could we handle this as follow-up work?
>
> That was my first idea when I looked at patch 3, but then I had the other
> comment below:
>
>> > > + soc_dev_attr->machine = of_flat_dt_get_machine_name();
>> I would not duplicate that information here. Can you find out the SoC
>> name from registers and put it here?
>
> We must not introduce the user interface in one kernel and then change
> it in the next one, so I'm cautious about taking the pull request in
> the current form. Once we have agreed on what the contents of the sysfs
> files should be, I can take the patches, and then we are free to move
> the implementation later.
Currently machine contains e.g. "Koelsch", which is the name of the board,
not of the SoC.
We can derive the SoC name from soc_id, e.g. 0x47 = "R-Car M2-W".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2015-02-27 10:41 UTC|newest]
Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 6:03 [GIT PULL] Renesas ARM Based SoC Updates for v3.16 Simon Horman
2014-04-16 6:03 ` Simon Horman
2014-04-16 6:03 ` [PATCH 1/8] ARM: shmobile: Update r8a7791 CPU freq to 1500MHz in C Simon Horman
2014-04-16 6:03 ` Simon Horman
2014-04-16 6:03 ` [PATCH 2/8] ARM: shmobile: Add shared shmobile_init_delay() Simon Horman
2014-04-16 6:03 ` Simon Horman
2014-04-16 6:03 ` [PATCH 3/8] ARM: shmobile: Remove legacy EMEV2 SoC support Simon Horman
2014-04-16 6:03 ` Simon Horman
2014-04-16 6:03 ` [PATCH 4/8] ARM: shmobile: Remove EMEV2 header file Simon Horman
2014-04-16 6:03 ` Simon Horman
2014-04-16 6:03 ` [PATCH 5/8] ARM: shmobile: Make use of r8a7790_add_standard_devices() Simon Horman
2014-04-16 6:03 ` Simon Horman
2014-04-16 6:03 ` [PATCH 6/8] ARM: shmobile: rcar-gen2: Cache Mode Monitor Register Value Simon Horman
2014-04-16 6:03 ` Simon Horman
2014-04-16 6:03 ` [PATCH 7/8] ARM: shmobile: Check r8a7791 MD21 at SMP boot Simon Horman
2014-04-16 6:03 ` Simon Horman
2014-04-16 6:03 ` [PATCH 8/8] ARM: shmobile: r8a7778/bockw: Move "select RENESAS_INTC_IRQPIN" under SoC Simon Horman
2014-04-16 6:03 ` Simon Horman
2014-05-05 20:45 ` [GIT PULL] Renesas ARM Based SoC Updates for v3.16 Olof Johansson
2014-05-05 20:45 ` Olof Johansson
2014-06-25 7:35 ` [GIT PULL] Renesas ARM Based SoC Updates for v3.17 Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 01/14] ARM: shmobile: r8a7791 SYSC setup code Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 02/14] ARM: shmobile: APMU: Add Core-Standby-state for Suspend to RAM Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 03/14] ARM: shmobile: r8a7790: Support Core-Standby " Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 04/14] ARM: shmobile: r8a7791: " Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 05/14] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 8:56 ` Viresh Kumar
2014-06-25 8:56 ` Viresh Kumar
2014-06-25 9:26 ` Simon Horman
2014-06-25 9:26 ` Simon Horman
2014-06-25 9:30 ` Viresh Kumar
2014-06-25 9:42 ` Viresh Kumar
2014-06-25 11:38 ` Simon Horman
2014-06-25 11:38 ` Simon Horman
2014-06-25 11:39 ` Viresh Kumar
2014-06-25 11:51 ` Viresh Kumar
2014-06-25 12:23 ` Simon Horman
2014-06-25 12:23 ` Simon Horman
2014-06-26 1:48 ` Gaku Inami
2014-06-26 1:48 ` Gaku Inami
2014-06-25 7:35 ` [PATCH 06/14] ARM: shmobile: Use shmobile_init_late() on r8a7790 DT-only Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 07/14] ARM: shmobile: Use shmobile_init_late() on r8a7791 DT-only Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 08/14] ARM: shmobile: Add shared R-Car Gen2 CMA reservation code Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 15:18 ` Sergei Shtylyov
2014-06-25 15:18 ` Sergei Shtylyov
2014-06-25 23:47 ` Simon Horman
2014-06-25 23:47 ` Simon Horman
2014-06-26 0:19 ` Simon Horman
2014-06-26 0:19 ` Simon Horman
2014-06-25 7:35 ` [PATCH 09/14] ARM: shmobile: rcar-gen2: Update for of_get_flat_dt_prop() update Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 10/14] ARM: shmobile: rcar-gen2: Use "1ULL" instead of "(u64)1" Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 11/14] ARM: shmobile: rcar-gen2: Remove useless copied section for LongTrail Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 12/14] ARM: shmobile: rcar-gen2: correct return value of shmobile_smp_apmu_suspend_init Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 13/14] ARM: shmobile: rcar-gen2: update call to dma_contiguous_reserve_area Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-06-25 7:35 ` [PATCH 14/14] ARM: shmobile: Remove ARCH_HAS_CPUFREQ config for shmobile Simon Horman
2014-06-25 7:35 ` Simon Horman
2014-07-08 5:07 ` [GIT PULL] Renesas ARM Based SoC Updates for v3.17 Olof Johansson
2014-07-08 5:07 ` Olof Johansson
2014-07-11 9:40 ` Simon Horman
2014-07-11 9:40 ` Simon Horman
2014-08-23 1:44 ` [GIT PULL] Renesas ARM Based SoC Updates for v3.18 Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 01/11] ARM: shmobile: r8a7778: Add missing call to shmobile_init_late() Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 02/11] ARM: shmobile: sh73a0: Add shmobile_init_late() Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 03/11] ARM: shmobile: r8a7779: Fix shmobile_init_late() Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 04/11] ARM: shmobile: r8a7778: " Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 05/11] ARM: shmobile: r8a73a4: Add shmobile_init_late() Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 06/11] ARM: shmobile: r7s72100: " Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 07/11] ARM: shmobile: Rework multiplatform include workaround Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 08/11] ARM: shmobile: dma: Use defines instead of hardcoded numbers Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 09/11] ARM: shmobile: r8a7779: Remove NR_IRQS_LEGACY Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 10/11] ARM: shmobile: sh7372: Remove unneeded nr_irqs initialization Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-23 1:44 ` [PATCH 11/11] ARM: shmobile: sh73a0: " Simon Horman
2014-08-23 1:44 ` Simon Horman
2014-08-25 0:41 ` [GIT PULL] Renesas ARM Based SoC Updates for v3.18 Simon Horman
2014-08-25 0:41 ` Simon Horman
2014-12-29 1:47 ` [GIT PULL] Renesas ARM Based SoC Updates for v3.20 Simon Horman
2014-12-29 1:47 ` Simon Horman
2014-12-29 1:47 ` [PATCH 1/4] ARM: shmobile: sh73a0 legacy/reference: Add missing INTCA0 clock for irqpin module Simon Horman
2014-12-29 1:47 ` Simon Horman
2014-12-29 1:47 ` [PATCH 2/4] ARM: shmobile: Fix is_e2 warning Simon Horman
2014-12-29 1:47 ` Simon Horman
2014-12-29 1:47 ` [PATCH 3/4] ARM: shmobile: r8a7779: No TWD setup in C for Multiplatform Simon Horman
2014-12-29 1:47 ` Simon Horman
2014-12-29 1:47 ` [PATCH 4/4] ARM: shmobile: r8a73a4: Multiplatform support Simon Horman
2014-12-29 1:47 ` Simon Horman
2015-01-12 22:37 ` [GIT PULL] Renesas ARM Based SoC Updates for v3.20 Olof Johansson
2015-01-12 22:37 ` Olof Johansson
2015-02-26 6:22 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.1 Simon Horman
2015-02-26 6:22 ` Simon Horman
2015-02-26 6:22 ` [PATCH 1/5] ARM: shmobile: No R-Car Gen2 CMA reservation when HIGHMEM=n Simon Horman
2015-02-26 6:22 ` Simon Horman
2015-02-26 6:22 ` [PATCH 2/5] ARM: shmobile: R-Car Gen2: CONFIG_COMMON_CLK is always set Simon Horman
2015-02-26 6:22 ` Simon Horman
2015-02-26 6:22 ` [PATCH 3/5] ARM: shmobile: Add function to get SoCs revision data for R-Car Gen2 Simon Horman
2015-02-26 6:22 ` Simon Horman
2015-02-26 6:22 ` [PATCH 4/5] ARM: shmobile: Add support SOC_BUS to " Simon Horman
2015-02-26 6:22 ` Simon Horman
2015-02-26 15:53 ` Arnd Bergmann
2015-02-26 15:53 ` Arnd Bergmann
2015-02-27 0:52 ` Simon Horman
2015-02-27 0:52 ` Simon Horman
2015-02-27 9:00 ` Arnd Bergmann
2015-02-27 9:00 ` Arnd Bergmann
2015-02-27 10:41 ` Geert Uytterhoeven [this message]
2015-02-27 10:41 ` Geert Uytterhoeven
2015-02-27 13:44 ` Arnd Bergmann
2015-02-27 13:44 ` Arnd Bergmann
2015-03-01 1:52 ` Simon Horman
2015-03-01 1:52 ` Simon Horman
2015-02-26 6:22 ` [PATCH 5/5] ARM: shmobile: r8a7740: Remove restart callback Simon Horman
2015-02-26 6:22 ` Simon Horman
2015-05-28 1:05 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.2 Simon Horman
2015-05-28 1:05 ` Simon Horman
2015-05-28 1:05 ` [PATCH] ARM: shmobile: only select sound drivers that build Simon Horman
2015-05-28 1:05 ` Simon Horman
2015-05-29 14:24 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.2 Arnd Bergmann
2015-05-29 14:24 ` Arnd Bergmann
2015-07-24 8:41 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.3 Simon Horman
2015-07-24 8:41 ` Simon Horman
2015-07-24 8:41 ` [PATCH 1/2] ARM: shmobile: Basic r8a7793 SoC support Simon Horman
2015-07-24 8:41 ` Simon Horman
2015-07-24 8:41 ` [PATCH 2/2] ARM: shmobile: gose: enable R-Car Gen2 regulator quirk Simon Horman
2015-07-24 8:41 ` Simon Horman
2015-07-27 12:35 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.3 Olof Johansson
2015-07-27 12:35 ` Olof Johansson
2015-09-24 5:30 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.4 Simon Horman
2015-09-24 5:30 ` Simon Horman
2015-09-24 5:30 ` [PATCH] ARM: shmobile: R-Mobile: Use CPG/MSTP Clock Domain attach/detach helpers Simon Horman
2015-09-24 5:30 ` Simon Horman
2015-10-06 14:43 ` [GIT PULL] Renesas ARM Based SoC Updates for v4.4 Arnd Bergmann
2015-10-06 14:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXU6xTNec=82wXuBqh68qt8Amc1mo2c7nGYKDQO=rqTKQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.