Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Chris Paterson <Chris.Paterson2@renesas.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Simon Horman <horms@verge.net.au>,
	Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Biju Das <biju.das@bp.renesas.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi
Date: Mon, 14 Aug 2017 16:15:44 +0200	[thread overview]
Message-ID: <CAMuHMdXX0BRvWOc4iosiYNWuA4tP2BpLF5kndNrDL4FeKctgkA@mail.gmail.com> (raw)
In-Reply-To: <TY1PR06MB0702EA22AFE7D8145BF623A6B7880@TY1PR06MB0702.apcprd06.prod.outlook.com>

On Thu, Aug 10, 2017 at 3:49 PM, Chris Paterson
<Chris.Paterson2@renesas.com> wrote:
>> From: Wolfram Sang [mailto:wsa@the-dreams.de]
>> Sent: 10 August 2017 12:24
>>
>>
>> > > >+                i2c6: i2c@e60b0000 {
>> > >
>> > >    I'd use iic0 as the label.

Sergei: I assume you meant "iic3"? ;-)

>> >
>> > I have no preference here other than that we try to be consistent in
>> > DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
>>
>> Back then, for M2-W, I decided to go with the schematics/datasheets.
>> And those mentioned i2c6 rather than iic0. For that reason, the comment
>
> The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M.
>
>>
>> "/* The memory map in the User's Manual maps the cores to bus numbers */"
>>
>> exists in r8a7791.dtsi. Dunno the manual of this SoC here.
>
> The manual for r8a7743 uses the same terminology as the r8a7791 manuals.

The pinctrl section does, indeed.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds