Re: [PATCH v3 04/11] drivers: clk: renesas: r9a07g044-cpg: Add USB clocks/resets

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v3 04/11] drivers: clk: renesas: r9a07g044-cpg: Add USB clocks/resets
Date: Thu, 1 Jul 2021 15:26:05 +0200	[thread overview]
Message-ID: <CAMuHMdXZrDx++iiiQTaSeQf4zUJVRmbFOVt-JdgQM-J-Yvu9XA@mail.gmail.com> (raw)
In-Reply-To: <OS0PR01MB59223D3E0DA71C15A780BD8086009@OS0PR01MB5922.jpnprd01.prod.outlook.com>

Hi Biju,

On Thu, Jul 1, 2021 at 2:41 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Subject: Re: [PATCH v3 04/11] drivers: clk: renesas: r9a07g044-cpg: Add
> > USB clocks/resets
> > On Wed, Jun 30, 2021 at 9:30 AM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > > Add clock/reset entries for USB PHY control, USB2.0 host and device.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > ---
> > > v2->V3:
> > >  * Added reset entries.
> >
> > Thanks for the update!
> >
> > > --- a/drivers/clk/renesas/r9a07g044-cpg.c
> > > +++ b/drivers/clk/renesas/r9a07g044-cpg.c
> > > @@ -96,6 +96,14 @@ static struct rzg2l_mod_clk r9a07g044_mod_clks[] = {
> > >                                 0x52c, 0),
> > >         DEF_MOD("dmac_pclk",    R9A07G044_DMAC_PCLK, CLK_P1_DIV2,
> > >                                 0x52c, 1),
> > > +       DEF_MOD("usb0_host",    R9A07G044_USB_U2H0_HCLK,
> > R9A07G044_CLK_P1,
> > > +                               0x578, 0),
> > > +       DEF_MOD("usb1_host",    R9A07G044_USB_U2H1_HCLK,
> > R9A07G044_CLK_P1,
> > > +                               0x578, 1),
> > > +       DEF_MOD("usb0_device",  R9A07G044_USB_U2P_EXR_CPUCLK,
> > R9A07G044_CLK_P1,
> > > +                               0x578, 2),
> >
> > The names are not really used, but the lock list spreadsheet describes
> > this clock as the usb0 function clock, so perhaps "usb0_func" is more
> > appropriate?
>
> OK. Will change it to "usb0_func".

No need to resend, will fix that while applying.
i.e. will queue in renesas-clk-for-v5.15.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds