From: Biju Das <biju.das.jz@bp.renesas.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Chris Paterson <Chris.Paterson2@renesas.com>, Biju Das <biju.das@bp.renesas.com>, Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: RE: [PATCH v3 07/11] dt-bindings: phy: renesas,usb2-phy: Document RZ/G2L phy bindings Date: Wed, 30 Jun 2021 10:28:21 +0000 [thread overview] Message-ID: <OS0PR01MB59221A03F825931B778C9E1586019@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAMuHMdWbhY9i+WvV77LVNYhLBLQBVCojgEwM93A-pvFf9Eab1g@mail.gmail.com> Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v3 07/11] dt-bindings: phy: renesas,usb2-phy: Document > RZ/G2L phy bindings > > Hi Biju, > > Thanks for your patch! > > On Wed, Jun 30, 2021 at 9:31 AM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Document USB phy bindings for RZ/G2L SoC. > > > > RZ/G2L USB2.0 phy uses line ctrl register for OTG_ID pin changes. > > Apart from this it uses a different OTG-BC interrupt bit for device > recognition. > > Nothing about resets? But see below... Initially the reset of USB/PHY port is in asserted state. So we need to perform a release reset using USBPHY control IP. OK, will add this in V4. > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > v2->v3 > > * Created a new compatible for RZ/G2L as per Geert's suggestion. > > * Added resets required properties for RZ/G2L SoC. > > --- > > .../bindings/phy/renesas,usb2-phy.yaml | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > > b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > > index d5dc5a3cdceb..a7e585ff28dc 100644 > > --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > > @@ -30,6 +30,9 @@ properties: > > - renesas,usb2-phy-r8a77995 # R-Car D3 > > - const: renesas,rcar-gen3-usb2-phy > > > > + - items: > > + - const: renesas,usb2-phy-r9a07g044 # RZ/G2{L,LC} > > + > > reg: > > maxItems: 1 > > > > @@ -91,6 +94,21 @@ required: > > - clocks > > - '#phy-cells' > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: renesas,usb2-phy-r9a07g044 > > + then: > > + properties: > > + resets: > > + items: > > + - description: USB phy reset > > + - description: reset of USB 2.0 host side > > Do you need the second reset? > Looking at your .dtsi patch, the second reset is shared with ehci/ohci, so > perhaps it makes sense to drop it from the phy node? OK. Agreed will drop the second reset from phy node. Cheers, Biju > > > + required: > > + - resets > > + > > additionalProperties: false > > > > examples: > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Biju Das <biju.das.jz@bp.renesas.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Chris Paterson <Chris.Paterson2@renesas.com>, Biju Das <biju.das@bp.renesas.com>, Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: RE: [PATCH v3 07/11] dt-bindings: phy: renesas,usb2-phy: Document RZ/G2L phy bindings Date: Wed, 30 Jun 2021 10:28:21 +0000 [thread overview] Message-ID: <OS0PR01MB59221A03F825931B778C9E1586019@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAMuHMdWbhY9i+WvV77LVNYhLBLQBVCojgEwM93A-pvFf9Eab1g@mail.gmail.com> Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v3 07/11] dt-bindings: phy: renesas,usb2-phy: Document > RZ/G2L phy bindings > > Hi Biju, > > Thanks for your patch! > > On Wed, Jun 30, 2021 at 9:31 AM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Document USB phy bindings for RZ/G2L SoC. > > > > RZ/G2L USB2.0 phy uses line ctrl register for OTG_ID pin changes. > > Apart from this it uses a different OTG-BC interrupt bit for device > recognition. > > Nothing about resets? But see below... Initially the reset of USB/PHY port is in asserted state. So we need to perform a release reset using USBPHY control IP. OK, will add this in V4. > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > v2->v3 > > * Created a new compatible for RZ/G2L as per Geert's suggestion. > > * Added resets required properties for RZ/G2L SoC. > > --- > > .../bindings/phy/renesas,usb2-phy.yaml | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > > b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > > index d5dc5a3cdceb..a7e585ff28dc 100644 > > --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml > > @@ -30,6 +30,9 @@ properties: > > - renesas,usb2-phy-r8a77995 # R-Car D3 > > - const: renesas,rcar-gen3-usb2-phy > > > > + - items: > > + - const: renesas,usb2-phy-r9a07g044 # RZ/G2{L,LC} > > + > > reg: > > maxItems: 1 > > > > @@ -91,6 +94,21 @@ required: > > - clocks > > - '#phy-cells' > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: renesas,usb2-phy-r9a07g044 > > + then: > > + properties: > > + resets: > > + items: > > + - description: USB phy reset > > + - description: reset of USB 2.0 host side > > Do you need the second reset? > Looking at your .dtsi patch, the second reset is shared with ehci/ohci, so > perhaps it makes sense to drop it from the phy node? OK. Agreed will drop the second reset from phy node. Cheers, Biju > > > + required: > > + - resets > > + > > additionalProperties: false > > > > examples: > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-06-30 10:28 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20210630073013.22415-1-biju.das.jz@bp.renesas.com> 2021-06-30 7:30 ` [PATCH v3 01/11] dt-bindings: usb: generic-ohci: Document dr_mode property Biju Das 2021-07-14 21:16 ` Rob Herring 2021-06-30 7:30 ` [PATCH v3 02/11] dt-bindings: usb: generic-ehci: " Biju Das 2021-07-14 21:16 ` Rob Herring 2021-06-30 7:30 ` [PATCH v3 03/11] dt-bindings: reset: Document RZ/G2L USBPHY Control bindings Biju Das 2021-07-01 14:02 ` Rob Herring 2021-07-01 20:23 ` Rob Herring 2021-07-03 10:53 ` Biju Das 2021-06-30 7:30 ` [PATCH v3 04/11] drivers: clk: renesas: r9a07g044-cpg: Add USB clocks/resets Biju Das 2021-07-01 12:16 ` Geert Uytterhoeven 2021-07-01 12:40 ` Biju Das 2021-07-01 13:26 ` Geert Uytterhoeven 2021-06-30 7:30 ` [PATCH v3 05/11] reset: renesas: Add RZ/G2L usbphy control driver Biju Das 2021-06-30 11:48 ` Philipp Zabel 2021-06-30 13:25 ` Biju Das 2021-07-02 8:52 ` Philipp Zabel 2021-07-02 9:26 ` Biju Das 2021-06-30 7:30 ` [PATCH v3 06/11] arm64: configs: defconfig: Enable RZ/G2L USBPHY " Biju Das 2021-06-30 7:30 ` Biju Das 2021-06-30 7:30 ` [PATCH v3 07/11] dt-bindings: phy: renesas,usb2-phy: Document RZ/G2L phy bindings Biju Das 2021-06-30 7:30 ` [PATCH v3 07/11] dt-bindings: phy: renesas, usb2-phy: " Biju Das 2021-06-30 9:29 ` [PATCH v3 07/11] dt-bindings: phy: renesas,usb2-phy: " Geert Uytterhoeven 2021-06-30 9:29 ` Geert Uytterhoeven 2021-06-30 10:28 ` Biju Das [this message] 2021-06-30 10:28 ` Biju Das 2021-07-14 21:21 ` Rob Herring 2021-07-14 21:21 ` Rob Herring 2021-07-18 8:29 ` Biju Das 2021-07-18 8:29 ` Biju Das 2021-06-30 7:30 ` [PATCH v3 08/11] arm64: dts: renesas: r9a07g044: Add USB2.0 phy and host support Biju Das 2021-06-30 7:30 ` [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings Biju Das 2021-07-14 21:24 ` Rob Herring 2021-07-15 7:18 ` Biju Das 2021-06-30 7:30 ` [PATCH v3 10/11] phy: renesas: phy-rcar-gen3-usb2: Add OTG support for RZ/G2L Biju Das 2021-06-30 7:30 ` Biju Das 2021-06-30 7:30 ` [PATCH v3 11/11] arm64: dts: renesas: r9a07g044: Add USB2.0 device support Biju Das
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=OS0PR01MB59221A03F825931B778C9E1586019@OS0PR01MB5922.jpnprd01.prod.outlook.com \ --to=biju.das.jz@bp.renesas.com \ --cc=Chris.Paterson2@renesas.com \ --cc=biju.das@bp.renesas.com \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=geert@linux-m68k.org \ --cc=kishon@ti.com \ --cc=linux-phy@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ --cc=yoshihiro.shimoda.uh@renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.