Re: [PATCH v2 1/4] ARM: dts: rcar-gen2: Add reset control properties for display

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/4] ARM: dts: rcar-gen2: Add reset control properties for display
Date: Wed, 19 Feb 2020 16:30:04 +0100	[thread overview]
Message-ID: <CAMuHMdXoH6H6HiEFgANi8WMzTj0wFVr01-5-Ha9768MrPePKXQ@mail.gmail.com> (raw)
In-Reply-To: <20200219152728.GR5070@pendragon.ideasonboard.com>

Hi Laurent,

On Wed, Feb 19, 2020 at 4:27 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Tue, Feb 18, 2020 at 02:30:16PM +0100, Geert Uytterhoeven wrote:
> > Add reset control properties to the device nodes for the Display Units
> > on all supported R-Car Gen2 SoCs.  Note that on these SoCs, there is
> > only a single reset for all DU channels.
> >
> > Join the clocks lines while at it, to increase uniformity.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v2:
> >   - New.
> > ---
> >  arch/arm/boot/dts/r8a7790.dtsi | 2 ++
> >  arch/arm/boot/dts/r8a7791.dtsi | 5 +++--
> >  arch/arm/boot/dts/r8a7792.dtsi | 5 +++--
> >  arch/arm/boot/dts/r8a7793.dtsi | 5 +++--
> >  arch/arm/boot/dts/r8a7794.dtsi | 2 ++
> >  5 files changed, 13 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> > index 334ba19769b998ac..e5ef9fd4284ae436 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > @@ -1719,6 +1719,8 @@
> >                       clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> >                                <&cpg CPG_MOD 722>;
> >                       clock-names = "du.0", "du.1", "du.2";
> > +                     resets = <&cpg 724>;
> > +                     reset-names = "du.0";
>
> If there's a single reset for all channels, should it be just named "du"
> ? Or maybe skip the name completely ?

Doing so means the bindings should be updated first to reflect that.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds