From: Geert Uytterhoeven <geert@linux-m68k.org> To: Biju Das <biju.das.jz@bp.renesas.com> Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Magnus Damm <magnus.damm@gmail.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <robert.foss@linaro.org>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com> Subject: Re: [PATCH v2 7/7] drm: rcar-du: dsi: Add r8a779g0 support Date: Tue, 29 Nov 2022 12:49:27 +0100 [thread overview] Message-ID: <CAMuHMdXz8ZSge5b4s8v6Oon55gO+3Cu_Uvn7GFV62JCSqNf1Qw@mail.gmail.com> (raw) In-Reply-To: <OS0PR01MB59224C2B4F889534922ACFE186129@OS0PR01MB5922.jpnprd01.prod.outlook.com> Hi Biju, On Tue, Nov 29, 2022 at 12:40 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> > > On 29/11/2022 03:49, Laurent Pinchart wrote: > > > On Wed, Nov 23, 2022 at 08:59:46AM +0200, Tomi Valkeinen wrote: > > >> Add DSI support for r8a779g0. The main differences to r8a779a0 are in > > >> the PLL and PHTW setups. > > >> > > >> Signed-off-by: Tomi Valkeinen > > >> <tomi.valkeinen+renesas@ideasonboard.com> > > >> --- a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > > >> +++ b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > > >> @@ -9,6 +9,7 @@ > > >> #include <linux/delay.h> > > >> #include <linux/io.h> > > >> #include <linux/iopoll.h> > > >> +#include <linux/math64.h> > > >> #include <linux/module.h> > > >> #include <linux/of.h> > > >> #include <linux/of_device.h> > > >> @@ -28,6 +29,20 @@ > > >> #include "rcar_mipi_dsi.h" > > >> #include "rcar_mipi_dsi_regs.h" > > >> > > >> +#define MHZ(v) ((v) * 1000000u) > > > > > > Isn't the U suffix usually spelled in uppercase ? Same below. > > > > I couldn't find any coding style guidelines on that. I like the lower > > case visually. The suffix stands out much clearer on 10000000u than on > > 10000000U. But I can change it if you feel otherwise. > > https://elixir.bootlin.com/linux/v6.1-rc7/source/include/linux/units.h#L11 > > Maybe you could add MHZ here?? Or use the existing MEGA? The metric system is soooo nice! ;-) BTW, looks like the people adding definitions like #define MICROHZ_PER_HZ 1000000UL #define MILLIHZ_PER_HZ 1000UL #define MILLIWATT_PER_WATT 1000UL #define MICROWATT_PER_MILLIWATT 1000UL #define MICROWATT_PER_WATT 1000000UL didn't grasp the full power... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Biju Das <biju.das.jz@bp.renesas.com> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <robert.foss@linaro.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Jonas Karlman <jonas@kwiboo.se>, Magnus Damm <magnus.damm@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> Subject: Re: [PATCH v2 7/7] drm: rcar-du: dsi: Add r8a779g0 support Date: Tue, 29 Nov 2022 12:49:27 +0100 [thread overview] Message-ID: <CAMuHMdXz8ZSge5b4s8v6Oon55gO+3Cu_Uvn7GFV62JCSqNf1Qw@mail.gmail.com> (raw) In-Reply-To: <OS0PR01MB59224C2B4F889534922ACFE186129@OS0PR01MB5922.jpnprd01.prod.outlook.com> Hi Biju, On Tue, Nov 29, 2022 at 12:40 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> > > On 29/11/2022 03:49, Laurent Pinchart wrote: > > > On Wed, Nov 23, 2022 at 08:59:46AM +0200, Tomi Valkeinen wrote: > > >> Add DSI support for r8a779g0. The main differences to r8a779a0 are in > > >> the PLL and PHTW setups. > > >> > > >> Signed-off-by: Tomi Valkeinen > > >> <tomi.valkeinen+renesas@ideasonboard.com> > > >> --- a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > > >> +++ b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > > >> @@ -9,6 +9,7 @@ > > >> #include <linux/delay.h> > > >> #include <linux/io.h> > > >> #include <linux/iopoll.h> > > >> +#include <linux/math64.h> > > >> #include <linux/module.h> > > >> #include <linux/of.h> > > >> #include <linux/of_device.h> > > >> @@ -28,6 +29,20 @@ > > >> #include "rcar_mipi_dsi.h" > > >> #include "rcar_mipi_dsi_regs.h" > > >> > > >> +#define MHZ(v) ((v) * 1000000u) > > > > > > Isn't the U suffix usually spelled in uppercase ? Same below. > > > > I couldn't find any coding style guidelines on that. I like the lower > > case visually. The suffix stands out much clearer on 10000000u than on > > 10000000U. But I can change it if you feel otherwise. > > https://elixir.bootlin.com/linux/v6.1-rc7/source/include/linux/units.h#L11 > > Maybe you could add MHZ here?? Or use the existing MEGA? The metric system is soooo nice! ;-) BTW, looks like the people adding definitions like #define MICROHZ_PER_HZ 1000000UL #define MILLIHZ_PER_HZ 1000UL #define MILLIWATT_PER_WATT 1000UL #define MICROWATT_PER_MILLIWATT 1000UL #define MICROWATT_PER_WATT 1000000UL didn't grasp the full power... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2022-11-29 11:49 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-23 6:59 [PATCH v2 0/7] Renesas V4H DSI & DP output support Tomi Valkeinen 2022-11-23 6:59 ` Tomi Valkeinen 2022-11-23 6:59 ` [PATCH v2 1/7] dt-bindings: display: renesas,du: Provide bindings for r8a779g0 Tomi Valkeinen 2022-11-23 6:59 ` [PATCH v2 1/7] dt-bindings: display: renesas, du: " Tomi Valkeinen 2022-11-23 6:59 ` [PATCH v2 2/7] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Add r8a779g0 Tomi Valkeinen 2022-11-23 6:59 ` [PATCH v2 2/7] dt-bindings: display: bridge: renesas, dsi-csi2-tx: " Tomi Valkeinen 2022-11-23 6:59 ` [PATCH v2 3/7] clk: renesas: r8a779g0: Add display related clocks Tomi Valkeinen 2022-11-23 6:59 ` Tomi Valkeinen 2022-11-30 19:18 ` Geert Uytterhoeven 2022-11-30 19:18 ` Geert Uytterhoeven 2022-12-01 9:06 ` Tomi Valkeinen 2022-12-01 9:06 ` Tomi Valkeinen 2022-12-01 9:34 ` Geert Uytterhoeven 2022-12-01 9:34 ` Geert Uytterhoeven 2022-12-01 9:26 ` Tomi Valkeinen 2022-12-01 9:26 ` Tomi Valkeinen 2022-12-01 9:45 ` Geert Uytterhoeven 2022-12-01 9:45 ` Geert Uytterhoeven 2022-11-23 6:59 ` [PATCH v2 4/7] arm64: dts: renesas: r8a779g0: Add display related nodes Tomi Valkeinen 2022-11-23 6:59 ` Tomi Valkeinen 2022-12-01 9:20 ` Geert Uytterhoeven 2022-12-01 9:20 ` Geert Uytterhoeven 2022-11-23 6:59 ` [PATCH v2 5/7] arm64: dts: renesas: white-hawk-cpu: Add DP output support Tomi Valkeinen 2022-11-23 6:59 ` Tomi Valkeinen 2022-12-01 10:03 ` Geert Uytterhoeven 2022-12-01 10:03 ` Geert Uytterhoeven 2022-11-23 6:59 ` [PATCH v2 6/7] drm: rcar-du: Add r8a779g0 support Tomi Valkeinen 2022-11-23 6:59 ` Tomi Valkeinen 2022-11-23 6:59 ` [PATCH v2 7/7] drm: rcar-du: dsi: " Tomi Valkeinen 2022-11-23 6:59 ` Tomi Valkeinen 2022-11-29 1:49 ` Laurent Pinchart 2022-11-29 1:49 ` Laurent Pinchart 2022-11-29 11:30 ` Tomi Valkeinen 2022-11-29 11:30 ` Tomi Valkeinen 2022-11-29 11:40 ` Biju Das 2022-11-29 11:40 ` Biju Das 2022-11-29 11:49 ` Geert Uytterhoeven [this message] 2022-11-29 11:49 ` Geert Uytterhoeven 2022-11-29 12:05 ` Laurent Pinchart 2022-11-29 12:05 ` Laurent Pinchart 2022-11-29 12:59 ` Tomi Valkeinen 2022-11-29 12:59 ` Tomi Valkeinen 2022-11-29 13:41 ` [PATCH v3 7/7] drm: rcar-du: dsi: Add r8A779g0 support Tomi Valkeinen 2022-11-29 13:41 ` Tomi Valkeinen 2022-11-29 17:44 ` Laurent Pinchart 2022-11-29 17:44 ` Laurent Pinchart 2022-11-30 8:08 ` [PATCH v4 " Tomi Valkeinen 2022-11-30 8:08 ` Tomi Valkeinen 2022-11-29 1:58 ` [PATCH v2 0/7] Renesas V4H DSI & DP output support Laurent Pinchart 2022-11-29 1:58 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdXz8ZSge5b4s8v6Oon55gO+3Cu_Uvn7GFV62JCSqNf1Qw@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=andrzej.hajda@intel.com \ --cc=biju.das.jz@bp.renesas.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert+renesas@glider.be \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=neil.armstrong@linaro.org \ --cc=robert.foss@linaro.org \ --cc=robh+dt@kernel.org \ --cc=tomi.valkeinen+renesas@ideasonboard.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.