From: Robert Foss <rfoss@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Jonas Karlman" <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
linux-renesas-soc@vger.kernel.org,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Adam Ford" <aford173@gmail.com>,
"Bogdan Togorean" <bogdan.togorean@analog.com>
Subject: Re: [PATCH v2 5/8] drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info
Date: Mon, 16 Oct 2023 10:58:19 +0200 [thread overview]
Message-ID: <CAN6tsi7P4ooXeD_EGmMbGu-wtGaZjpbZ6N-Lkan+Q5GE4z-dQw@mail.gmail.com> (raw)
In-Reply-To: <20230830142358.275459-6-biju.das.jz@bp.renesas.com>
On Wed, Aug 30, 2023 at 4:24 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> The ADV7533 and ADV7535 have an offset(0x70) for the CEC register map
> compared to ADV7511. Add the reg_cec_offset variable to struct
> adv7511_chip_info to handle this difference and drop the reg_cec_offset
> variable from struct adv7511.
>
> This will avoid assigning reg_cec_offset based on chip type and also
> testing for multiple chip types for calling adv7533_patch_cec_registers().
s/for calling/by calling/ ?
Reviewed-by: Robert Foss <rfoss@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Robert Foss <rfoss@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Neil Armstrong" <neil.armstrong@linaro.org>,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Adam Ford" <aford173@gmail.com>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
dri-devel@lists.freedesktop.org,
"Javier Martinez Canillas" <javierm@redhat.com>,
linux-renesas-soc@vger.kernel.org,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Bogdan Togorean" <bogdan.togorean@analog.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2 5/8] drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info
Date: Mon, 16 Oct 2023 10:58:19 +0200 [thread overview]
Message-ID: <CAN6tsi7P4ooXeD_EGmMbGu-wtGaZjpbZ6N-Lkan+Q5GE4z-dQw@mail.gmail.com> (raw)
In-Reply-To: <20230830142358.275459-6-biju.das.jz@bp.renesas.com>
On Wed, Aug 30, 2023 at 4:24 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> The ADV7533 and ADV7535 have an offset(0x70) for the CEC register map
> compared to ADV7511. Add the reg_cec_offset variable to struct
> adv7511_chip_info to handle this difference and drop the reg_cec_offset
> variable from struct adv7511.
>
> This will avoid assigning reg_cec_offset based on chip type and also
> testing for multiple chip types for calling adv7533_patch_cec_registers().
s/for calling/by calling/ ?
Reviewed-by: Robert Foss <rfoss@kernel.org>
next prev parent reply other threads:[~2023-10-16 8:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 14:23 [PATCH v2 0/8] ADV7511 driver enhancements Biju Das
2023-08-30 14:23 ` Biju Das
2023-08-30 14:23 ` [PATCH v2 1/8] drm: adv7511: Add struct adv7511_chip_info and use i2c_get_match_data() Biju Das
2023-08-30 14:23 ` Biju Das
2023-10-16 9:07 ` Robert Foss
2023-10-16 9:07 ` Robert Foss
2023-08-30 14:23 ` [PATCH v2 2/8] drm: adv7511: Add max_mode_clock_khz variable to struct adv7511_chip_info Biju Das
2023-08-30 14:23 ` Biju Das
2023-10-16 9:06 ` Robert Foss
2023-10-16 9:06 ` Robert Foss
2023-08-30 14:23 ` [PATCH v2 3/8] drm: adv7511: Add max_lane_freq_khz " Biju Das
2023-08-30 14:23 ` Biju Das
2023-10-16 9:05 ` Robert Foss
2023-10-16 9:05 ` Robert Foss
2023-08-30 14:23 ` [PATCH v2 4/8] drm: adv7511: Add supply_names and num_supplies variables " Biju Das
2023-08-30 14:23 ` Biju Das
2023-10-16 9:03 ` Robert Foss
2023-10-16 9:03 ` Robert Foss
2023-08-30 14:23 ` [PATCH v2 5/8] drm: adv7511: Add reg_cec_offset variable " Biju Das
2023-08-30 14:23 ` Biju Das
2023-10-16 8:58 ` Robert Foss [this message]
2023-10-16 8:58 ` Robert Foss
2023-10-16 9:37 ` Biju Das
2023-10-16 9:37 ` Biju Das
2023-08-30 14:23 ` [PATCH v2 6/8] drm: adv7511: Add has_dsi " Biju Das
2023-08-30 14:23 ` Biju Das
2023-10-16 9:01 ` Robert Foss
2023-10-16 9:01 ` Robert Foss
2023-08-30 14:23 ` [PATCH v2 7/8] drm: adv7511: Add link_config " Biju Das
2023-08-30 14:23 ` Biju Das
2023-10-16 8:59 ` Robert Foss
2023-10-16 8:59 ` Robert Foss
2023-08-30 14:23 ` [PATCH v2 8/8] drm: adv7511: Add hpd_override_enable " Biju Das
2023-08-30 14:23 ` Biju Das
2023-10-16 8:59 ` Robert Foss
2023-10-16 8:59 ` Robert Foss
2023-10-02 7:14 ` [PATCH v2 0/8] ADV7511 driver enhancements Biju Das
2023-10-02 7:14 ` Biju Das
2023-10-09 7:04 ` Biju Das
2023-10-09 7:04 ` Biju Das
2023-10-16 9:12 ` Robert Foss
2023-10-16 9:12 ` Robert Foss
2023-10-16 9:28 ` Biju Das
2023-10-16 9:28 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN6tsi7P4ooXeD_EGmMbGu-wtGaZjpbZ6N-Lkan+Q5GE4z-dQw@mail.gmail.com \
--to=rfoss@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.fatoum@pengutronix.de \
--cc=aford173@gmail.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=bogdan.togorean@analog.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.