From: Nicolas Boichat <drinkcat@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Collabora Kernel ML <kernel@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Jitao Shi <jitao.shi@mediatek.com>,
Daniel Kurtz <djkurtz@chromium.org>, Ulrich Hecht <uli@fpond.eu>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org,
Neil Armstrong <narmstrong@baylibre.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
David Airlie <airlied@linux.ie>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Mon, 23 Dec 2019 17:14:41 +0800 [thread overview]
Message-ID: <CANMq1KA4mp648p1LicOzAyra6tdgN2qdDY=N0XyDYhgt6BP26w@mail.gmail.com> (raw)
In-Reply-To: <05db638b-02a6-0e3a-43ed-44a0a1458d87@collabora.com>
On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Nicolas,
>
> Many thanks for you review. Just preparing a new version with your comments
> addressed.
>
> On 20/12/19 9:44, Nicolas Boichat wrote:
> > On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra
> > <enric.balletbo@collabora.com> wrote:
> >>
> >> From: Jitao Shi <jitao.shi@mediatek.com>
> >>
> >> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
> >>
> >> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> >> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> >> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >> [uli: followed API changes, removed FW update feature]
> >> Signed-off-by: Ulrich Hecht <uli@fpond.eu>
> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >> ---
> [snip]
> >> + ret = i2c_smbus_write_byte_data(client, PAGE2_MCS_EN,
> >> + status & ~MCS_EN);
> >> + if (ret < 0) {
> >> + DRM_ERROR("failed write PAGE2_MCS_EN: %d\n", ret);
> >> + goto err_regulators_disable;
> >> + }
> >> +
> >> + ret = ps8640_bridge_unmute(ps_bridge);
> >> + if (ret)
> >> + DRM_ERROR("failed to enable unmutevideo: %d\n", ret);
> >
> > failed to unmute? Or failed to enable?
> >
>
> failed to unmute sound more clear to me.
I may be wrong, but I have the feeling that the functions
"mute/unmute" video/display, actually... And that the function naming
is strange...
You could just try to remove the calls, as there is no audio on the
board you have (elm), so if video still works, maybe this is actually
audio ,-)
Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Boichat <drinkcat@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Ulrich Hecht <uli@fpond.eu>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jitao Shi <jitao.shi@mediatek.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
lkml <linux-kernel@vger.kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Collabora Kernel ML <kernel@collabora.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Mon, 23 Dec 2019 17:14:41 +0800 [thread overview]
Message-ID: <CANMq1KA4mp648p1LicOzAyra6tdgN2qdDY=N0XyDYhgt6BP26w@mail.gmail.com> (raw)
In-Reply-To: <05db638b-02a6-0e3a-43ed-44a0a1458d87@collabora.com>
On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Nicolas,
>
> Many thanks for you review. Just preparing a new version with your comments
> addressed.
>
> On 20/12/19 9:44, Nicolas Boichat wrote:
> > On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra
> > <enric.balletbo@collabora.com> wrote:
> >>
> >> From: Jitao Shi <jitao.shi@mediatek.com>
> >>
> >> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
> >>
> >> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> >> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> >> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >> [uli: followed API changes, removed FW update feature]
> >> Signed-off-by: Ulrich Hecht <uli@fpond.eu>
> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >> ---
> [snip]
> >> + ret = i2c_smbus_write_byte_data(client, PAGE2_MCS_EN,
> >> + status & ~MCS_EN);
> >> + if (ret < 0) {
> >> + DRM_ERROR("failed write PAGE2_MCS_EN: %d\n", ret);
> >> + goto err_regulators_disable;
> >> + }
> >> +
> >> + ret = ps8640_bridge_unmute(ps_bridge);
> >> + if (ret)
> >> + DRM_ERROR("failed to enable unmutevideo: %d\n", ret);
> >
> > failed to unmute? Or failed to enable?
> >
>
> failed to unmute sound more clear to me.
I may be wrong, but I have the feeling that the functions
"mute/unmute" video/display, actually... And that the function naming
is strange...
You could just try to remove the calls, as there is no audio on the
board you have (elm), so if video still works, maybe this is actually
audio ,-)
Thanks,
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Boichat <drinkcat@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Ulrich Hecht <uli@fpond.eu>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jitao Shi <jitao.shi@mediatek.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
lkml <linux-kernel@vger.kernel.org>,
Daniel Kurtz <djkurtz@chromium.org>,
Andrzej Hajda <a.hajda@samsung.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Collabora Kernel ML <kernel@collabora.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Mon, 23 Dec 2019 17:14:41 +0800 [thread overview]
Message-ID: <CANMq1KA4mp648p1LicOzAyra6tdgN2qdDY=N0XyDYhgt6BP26w@mail.gmail.com> (raw)
In-Reply-To: <05db638b-02a6-0e3a-43ed-44a0a1458d87@collabora.com>
On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Nicolas,
>
> Many thanks for you review. Just preparing a new version with your comments
> addressed.
>
> On 20/12/19 9:44, Nicolas Boichat wrote:
> > On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra
> > <enric.balletbo@collabora.com> wrote:
> >>
> >> From: Jitao Shi <jitao.shi@mediatek.com>
> >>
> >> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
> >>
> >> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> >> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> >> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >> [uli: followed API changes, removed FW update feature]
> >> Signed-off-by: Ulrich Hecht <uli@fpond.eu>
> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >> ---
> [snip]
> >> + ret = i2c_smbus_write_byte_data(client, PAGE2_MCS_EN,
> >> + status & ~MCS_EN);
> >> + if (ret < 0) {
> >> + DRM_ERROR("failed write PAGE2_MCS_EN: %d\n", ret);
> >> + goto err_regulators_disable;
> >> + }
> >> +
> >> + ret = ps8640_bridge_unmute(ps_bridge);
> >> + if (ret)
> >> + DRM_ERROR("failed to enable unmutevideo: %d\n", ret);
> >
> > failed to unmute? Or failed to enable?
> >
>
> failed to unmute sound more clear to me.
I may be wrong, but I have the feeling that the functions
"mute/unmute" video/display, actually... And that the function naming
is strange...
You could just try to remove the calls, as there is no audio on the
board you have (elm), so if video still works, maybe this is actually
audio ,-)
Thanks,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Boichat <drinkcat@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Ulrich Hecht <uli@fpond.eu>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jitao Shi <jitao.shi@mediatek.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
lkml <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
dri-devel@lists.freedesktop.org,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Collabora Kernel ML <kernel@collabora.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Mon, 23 Dec 2019 17:14:41 +0800 [thread overview]
Message-ID: <CANMq1KA4mp648p1LicOzAyra6tdgN2qdDY=N0XyDYhgt6BP26w@mail.gmail.com> (raw)
In-Reply-To: <05db638b-02a6-0e3a-43ed-44a0a1458d87@collabora.com>
On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Nicolas,
>
> Many thanks for you review. Just preparing a new version with your comments
> addressed.
>
> On 20/12/19 9:44, Nicolas Boichat wrote:
> > On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra
> > <enric.balletbo@collabora.com> wrote:
> >>
> >> From: Jitao Shi <jitao.shi@mediatek.com>
> >>
> >> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
> >>
> >> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> >> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> >> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >> [uli: followed API changes, removed FW update feature]
> >> Signed-off-by: Ulrich Hecht <uli@fpond.eu>
> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >> ---
> [snip]
> >> + ret = i2c_smbus_write_byte_data(client, PAGE2_MCS_EN,
> >> + status & ~MCS_EN);
> >> + if (ret < 0) {
> >> + DRM_ERROR("failed write PAGE2_MCS_EN: %d\n", ret);
> >> + goto err_regulators_disable;
> >> + }
> >> +
> >> + ret = ps8640_bridge_unmute(ps_bridge);
> >> + if (ret)
> >> + DRM_ERROR("failed to enable unmutevideo: %d\n", ret);
> >
> > failed to unmute? Or failed to enable?
> >
>
> failed to unmute sound more clear to me.
I may be wrong, but I have the feeling that the functions
"mute/unmute" video/display, actually... And that the function naming
is strange...
You could just try to remove the calls, as there is no audio on the
board you have (elm), so if video still works, maybe this is actually
audio ,-)
Thanks,
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-23 9:14 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 8:17 [PATCH v22 0/2] drm/bridge: PS8640 MIPI-to-eDP bridge Enric Balletbo i Serra
2019-12-20 8:17 ` Enric Balletbo i Serra
2019-12-20 8:17 ` Enric Balletbo i Serra
2019-12-20 8:17 ` Enric Balletbo i Serra
2019-12-20 8:17 ` [PATCH v22 1/2] Documentation: bridge: Add documentation for ps8640 DT properties Enric Balletbo i Serra
2019-12-20 8:17 ` Enric Balletbo i Serra
2019-12-20 8:17 ` Enric Balletbo i Serra
2019-12-20 8:17 ` Enric Balletbo i Serra
2019-12-20 8:17 ` [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Enric Balletbo i Serra
2019-12-20 8:17 ` Enric Balletbo i Serra
2019-12-20 8:17 ` Enric Balletbo i Serra
2019-12-20 8:17 ` Enric Balletbo i Serra
2019-12-20 8:44 ` Nicolas Boichat
2019-12-20 8:44 ` Nicolas Boichat
2019-12-20 8:44 ` Nicolas Boichat
2019-12-20 8:44 ` Nicolas Boichat
2019-12-23 7:09 ` Enric Balletbo i Serra
2019-12-23 7:09 ` Enric Balletbo i Serra
2019-12-23 7:09 ` Enric Balletbo i Serra
2019-12-23 7:09 ` Enric Balletbo i Serra
2019-12-23 9:14 ` Nicolas Boichat [this message]
2019-12-23 9:14 ` Nicolas Boichat
2019-12-23 9:14 ` Nicolas Boichat
2019-12-23 9:14 ` Nicolas Boichat
2019-12-23 14:27 ` Enric Balletbo i Serra
2019-12-23 14:27 ` Enric Balletbo i Serra
2019-12-23 14:27 ` Enric Balletbo i Serra
2019-12-23 14:27 ` Enric Balletbo i Serra
2019-12-20 8:55 ` Hsin-Yi Wang
2019-12-20 8:55 ` Hsin-Yi Wang
2019-12-20 8:55 ` Hsin-Yi Wang
2019-12-20 8:55 ` Hsin-Yi Wang
2019-12-23 14:35 [PATCH v22 0/2] drm/bridge: PS8640 MIPI-to-eDP bridge Enric Balletbo i Serra
2019-12-23 14:35 ` [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Enric Balletbo i Serra
2019-12-23 14:35 ` Enric Balletbo i Serra
2019-12-23 14:35 ` Enric Balletbo i Serra
2019-12-23 14:35 ` Enric Balletbo i Serra
2019-12-23 15:51 ` Enric Balletbo i Serra
2019-12-23 15:51 ` Enric Balletbo i Serra
2019-12-23 15:51 ` Enric Balletbo i Serra
2019-12-23 15:51 ` Enric Balletbo i Serra
2019-12-26 16:38 ` Ezequiel Garcia
2019-12-26 16:38 ` Ezequiel Garcia
2019-12-26 16:38 ` Ezequiel Garcia
2019-12-26 16:38 ` Ezequiel Garcia
2019-12-27 10:08 ` Enric Balletbo i Serra
2019-12-27 10:08 ` Enric Balletbo i Serra
2019-12-27 10:08 ` Enric Balletbo i Serra
2019-12-27 10:08 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANMq1KA4mp648p1LicOzAyra6tdgN2qdDY=N0XyDYhgt6BP26w@mail.gmail.com' \
--to=drinkcat@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@siol.net \
--cc=jitao.shi@mediatek.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.