From: Milosz Tanski <milosz@adfin.com>
To: David Howells <dhowells@redhat.com>
Cc: Hongyi Jia <jiayisuse@gmail.com>,
ceph-devel <ceph-devel@vger.kernel.org>,
Sage Weil <sage@inktank.com>,
"Yan, Zheng" <zheng.z.yan@intel.com>,
"linux-cachefs@redhat.com" <linux-cachefs@redhat.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] new fscache interface to check cache consistency
Date: Wed, 4 Sep 2013 18:02:57 -0400 [thread overview]
Message-ID: <CANP1eJEK-_C9XhrzXByQtUTGzq3qikNjT7feCispajSGw8zNJQ@mail.gmail.com> (raw)
In-Reply-To: <CANP1eJFmMNEr9orps6Dd983sp6QmMfBsMT+dY1CvZ+u0nXKf4w@mail.gmail.com>
David,
Is there anyway I can call you at (at your desk) during EST hours. I'd
like to talk this part through since I think we're going a bit in
circles. I'd like to get this fixed so we can submit the fscache for
Ceph code for the upstream kernel in the merge window.
Best,
-- Milosz
On Wed, Sep 4, 2013 at 3:41 PM, Milosz Tanski <milosz@adfin.com> wrote:
> On Wed, Sep 4, 2013 at 2:13 PM, David Howells <dhowells@redhat.com> wrote:
>> Milosz Tanski <milosz@adfin.com> wrote:
>>
>>> Is it as simple as stick a mutex at the top of the
>>> __fscache_check_consistency function before we try to find the object?
>>
>> You can lock a mutex in a function, but where are you actually going to place
>> the mutex struct? And what other code is going to take it? To do this, you'd
>> have to place the mutex struct in fscache_cookie. The problem is that you
>> have to protect the pointer from fscache_cookie to fscache_object - so placing
>> the mutex in fscache_object doesn't help.
>
> David,
>
> I meant lock cookie->lock inside of __fscache_check_consistency in the
> beginning of the function. I don't see the need to push this into the
> netfs code.
>
> - Milosz
prev parent reply other threads:[~2013-09-04 22:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 21:26 [PATCHv4 0/5] ceph: persistent caching with fscache Milosz Tanski
2013-08-21 21:29 ` [PATCH 1/5] new cachefiles interface to check cache consistency Hongyi Jia
2013-08-21 21:29 ` [PATCH 2/5] new fscache " Hongyi Jia
2013-08-21 21:29 ` [PATCH 3/5] ceph: use fscache as a local presisent cache Milosz Tanski
2013-08-21 21:29 ` Milosz Tanski
2013-08-27 1:05 ` Sage Weil
2013-08-21 21:30 ` [PATCH 4/5] fscache: netfs function for cleanup post readpages Milosz Tanski
2013-09-03 17:24 ` Milosz Tanski
2013-08-21 21:30 ` [PATCH 5/5] ceph: clean PgPrivate2 on returning from readpages Milosz Tanski
2013-08-22 5:05 ` [PATCHv4 0/5] ceph: persistent caching with fscache Sage Weil
2013-08-22 5:05 ` Sage Weil
2013-08-22 12:58 ` Milosz Tanski
2013-08-22 12:58 ` Milosz Tanski
2013-09-04 15:49 ` David Howells
2013-09-04 15:49 ` David Howells
2013-09-04 15:54 ` Sage Weil
2013-09-04 15:54 ` Sage Weil
2013-09-04 16:25 ` Sage Weil
2013-09-04 16:25 ` Sage Weil
2013-09-05 12:34 ` David Howells
2013-09-04 16:24 ` [PATCH 2/5] new fscache interface to check cache consistency David Howells
2013-09-04 16:24 ` David Howells
2013-09-04 16:48 ` Milosz Tanski
2013-09-04 17:26 ` David Howells
2013-09-04 17:26 ` David Howells
2013-09-04 18:04 ` Milosz Tanski
2013-09-04 18:13 ` David Howells
2013-09-04 18:13 ` David Howells
2013-09-04 19:41 ` Milosz Tanski
2013-09-04 22:02 ` Milosz Tanski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANP1eJEK-_C9XhrzXByQtUTGzq3qikNjT7feCispajSGw8zNJQ@mail.gmail.com \
--to=milosz@adfin.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=jiayisuse@gmail.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@inktank.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.