From: David Howells <dhowells@redhat.com>
To: Milosz Tanski <milosz@adfin.com>
Cc: dhowells@redhat.com, Hongyi Jia <jiayisuse@gmail.com>,
ceph-devel <ceph-devel@vger.kernel.org>,
Sage Weil <sage@inktank.com>,
"Yan, Zheng" <zheng.z.yan@intel.com>,
"linux-cachefs@redhat.com" <linux-cachefs@redhat.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] new fscache interface to check cache consistency
Date: Wed, 04 Sep 2013 18:26:10 +0100 [thread overview]
Message-ID: <18284.1378315570@warthog.procyon.org.uk> (raw)
In-Reply-To: <CANP1eJFKGD_h6rcWMWpxp3yOD+rz6p2P0B+2CTcy1taDwM9rdg@mail.gmail.com>
Milosz Tanski <milosz@adfin.com> wrote:
> If the cache is withdrawn and we're starting anew I would consider
> that to okay. I would consider an empty page cache for a cookie to be
> consistent since there's nothing stale that I can read. Unless there's
> another synchronization issue that I'm missing in fscache.
The problem is that the fscache_object struct may be deallocated whilst you're
using it.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Milosz Tanski <milosz@adfin.com>
Cc: Sage Weil <sage@inktank.com>,
linux-kernel@vger.kernel.org,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-cachefs@redhat.com" <linux-cachefs@redhat.com>,
"Yan, Zheng" <zheng.z.yan@intel.com>,
ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH 2/5] new fscache interface to check cache consistency
Date: Wed, 04 Sep 2013 18:26:10 +0100 [thread overview]
Message-ID: <18284.1378315570@warthog.procyon.org.uk> (raw)
In-Reply-To: <CANP1eJFKGD_h6rcWMWpxp3yOD+rz6p2P0B+2CTcy1taDwM9rdg@mail.gmail.com>
Milosz Tanski <milosz@adfin.com> wrote:
> If the cache is withdrawn and we're starting anew I would consider
> that to okay. I would consider an empty page cache for a cookie to be
> consistent since there's nothing stale that I can read. Unless there's
> another synchronization issue that I'm missing in fscache.
The problem is that the fscache_object struct may be deallocated whilst you're
using it.
David
next prev parent reply other threads:[~2013-09-04 17:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 21:26 [PATCHv4 0/5] ceph: persistent caching with fscache Milosz Tanski
2013-08-21 21:29 ` [PATCH 1/5] new cachefiles interface to check cache consistency Hongyi Jia
2013-08-21 21:29 ` [PATCH 2/5] new fscache " Hongyi Jia
2013-08-21 21:29 ` [PATCH 3/5] ceph: use fscache as a local presisent cache Milosz Tanski
2013-08-21 21:29 ` Milosz Tanski
2013-08-27 1:05 ` Sage Weil
2013-08-21 21:30 ` [PATCH 4/5] fscache: netfs function for cleanup post readpages Milosz Tanski
2013-09-03 17:24 ` Milosz Tanski
2013-08-21 21:30 ` [PATCH 5/5] ceph: clean PgPrivate2 on returning from readpages Milosz Tanski
2013-08-22 5:05 ` [PATCHv4 0/5] ceph: persistent caching with fscache Sage Weil
2013-08-22 5:05 ` Sage Weil
2013-08-22 12:58 ` Milosz Tanski
2013-08-22 12:58 ` Milosz Tanski
2013-09-04 15:49 ` David Howells
2013-09-04 15:49 ` David Howells
2013-09-04 15:54 ` Sage Weil
2013-09-04 15:54 ` Sage Weil
2013-09-04 16:25 ` Sage Weil
2013-09-04 16:25 ` Sage Weil
2013-09-05 12:34 ` David Howells
2013-09-04 16:24 ` [PATCH 2/5] new fscache interface to check cache consistency David Howells
2013-09-04 16:24 ` David Howells
2013-09-04 16:48 ` Milosz Tanski
2013-09-04 17:26 ` David Howells [this message]
2013-09-04 17:26 ` David Howells
2013-09-04 18:04 ` Milosz Tanski
2013-09-04 18:13 ` David Howells
2013-09-04 18:13 ` David Howells
2013-09-04 19:41 ` Milosz Tanski
2013-09-04 22:02 ` Milosz Tanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18284.1378315570@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jiayisuse@gmail.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milosz@adfin.com \
--cc=sage@inktank.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.