From: Alan Tull <atull@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org,
Michal Simek <michal.simek@xilinx.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] fpga: manager: change api, don't use drvdata
Date: Fri, 27 Apr 2018 18:30:42 -0500 [thread overview]
Message-ID: <CANk1AXTZhCA78eX9j5dg1VeNyg8G4+hsiSgG_CYpZObjJw+wfw@mail.gmail.com> (raw)
In-Reply-To: <152cb232-ea4d-292b-8b60-8bdc1732dc23@gmail.com>
On Fri, Apr 27, 2018 at 1:26 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 04/26/2018 06:26 PM, Moritz Fischer wrote:
>> From: Alan Tull <atull@kernel.org>
>>
>> Change fpga_mgr_register to not set or use drvdata. This supports
>> the case where a PCIe device has more than one manager.
>>
>> Add fpga_mgr_create/free functions. Change fpga_mgr_register and
>> fpga_mgr_unregister functions to take the mgr struct as their only
>> parameter.
>>
>> struct fpga_manager *fpga_mgr_create(struct device *dev,
>> const char *name,
>> const struct fpga_manager_ops *mops,
>> void *priv);
>> void fpga_mgr_free(struct fpga_manager *mgr);
>> int fpga_mgr_register(struct fpga_manager *mgr);
>> void fpga_mgr_unregister(struct fpga_manager *mgr);
>>
>> Update the drivers that call fpga_mgr_register with the new API.
>
> Apologies for chiming in so late, this commit does not make it clear
> that fpga_mgr_unregister() now also free the 'mgr' argument by calling
> fpga_mgr_free(), this is kind of detail, but an API should make that
> clear IMHO.
If people follow the usage information, in
Documentation/fpga/fpga-mgr.txt, they'll do the right thing. But I
can add a patch that clarifies the description of fpga_mgr_unregister
in fpga-mgr.c that it "unregisters and frees" the manager.
>
> Thanks
> --
> Florian
WARNING: multiple messages have this Message-ID (diff)
From: Alan Tull <atull@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org,
Michal Simek <michal.simek@xilinx.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] fpga: manager: change api, don't use drvdata
Date: Fri, 27 Apr 2018 18:30:42 -0500 [thread overview]
Message-ID: <CANk1AXTZhCA78eX9j5dg1VeNyg8G4+hsiSgG_CYpZObjJw+wfw@mail.gmail.com> (raw)
In-Reply-To: <152cb232-ea4d-292b-8b60-8bdc1732dc23@gmail.com>
On Fri, Apr 27, 2018 at 1:26 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 04/26/2018 06:26 PM, Moritz Fischer wrote:
>> From: Alan Tull <atull@kernel.org>
>>
>> Change fpga_mgr_register to not set or use drvdata. This supports
>> the case where a PCIe device has more than one manager.
>>
>> Add fpga_mgr_create/free functions. Change fpga_mgr_register and
>> fpga_mgr_unregister functions to take the mgr struct as their only
>> parameter.
>>
>> struct fpga_manager *fpga_mgr_create(struct device *dev,
>> const char *name,
>> const struct fpga_manager_ops *mops,
>> void *priv);
>> void fpga_mgr_free(struct fpga_manager *mgr);
>> int fpga_mgr_register(struct fpga_manager *mgr);
>> void fpga_mgr_unregister(struct fpga_manager *mgr);
>>
>> Update the drivers that call fpga_mgr_register with the new API.
>
> Apologies for chiming in so late, this commit does not make it clear
> that fpga_mgr_unregister() now also free the 'mgr' argument by calling
> fpga_mgr_free(), this is kind of detail, but an API should make that
> clear IMHO.
If people follow the usage information, in
Documentation/fpga/fpga-mgr.txt, they'll do the right thing. But I
can add a patch that clarifies the description of fpga_mgr_unregister
in fpga-mgr.c that it "unregisters and frees" the manager.
>
> Thanks
> --
> Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: atull@kernel.org (Alan Tull)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] fpga: manager: change api, don't use drvdata
Date: Fri, 27 Apr 2018 18:30:42 -0500 [thread overview]
Message-ID: <CANk1AXTZhCA78eX9j5dg1VeNyg8G4+hsiSgG_CYpZObjJw+wfw@mail.gmail.com> (raw)
In-Reply-To: <152cb232-ea4d-292b-8b60-8bdc1732dc23@gmail.com>
On Fri, Apr 27, 2018 at 1:26 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 04/26/2018 06:26 PM, Moritz Fischer wrote:
>> From: Alan Tull <atull@kernel.org>
>>
>> Change fpga_mgr_register to not set or use drvdata. This supports
>> the case where a PCIe device has more than one manager.
>>
>> Add fpga_mgr_create/free functions. Change fpga_mgr_register and
>> fpga_mgr_unregister functions to take the mgr struct as their only
>> parameter.
>>
>> struct fpga_manager *fpga_mgr_create(struct device *dev,
>> const char *name,
>> const struct fpga_manager_ops *mops,
>> void *priv);
>> void fpga_mgr_free(struct fpga_manager *mgr);
>> int fpga_mgr_register(struct fpga_manager *mgr);
>> void fpga_mgr_unregister(struct fpga_manager *mgr);
>>
>> Update the drivers that call fpga_mgr_register with the new API.
>
> Apologies for chiming in so late, this commit does not make it clear
> that fpga_mgr_unregister() now also free the 'mgr' argument by calling
> fpga_mgr_free(), this is kind of detail, but an API should make that
> clear IMHO.
If people follow the usage information, in
Documentation/fpga/fpga-mgr.txt, they'll do the right thing. But I
can add a patch that clarifies the description of fpga_mgr_unregister
in fpga-mgr.c that it "unregisters and frees" the manager.
>
> Thanks
> --
> Florian
next prev parent reply other threads:[~2018-04-27 23:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 1:26 [PATCH 0/4] FPGA Manager Patches for 4.18 Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
2018-04-27 1:26 ` [PATCH 1/4] fpga: region: don't use drvdata in common fpga code Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
2018-04-27 1:26 ` [PATCH 2/4] fpga: manager: change api, don't use drvdata Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
2018-04-27 18:26 ` Florian Fainelli
2018-04-27 18:26 ` Florian Fainelli
2018-04-27 18:26 ` Florian Fainelli
2018-04-27 23:30 ` Alan Tull [this message]
2018-04-27 23:30 ` Alan Tull
2018-04-27 23:30 ` Alan Tull
2018-04-27 23:38 ` Florian Fainelli
2018-04-27 23:38 ` Florian Fainelli
2018-04-27 23:38 ` Florian Fainelli
2018-04-27 1:26 ` [PATCH 3/4] fpga: bridge: " Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
2018-04-27 1:26 ` [PATCH 4/4] fpga: region: change api, add fpga_region_create/free Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
2018-04-27 1:26 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANk1AXTZhCA78eX9j5dg1VeNyg8G4+hsiSgG_CYpZObjJw+wfw@mail.gmail.com \
--to=atull@kernel.org \
--cc=corbet@lwn.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.