All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralph Siemsen <ralph.siemsen@linaro.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH 4/4] clk: renesas: r9a06g032: improve clock tables
Date: Wed, 1 Mar 2023 16:26:54 -0500	[thread overview]
Message-ID: <CANp-EDYuX_zi=XG_AhLP0tH9mnQzTK0GiyTzSQEkPMUo5JC28Q@mail.gmail.com> (raw)
In-Reply-To: <CANp-EDb3XPEHya8igTh9fnyQW9yUs2MM6tCD9Pa3DCSwNZGvVg@mail.gmail.com>

On Wed, Mar 1, 2023 at 2:19 PM Ralph Siemsen <ralph.siemsen@linaro.org> wrote:
>
> > > The bulk of this patch converts the clock table to use struct regbit,
> > > making use of the RB() helper macro. The conversion was automated by
> > > script, and as a further verification, the compiled binary of the table
> > > was compared before/after the change (with objdump -D).
> >
> > I will trust your tool on the conversion.
>
> I'm going to check again using objdump, just to make sure nothing slips through.

So naturally, this test uncovered a difference. It seems that gcc
orders bitfields differently on x86 and ARM. So the tables did not
match exactly with the old packed u16 fomat.

It is a harmless difference, but it can easily be eliminated, by
swapping the fields within 'struct regbit'. Now the tables are really
identical.

Patch v2 to follow shortly.

Ralph

      reply	other threads:[~2023-03-01 21:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 18:39 [PATCH 0/4] Renesas r9a06g032 clock table improvements Ralph Siemsen
2023-02-27 18:39 ` [PATCH 1/4] clk: renesas: r9a06g032: improve readability Ralph Siemsen
2023-02-27 18:39 ` [PATCH 2/4] clk: renesas: r9a06g032: drop unused fields Ralph Siemsen
2023-03-01 11:13   ` Miquel Raynal
2023-02-27 18:39 ` [PATCH 3/4] clk: renesas: r9a06g032: document structs Ralph Siemsen
2023-03-01 11:24   ` Miquel Raynal
2023-03-01 19:03     ` Ralph Siemsen
2023-02-27 18:39 ` [PATCH 4/4] clk: renesas: r9a06g032: improve clock tables Ralph Siemsen
2023-03-01 12:58   ` Miquel Raynal
2023-03-01 19:19     ` Ralph Siemsen
2023-03-01 21:26       ` Ralph Siemsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANp-EDYuX_zi=XG_AhLP0tH9mnQzTK0GiyTzSQEkPMUo5JC28Q@mail.gmail.com' \
    --to=ralph.siemsen@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.