From: Magnus Damm <magnus.damm@gmail.com> To: Ian Molton <ian.molton@codethink.co.uk> Cc: linux-i2c@vger.kernel.org, Grant Likely <grant.likely@linaro.org>, Rob Herring <rob.herring@calxeda.com>, SH-Linux <linux-sh@vger.kernel.org> Subject: Re: [PATCH] EMMA: Add em i2c driver Date: Thu, 29 Aug 2013 05:33:11 +0000 [thread overview] Message-ID: <CANqRtoRK+Ur=87-me7CpP+s9SO5g0ZVZSEOrqwDf4HFfjZZmZA@mail.gmail.com> (raw) In-Reply-To: <1377688911-10911-1-git-send-email-ian.molton@codethink.co.uk> Hi Ian, Thanks for submitting this patch. I have one comment only, please see below. On Wed, Aug 28, 2013 at 8:21 PM, Ian Molton <ian.molton@codethink.co.uk> wrote: > Signed-off-by: Ian Molton <ian.molton@codethink.co.uk> > --- > drivers/i2c/busses/Kconfig | 10 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-em.c | 536 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 547 insertions(+) > create mode 100644 drivers/i2c/busses/i2c-em.c > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index dc6dea6..e5cda34 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -777,6 +777,16 @@ config I2C_RCAR > This driver can also be built as a module. If so, the module > will be called i2c-rcar. > > +config I2C_EM > + tristate "EMMA Mobile series I2C adapter" > + depends on I2C && HAVE_CLK > + help > + If you say yes to this option, support will be included for the > + I2C interface on the Renesas Electronics EM/EV of processors. > + > + This driver can also be built as a module. If so, the module > + will be called i2c-em > + > comment "External I2C/SMBus adapter drivers" > > config I2C_DIOLAN_U2C > diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile > index d00997f..f7022ab 100644 > --- a/drivers/i2c/busses/Makefile > +++ b/drivers/i2c/busses/Makefile > @@ -76,6 +76,7 @@ obj-$(CONFIG_I2C_OCTEON) += i2c-octeon.o > obj-$(CONFIG_I2C_XILINX) += i2c-xiic.o > obj-$(CONFIG_I2C_XLR) += i2c-xlr.o > obj-$(CONFIG_I2C_RCAR) += i2c-rcar.o > +obj-$(CONFIG_I2C_EM) += i2c-em.o > > # External I2C/SMBus adapter drivers > obj-$(CONFIG_I2C_DIOLAN_U2C) += i2c-diolan-u2c.o > diff --git a/drivers/i2c/busses/i2c-em.c b/drivers/i2c/busses/i2c-em.c > new file mode 100644 > index 0000000..b54a983 > --- /dev/null > +++ b/drivers/i2c/busses/i2c-em.c > +static int em_i2c_probe(struct platform_device *pdev) > +{ > + struct em_i2c_device *i2c_dev; > + struct resource *r; > + int ret; > + > + i2c_dev = devm_kzalloc(&pdev->dev, sizeof(struct em_i2c_device), > + GFP_KERNEL); > + > + r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + i2c_dev->membase = devm_ioremap_resource(&pdev->dev, r); > + if (IS_ERR(i2c_dev->membase)) > + return PTR_ERR(i2c_dev->membase); > + > + strlcpy(i2c_dev->adap.name, "em_i2c", sizeof(i2c_dev->adap.name)); > + > + i2c_dev->clk = devm_clk_get(&pdev->dev, NULL); > + if (!IS_ERR(i2c_dev->clk)) > + clk_prepare(i2c_dev->clk); > + > + i2c_dev->sclk = devm_clk_get(&pdev->dev, "sclk"); > + if (!IS_ERR(i2c_dev->sclk)) > + clk_prepare(i2c_dev->sclk); > + > + i2c_dev->irq = platform_get_irq(pdev, 0); > + i2c_dev->adap.timeout = msecs_to_jiffies(100); > + i2c_dev->adap.dev.parent = &pdev->dev; > + i2c_dev->adap.algo = &em_i2c_algo; > + i2c_dev->adap.owner = THIS_MODULE; > + i2c_dev->adap.nr = pdev->id; > + i2c_dev->adap.dev.of_node = pdev->dev.of_node; > + > + init_waitqueue_head(&i2c_dev->i2c_wait); > + > + spin_lock_init(&i2c_dev->irq_lock); > + > + i2c_dev->flags = I2C_BIT_DFC0; > +#ifdef CONFIG_I2C_EMXX_SMC > + i2c_dev->flags |= I2C_BIT_SMC0; > +#endif I think CONFIG_I2C_EMXX_SMC probably want to be reworked somehow. I assume it's an old left over in this particular case. But if you need to have some special configuration method then please consider some other way than CONFIG_ variables that are not very compatible with future multi-platform kernel images. Cheers, / magnus
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com> To: Ian Molton <ian.molton@codethink.co.uk> Cc: linux-i2c@vger.kernel.org, Grant Likely <grant.likely@linaro.org>, Rob Herring <rob.herring@calxeda.com>, SH-Linux <linux-sh@vger.kernel.org> Subject: Re: [PATCH] EMMA: Add em i2c driver Date: Thu, 29 Aug 2013 14:33:11 +0900 [thread overview] Message-ID: <CANqRtoRK+Ur=87-me7CpP+s9SO5g0ZVZSEOrqwDf4HFfjZZmZA@mail.gmail.com> (raw) In-Reply-To: <1377688911-10911-1-git-send-email-ian.molton@codethink.co.uk> Hi Ian, Thanks for submitting this patch. I have one comment only, please see below. On Wed, Aug 28, 2013 at 8:21 PM, Ian Molton <ian.molton@codethink.co.uk> wrote: > Signed-off-by: Ian Molton <ian.molton@codethink.co.uk> > --- > drivers/i2c/busses/Kconfig | 10 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-em.c | 536 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 547 insertions(+) > create mode 100644 drivers/i2c/busses/i2c-em.c > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index dc6dea6..e5cda34 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -777,6 +777,16 @@ config I2C_RCAR > This driver can also be built as a module. If so, the module > will be called i2c-rcar. > > +config I2C_EM > + tristate "EMMA Mobile series I2C adapter" > + depends on I2C && HAVE_CLK > + help > + If you say yes to this option, support will be included for the > + I2C interface on the Renesas Electronics EM/EV of processors. > + > + This driver can also be built as a module. If so, the module > + will be called i2c-em > + > comment "External I2C/SMBus adapter drivers" > > config I2C_DIOLAN_U2C > diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile > index d00997f..f7022ab 100644 > --- a/drivers/i2c/busses/Makefile > +++ b/drivers/i2c/busses/Makefile > @@ -76,6 +76,7 @@ obj-$(CONFIG_I2C_OCTEON) += i2c-octeon.o > obj-$(CONFIG_I2C_XILINX) += i2c-xiic.o > obj-$(CONFIG_I2C_XLR) += i2c-xlr.o > obj-$(CONFIG_I2C_RCAR) += i2c-rcar.o > +obj-$(CONFIG_I2C_EM) += i2c-em.o > > # External I2C/SMBus adapter drivers > obj-$(CONFIG_I2C_DIOLAN_U2C) += i2c-diolan-u2c.o > diff --git a/drivers/i2c/busses/i2c-em.c b/drivers/i2c/busses/i2c-em.c > new file mode 100644 > index 0000000..b54a983 > --- /dev/null > +++ b/drivers/i2c/busses/i2c-em.c > +static int em_i2c_probe(struct platform_device *pdev) > +{ > + struct em_i2c_device *i2c_dev; > + struct resource *r; > + int ret; > + > + i2c_dev = devm_kzalloc(&pdev->dev, sizeof(struct em_i2c_device), > + GFP_KERNEL); > + > + r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + i2c_dev->membase = devm_ioremap_resource(&pdev->dev, r); > + if (IS_ERR(i2c_dev->membase)) > + return PTR_ERR(i2c_dev->membase); > + > + strlcpy(i2c_dev->adap.name, "em_i2c", sizeof(i2c_dev->adap.name)); > + > + i2c_dev->clk = devm_clk_get(&pdev->dev, NULL); > + if (!IS_ERR(i2c_dev->clk)) > + clk_prepare(i2c_dev->clk); > + > + i2c_dev->sclk = devm_clk_get(&pdev->dev, "sclk"); > + if (!IS_ERR(i2c_dev->sclk)) > + clk_prepare(i2c_dev->sclk); > + > + i2c_dev->irq = platform_get_irq(pdev, 0); > + i2c_dev->adap.timeout = msecs_to_jiffies(100); > + i2c_dev->adap.dev.parent = &pdev->dev; > + i2c_dev->adap.algo = &em_i2c_algo; > + i2c_dev->adap.owner = THIS_MODULE; > + i2c_dev->adap.nr = pdev->id; > + i2c_dev->adap.dev.of_node = pdev->dev.of_node; > + > + init_waitqueue_head(&i2c_dev->i2c_wait); > + > + spin_lock_init(&i2c_dev->irq_lock); > + > + i2c_dev->flags = I2C_BIT_DFC0; > +#ifdef CONFIG_I2C_EMXX_SMC > + i2c_dev->flags |= I2C_BIT_SMC0; > +#endif I think CONFIG_I2C_EMXX_SMC probably want to be reworked somehow. I assume it's an old left over in this particular case. But if you need to have some special configuration method then please consider some other way than CONFIG_ variables that are not very compatible with future multi-platform kernel images. Cheers, / magnus
next parent reply other threads:[~2013-08-29 5:33 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1377688911-10911-1-git-send-email-ian.molton@codethink.co.uk> 2013-08-29 5:33 ` Magnus Damm [this message] 2013-08-29 5:33 ` [PATCH] EMMA: Add em i2c driver Magnus Damm [not found] ` <CANqRtoRK+Ur=87-me7CpP+s9SO5g0ZVZSEOrqwDf4HFfjZZmZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-08-29 10:24 ` Ben Dooks 2013-08-29 10:24 ` Ben Dooks 2013-08-29 13:35 ` Ian Molton 2013-08-29 13:35 ` Ian Molton 2013-09-03 11:30 ` EMMA I2C driver Ian Molton 2013-09-03 11:30 ` Ian Molton 2013-09-03 11:30 ` [PATCH] EMMA: Add em i2c driver Ian Molton 2013-09-03 11:30 ` Ian Molton 2013-09-03 12:56 ` Ben Dooks 2013-09-03 12:56 ` Ben Dooks [not found] ` <5225DC8E.7070001-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2013-09-04 12:06 ` Thomas Petazzoni 2013-09-04 12:06 ` Thomas Petazzoni [not found] ` <1377688911-10911-1-git-send-email-ian.molton-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2013-09-03 16:49 ` [Patch v3]EMMA I2C driver Ian Molton 2013-09-03 16:49 ` Ian Molton 2013-09-03 16:49 ` [PATCH 1/2] I2C: EMMA Mobile I2C master driver Ian Molton 2013-09-03 16:49 ` Ian Molton 2013-09-05 6:04 ` Simon Horman 2013-09-05 6:04 ` Simon Horman 2013-09-25 4:45 ` Simon Horman 2013-09-25 4:45 ` Simon Horman 2013-12-06 20:52 ` Ian Molton 2013-12-11 2:09 ` Simon Horman 2013-12-11 2:09 ` Simon Horman 2013-12-11 11:59 ` Wolfram Sang 2013-12-11 11:59 ` Wolfram Sang 2014-01-08 10:33 ` Ian Molton [not found] ` <1378226969-18722-2-git-send-email-ian.molton-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2014-02-18 17:38 ` Wolfram Sang 2014-02-18 17:38 ` Wolfram Sang 2014-06-17 9:57 ` Wolfram Sang 2014-06-17 9:57 ` Wolfram Sang 2014-07-18 15:45 ` Wolfram Sang 2014-07-18 15:45 ` Wolfram Sang 2014-08-22 2:57 ` Wolfram Sang 2014-08-22 2:57 ` Wolfram Sang 2013-08-28 14:04 [PATCH] EMMA: Add em i2c driver y 2013-08-28 14:10 ` Ben Dooks 2013-08-28 14:10 ` Ben Dooks 2013-08-28 15:08 ` Ian Molton -- strict thread matches above, loose matches on Subject: below -- 2013-08-28 14:04 y 2013-08-28 14:04 y
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CANqRtoRK+Ur=87-me7CpP+s9SO5g0ZVZSEOrqwDf4HFfjZZmZA@mail.gmail.com' \ --to=magnus.damm@gmail.com \ --cc=grant.likely@linaro.org \ --cc=ian.molton@codethink.co.uk \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=rob.herring@calxeda.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.