From: Magnus Damm <magnus.damm@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: shmobile: Koelsch: add Ether support
Date: Thu, 31 Oct 2013 08:10:03 +0000 [thread overview]
Message-ID: <CANqRtoTNJAnqavonOwtqe5_HDdPwK1-JAixNuz5z7ttQw-T64Q@mail.gmail.com> (raw)
In-Reply-To: <201310310219.58963.sergei.shtylyov@cogentembedded.com>
Hi Sergei,
On Thu, Oct 31, 2013 at 8:19 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Register Ether platform device and pin data on the Koelsch board.
> Register platform fixup for Micrel KSZ8041 PHY, just like on the Lager board.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> arch/arm/mach-shmobile/board-koelsch.c | 61 ++++++++++++++++++++++++++++++++-
> 1 file changed, 60 insertions(+), 1 deletion(-)
>
> Index: renesas/arch/arm/mach-shmobile/board-koelsch.c
> =================================> --- renesas.orig/arch/arm/mach-shmobile/board-koelsch.c
> +++ renesas/arch/arm/mach-shmobile/board-koelsch.c
> @@ -70,11 +87,29 @@ static const struct gpio_keys_platform_d
> .nbuttons = ARRAY_SIZE(gpio_buttons),
> };
>
> +static const struct pinctrl_map koelsch_pinctrl_map[] = {
> + /* Ether */
> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7791",
> + "eth_link", "eth"),
> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7791",
> + "eth_mdio", "eth"),
> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7791",
> + "eth_rmii", "eth"),
> +};
Once again we seem to be using r8a7790 when the actual SoC is r8a7791.
If you're going to go down the route of using the SoC name then please
use the correct one at least.
Cheers,
/ magnus
WARNING: multiple messages have this Message-ID (diff)
From: magnus.damm@gmail.com (Magnus Damm)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: shmobile: Koelsch: add Ether support
Date: Thu, 31 Oct 2013 17:10:03 +0900 [thread overview]
Message-ID: <CANqRtoTNJAnqavonOwtqe5_HDdPwK1-JAixNuz5z7ttQw-T64Q@mail.gmail.com> (raw)
In-Reply-To: <201310310219.58963.sergei.shtylyov@cogentembedded.com>
Hi Sergei,
On Thu, Oct 31, 2013 at 8:19 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Register Ether platform device and pin data on the Koelsch board.
> Register platform fixup for Micrel KSZ8041 PHY, just like on the Lager board.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> arch/arm/mach-shmobile/board-koelsch.c | 61 ++++++++++++++++++++++++++++++++-
> 1 file changed, 60 insertions(+), 1 deletion(-)
>
> Index: renesas/arch/arm/mach-shmobile/board-koelsch.c
> ===================================================================
> --- renesas.orig/arch/arm/mach-shmobile/board-koelsch.c
> +++ renesas/arch/arm/mach-shmobile/board-koelsch.c
> @@ -70,11 +87,29 @@ static const struct gpio_keys_platform_d
> .nbuttons = ARRAY_SIZE(gpio_buttons),
> };
>
> +static const struct pinctrl_map koelsch_pinctrl_map[] = {
> + /* Ether */
> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7791",
> + "eth_link", "eth"),
> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7791",
> + "eth_mdio", "eth"),
> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7790-ether", "pfc-r8a7791",
> + "eth_rmii", "eth"),
> +};
Once again we seem to be using r8a7790 when the actual SoC is r8a7791.
If you're going to go down the route of using the SoC name then please
use the correct one at least.
Cheers,
/ magnus
next prev parent reply other threads:[~2013-10-31 8:10 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 22:16 [PATCH 0/2] Add Ether support for R8A7791/Koelsch board Sergei Shtylyov
2013-10-30 23:16 ` Sergei Shtylyov
2013-10-30 22:18 ` [PATCH 1/2] ARM: shmobile: r8a7791: add Ether clock Sergei Shtylyov
2013-10-30 23:18 ` Sergei Shtylyov
2013-10-31 6:06 ` Simon Horman
2013-10-31 6:06 ` Simon Horman
2013-10-31 20:50 ` Sergei Shtylyov
2013-10-31 21:50 ` Sergei Shtylyov
2013-11-01 6:29 ` Simon Horman
2013-11-01 6:29 ` Simon Horman
2013-12-19 17:59 ` [PATCH 1/2] arm: shmobile: r8a7791: Add SATA clocks Valentine Barshak
2014-01-09 8:25 ` Simon Horman
2014-02-06 21:12 ` [PATCH 1/2] ARM: shmobile: r8a7791: add Ether DT support Sergei Shtylyov
2014-02-06 22:12 ` Sergei Shtylyov
2014-02-06 22:12 ` Sergei Shtylyov
2014-02-10 12:54 ` Ben Dooks
2014-02-10 12:54 ` Ben Dooks
2014-02-10 12:54 ` Ben Dooks
2014-02-10 13:24 ` Sergei Shtylyov
2014-02-10 13:24 ` Sergei Shtylyov
2014-02-10 13:24 ` Sergei Shtylyov
2014-05-29 11:05 ` [PATCH 1/2] arm: shmobile: r8a7791: add USB3.0 clocks to device tree Yoshihiro Shimoda
2014-05-29 11:05 ` Yoshihiro Shimoda
2014-05-29 11:05 ` Yoshihiro Shimoda
2013-10-30 22:20 ` [PATCH 2/2] ARM: shmobile: Koelsch: add Ether support Sergei Shtylyov
2013-10-30 23:19 ` Sergei Shtylyov
2013-10-31 5:02 ` Simon Horman
2013-10-31 5:02 ` Simon Horman
2013-10-31 20:25 ` Sergei Shtylyov
2013-10-31 21:24 ` Sergei Shtylyov
2013-10-31 8:06 ` Magnus Damm
2013-10-31 8:06 ` Magnus Damm
2013-10-31 18:03 ` Sergei Shtylyov
2013-10-31 19:03 ` Sergei Shtylyov
2013-12-09 18:58 ` Sergei Shtylyov
2013-12-09 19:57 ` Sergei Shtylyov
2013-12-09 21:14 ` Sergei Shtylyov
2013-12-09 22:14 ` Sergei Shtylyov
2013-12-18 20:23 ` Sergei Shtylyov
2013-12-18 21:23 ` Sergei Shtylyov
2013-10-31 8:10 ` Magnus Damm [this message]
2013-10-31 8:10 ` Magnus Damm
2013-10-31 18:47 ` Sergei Shtylyov
2013-10-31 19:46 ` Sergei Shtylyov
2013-12-19 17:59 ` [PATCH 2/2] arm: shmobile: koelsch: Add SATA support Valentine Barshak
2014-11-11 4:37 ` [PATCH 2/2] ARM: shmobile: koelsch: add Volume Ramp usage on comment Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANqRtoTNJAnqavonOwtqe5_HDdPwK1-JAixNuz5z7ttQw-T64Q@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.