From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> To: Vinod Koul <vkoul@kernel.org> Cc: Rob Clark <robdclark@gmail.com>, DTML <devicetree@vger.kernel.org>, Jonathan Marek <jonathan@marek.ca>, David Airlie <airlied@linux.ie>, MSM <linux-arm-msm@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, Abhinav Kumar <abhinavk@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Herring <robh+dt@kernel.org>, "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel@ffwll.ch>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, freedreno <freedreno@lists.freedesktop.org> Subject: Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Date: Fri, 21 May 2021 08:09:49 -0600 [thread overview] Message-ID: <CAOCk7Nqep_Db+z3fr5asHZ1u0j8+6fKkPFs2Ai8CbA_zGqV6ZA@mail.gmail.com> (raw) In-Reply-To: <20210521124946.3617862-1-vkoul@kernel.org> On Fri, May 21, 2021 at 6:50 AM Vinod Koul <vkoul@kernel.org> wrote: > > Display Stream Compression (DSC) compresses the display stream in host which > is later decoded by panel. This series enables this for Qualcomm msm driver. > This was tested on Google Pixel3 phone which use LGE SW43408 panel. > > The changes include adding DT properties for DSC then hardware blocks support > required in DPU1 driver and support in encoder. We also add support in DSI > and introduce required topology changes. > > In order for panel to set the DSC parameters we add dsc in drm_panel and set > it from the msm driver. > > Complete changes which enable this for Pixel3 along with panel driver (not > part of this series) and DT changes can be found at: > git.linaro.org/people/vinod.koul/kernel.git pixel/dsc_rfc > > Comments welcome! This feels backwards to me. I've only skimmed this series, and the DT changes didn't come through for me, so perhaps I have an incomplete view. DSC is not MSM specific. There is a standard for it. Yet it looks like everything is implemented in a MSM specific way, and then pushed to the panel. So, every vendor needs to implement their vendor specific way to get the DSC info, and then push it to the panel? Seems wrong, given there is an actual standard for this feature. Additionally, we define panel properties (resolution, BPP, etc) at the panel, and have the display drivers pull it from the panel. However, for DSC, you do the reverse (define it in the display driver, and push it to the panel). If the argument is that DSC properties can be dynamic, well, so can resolution. Every panel for MSM MTPs supports multiple resolutions, yet we define that with the panel in Linux. Finally, I haven't seen the DT bits, but I'm concerned about using DT for this. It inherently excludes ACPI systems. You appear to have sdm845 support in this series, but what about ACPI boot on the Lenovo C630 for example? Or any of the 8cx laptops? We don't read the panel resolution, etc from DT, so why the DSC? I'm glad that work is being done to add DSC to Linux, it's something I struggled with when working on the 8998 mtp, and I realize this is a bit of a drive-by review. However, it seems like there should be a better way. > > Vinod Koul (13): > drm/dsc: Add dsc pps header init function > dt-bindings: msm/dsi: Document Display Stream Compression (DSC) > parameters > drm/msm/dsi: add support for dsc data > drm/msm/disp/dpu1: Add support for DSC > drm/msm/disp/dpu1: Add support for DSC in pingpong block > drm/msm/disp/dpu1: Add DSC support in RM > drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog > drm/msm/disp/dpu1: Add DSC support in hw_ctl > drm/msm/disp/dpu1: Don't use DSC with mode_3d > drm/msm/disp/dpu1: Add support for DSC in encoder > drm/msm/disp/dpu1: Add support for DSC in topology > drm/msm/dsi: Add support for DSC configuration > drm/msm/dsi: Pass DSC params to drm_panel > > .../devicetree/bindings/display/msm/dsi.txt | 15 + > drivers/gpu/drm/drm_dsc.c | 11 + > drivers/gpu/drm/msm/Makefile | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 204 +++++++++++- > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 11 + > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 22 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 26 ++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 12 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 2 + > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 221 +++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 79 +++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 13 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 32 ++ > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 1 + > drivers/gpu/drm/msm/dsi/dsi.xml.h | 10 + > drivers/gpu/drm/msm/dsi/dsi_host.c | 293 +++++++++++++++++- > drivers/gpu/drm/msm/msm_drv.h | 32 ++ > include/drm/drm_dsc.h | 16 + > include/drm/drm_panel.h | 7 + > 23 files changed, 1043 insertions(+), 14 deletions(-) > create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h > > -- > 2.26.3 > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno
WARNING: multiple messages have this Message-ID (diff)
From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> To: Vinod Koul <vkoul@kernel.org> Cc: DTML <devicetree@vger.kernel.org>, Jonathan Marek <jonathan@marek.ca>, David Airlie <airlied@linux.ie>, MSM <linux-arm-msm@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, Abhinav Kumar <abhinavk@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Herring <robh+dt@kernel.org>, "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, freedreno <freedreno@lists.freedesktop.org> Subject: Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Date: Fri, 21 May 2021 08:09:49 -0600 [thread overview] Message-ID: <CAOCk7Nqep_Db+z3fr5asHZ1u0j8+6fKkPFs2Ai8CbA_zGqV6ZA@mail.gmail.com> (raw) In-Reply-To: <20210521124946.3617862-1-vkoul@kernel.org> On Fri, May 21, 2021 at 6:50 AM Vinod Koul <vkoul@kernel.org> wrote: > > Display Stream Compression (DSC) compresses the display stream in host which > is later decoded by panel. This series enables this for Qualcomm msm driver. > This was tested on Google Pixel3 phone which use LGE SW43408 panel. > > The changes include adding DT properties for DSC then hardware blocks support > required in DPU1 driver and support in encoder. We also add support in DSI > and introduce required topology changes. > > In order for panel to set the DSC parameters we add dsc in drm_panel and set > it from the msm driver. > > Complete changes which enable this for Pixel3 along with panel driver (not > part of this series) and DT changes can be found at: > git.linaro.org/people/vinod.koul/kernel.git pixel/dsc_rfc > > Comments welcome! This feels backwards to me. I've only skimmed this series, and the DT changes didn't come through for me, so perhaps I have an incomplete view. DSC is not MSM specific. There is a standard for it. Yet it looks like everything is implemented in a MSM specific way, and then pushed to the panel. So, every vendor needs to implement their vendor specific way to get the DSC info, and then push it to the panel? Seems wrong, given there is an actual standard for this feature. Additionally, we define panel properties (resolution, BPP, etc) at the panel, and have the display drivers pull it from the panel. However, for DSC, you do the reverse (define it in the display driver, and push it to the panel). If the argument is that DSC properties can be dynamic, well, so can resolution. Every panel for MSM MTPs supports multiple resolutions, yet we define that with the panel in Linux. Finally, I haven't seen the DT bits, but I'm concerned about using DT for this. It inherently excludes ACPI systems. You appear to have sdm845 support in this series, but what about ACPI boot on the Lenovo C630 for example? Or any of the 8cx laptops? We don't read the panel resolution, etc from DT, so why the DSC? I'm glad that work is being done to add DSC to Linux, it's something I struggled with when working on the 8998 mtp, and I realize this is a bit of a drive-by review. However, it seems like there should be a better way. > > Vinod Koul (13): > drm/dsc: Add dsc pps header init function > dt-bindings: msm/dsi: Document Display Stream Compression (DSC) > parameters > drm/msm/dsi: add support for dsc data > drm/msm/disp/dpu1: Add support for DSC > drm/msm/disp/dpu1: Add support for DSC in pingpong block > drm/msm/disp/dpu1: Add DSC support in RM > drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog > drm/msm/disp/dpu1: Add DSC support in hw_ctl > drm/msm/disp/dpu1: Don't use DSC with mode_3d > drm/msm/disp/dpu1: Add support for DSC in encoder > drm/msm/disp/dpu1: Add support for DSC in topology > drm/msm/dsi: Add support for DSC configuration > drm/msm/dsi: Pass DSC params to drm_panel > > .../devicetree/bindings/display/msm/dsi.txt | 15 + > drivers/gpu/drm/drm_dsc.c | 11 + > drivers/gpu/drm/msm/Makefile | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 204 +++++++++++- > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 11 + > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 22 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 26 ++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 12 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 2 + > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 221 +++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 79 +++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 13 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 32 ++ > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 1 + > drivers/gpu/drm/msm/dsi/dsi.xml.h | 10 + > drivers/gpu/drm/msm/dsi/dsi_host.c | 293 +++++++++++++++++- > drivers/gpu/drm/msm/msm_drv.h | 32 ++ > include/drm/drm_dsc.h | 16 + > include/drm/drm_panel.h | 7 + > 23 files changed, 1043 insertions(+), 14 deletions(-) > create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h > > -- > 2.26.3 > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno
next prev parent reply other threads:[~2021-05-21 14:10 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-21 12:49 [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 01/13] drm/dsc: Add dsc pps header init function Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 15:29 ` Daniel Vetter 2021-05-21 15:29 ` Daniel Vetter 2021-05-24 7:26 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 13:18 ` Rob Herring 2021-05-21 13:18 ` Rob Herring 2021-05-21 13:23 ` Vinod Koul 2021-05-21 13:23 ` Vinod Koul 2021-05-21 14:42 ` Bjorn Andersson 2021-05-21 14:42 ` Bjorn Andersson 2021-05-24 7:30 ` Vinod Koul 2021-05-24 7:30 ` Vinod Koul 2021-05-24 15:08 ` Bjorn Andersson 2021-05-24 15:08 ` Bjorn Andersson 2021-05-26 5:32 ` Vinod Koul 2021-05-26 5:32 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 03/13] drm/msm/disp/dpu1: Add support for DSC Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-27 23:49 ` Dmitry Baryshkov 2021-05-27 23:49 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 03/13] drm/msm/dsi: add support for dsc data Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-27 23:45 ` Dmitry Baryshkov 2021-05-27 23:45 ` Dmitry Baryshkov 2021-06-02 11:06 ` Vinod Koul 2021-06-02 11:06 ` Vinod Koul 2021-05-28 10:29 ` Dmitry Baryshkov 2021-05-28 10:29 ` Dmitry Baryshkov 2021-06-02 11:17 ` Vinod Koul 2021-06-02 11:17 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 04/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 04/13] drm/msm/disp/dpu1: Add support for DSC Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:31 ` Dmitry Baryshkov 2021-05-28 10:31 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 05/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 05/13] drm/msm/dsi: add support for dsc data Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 06/13] drm/msm/disp/dpu1: Add DSC support in RM Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:33 ` Dmitry Baryshkov 2021-05-28 10:33 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 07/13] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 08/13] drm/msm/disp/dpu1: Add DSC support in hw_ctl Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 09/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:36 ` Dmitry Baryshkov 2021-05-28 10:36 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 09/13] drm/msm/disp/dpu1: Dont " Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 10/13] drm/msm/disp/dpu1: Add support for DSC in encoder Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 11/13] drm/msm/disp/dpu1: Add support for DSC in topology Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:39 ` Dmitry Baryshkov 2021-05-28 10:39 ` Dmitry Baryshkov 2021-05-28 22:23 ` abhinavk 2021-05-28 22:23 ` abhinavk 2021-05-28 22:29 ` Dmitry Baryshkov 2021-05-28 22:29 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 12/13] drm/msm/dsi: Add support for DSC configuration Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 13/13] drm/msm/dsi: Pass DSC params to drm_panel Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 14:09 ` Jeffrey Hugo [this message] 2021-05-21 14:09 ` [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Jeffrey Hugo 2021-05-26 5:46 ` Vinod Koul 2021-05-26 5:46 ` Vinod Koul 2021-05-26 15:00 ` Jeffrey Hugo 2021-05-26 15:00 ` Jeffrey Hugo 2021-05-27 23:30 ` Rob Clark 2021-05-27 23:30 ` Rob Clark 2021-06-02 11:01 ` Vinod Koul 2021-06-02 11:01 ` Vinod Koul 2021-06-03 23:40 ` abhinavk 2021-06-03 23:40 ` abhinavk 2021-06-17 8:06 ` Vinod Koul 2021-06-17 8:06 ` Vinod Koul 2021-06-04 2:36 ` Rob Clark 2021-06-04 2:36 ` Rob Clark 2021-06-02 10:56 ` Vinod Koul 2021-06-02 10:56 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOCk7Nqep_Db+z3fr5asHZ1u0j8+6fKkPFs2Ai8CbA_zGqV6ZA@mail.gmail.com \ --to=jeffrey.l.hugo@gmail.com \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jonathan@marek.ca \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.