From: Tianyu Lan <lantianyu1986@gmail.com>
To: paulus@ozlabs.org
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>,
christoffer.dall@arm.com, marc.zyngier@arm.com,
linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, jhogan@kernel.org, ralf@linux-mips.org,
paul.burton@mips.com, benh@kernel.crashing.org,
mpe@ellerman.id.au, Paolo Bonzini <pbonzini@redhat.com>,
Radim Krcmar <rkrcmar@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
bp@alien8.de, "H. Peter Anvin" <hpa@zytor.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu,
"linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, kvm <kvm@vger.kernel.org>,
michael.h.kelley@microsoft.com, kys@microsoft.com,
vkuznets@redhat.com
Subject: Re: [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int
Date: Thu, 13 Dec 2018 15:47:31 +0800 [thread overview]
Message-ID: <CAOLK0pyKsS2hLagZ6pumMdfRokPig2P+KJambVOq7p+NU-OqgA@mail.gmail.com> (raw)
In-Reply-To: <20181212050353.GF22265@blackberry>
Hi Paul:
Thanks for your review.
On Wed, Dec 12, 2018 at 1:03 PM Paul Mackerras <paulus@ozlabs.org> wrote:
>
> On Thu, Dec 06, 2018 at 09:21:10PM +0800, lantianyu1986@gmail.com wrote:
> > From: Lan Tianyu <Tianyu.Lan@microsoft.com>
> >
> > The patch is to make kvm_set_spte_hva() return int and caller can
> > check return value to determine flush tlb or not.
>
> It would be helpful if the patch description told the reader which
> return value(s) mean that the caller should flush the tlb. I would
> guess that non-zero means to do the flush, but you should make that
> explicit.
OK. Thanks for suggestion and will update in the next version.
>
> > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
>
> For the powerpc bits:
>
> Acked-by: Paul Mackerras <paulus@ozlabs.org>
--
Best regards
Tianyu Lan
WARNING: multiple messages have this Message-ID (diff)
From: Tianyu Lan <lantianyu1986@gmail.com>
To: paulus@ozlabs.org
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>,
christoffer.dall@arm.com, marc.zyngier@arm.com,
linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, jhogan@kernel.org, ralf@linux-mips.org,
paul.burton@mips.com, benh@kernel.crashing.org,
mpe@ellerman.id.au, Paolo Bonzini <pbonzini@redhat.com>,
Radim Krcmar <rkrcmar@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
bp@alien8.de, "H. Peter Anvin" <hpa@zytor.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu,
"linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, kvm <kvm@vger.kernel.org>,
michael.h.kelley@microsoft.com, kys@
Subject: Re: [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int
Date: Thu, 13 Dec 2018 15:47:31 +0800 [thread overview]
Message-ID: <CAOLK0pyKsS2hLagZ6pumMdfRokPig2P+KJambVOq7p+NU-OqgA@mail.gmail.com> (raw)
In-Reply-To: <20181212050353.GF22265@blackberry>
Hi Paul:
Thanks for your review.
On Wed, Dec 12, 2018 at 1:03 PM Paul Mackerras <paulus@ozlabs.org> wrote:
>
> On Thu, Dec 06, 2018 at 09:21:10PM +0800, lantianyu1986@gmail.com wrote:
> > From: Lan Tianyu <Tianyu.Lan@microsoft.com>
> >
> > The patch is to make kvm_set_spte_hva() return int and caller can
> > check return value to determine flush tlb or not.
>
> It would be helpful if the patch description told the reader which
> return value(s) mean that the caller should flush the tlb. I would
> guess that non-zero means to do the flush, but you should make that
> explicit.
OK. Thanks for suggestion and will update in the next version.
>
> > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
>
> For the powerpc bits:
>
> Acked-by: Paul Mackerras <paulus@ozlabs.org>
--
Best regards
Tianyu Lan
WARNING: multiple messages have this Message-ID (diff)
From: Tianyu Lan <lantianyu1986@gmail.com>
To: paulus@ozlabs.org
Cc: linux-mips@linux-mips.org, kvm <kvm@vger.kernel.org>,
Radim Krcmar <rkrcmar@redhat.com>,
catalin.marinas@arm.com, will.deacon@arm.com,
christoffer.dall@arm.com, "H. Peter Anvin" <hpa@zytor.com>,
kys@microsoft.com, kvmarm@lists.cs.columbia.edu,
the arch/x86 maintainers <x86@kernel.org>,
linux@armlinux.org.uk, michael.h.kelley@microsoft.com,
Ingo Molnar <mingo@redhat.com>,
jhogan@kernel.org, Tianyu Lan <Tianyu.Lan@microsoft.com>,
marc.zyngier@arm.com, kvm-ppc@vger.kernel.org, bp@alien8.de,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
"linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
ralf@linux-mips.org, paul.burton@mips.com,
Paolo Bonzini <pbonzini@redhat.com>,
vkuznets@redhat.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int
Date: Thu, 13 Dec 2018 15:47:31 +0800 [thread overview]
Message-ID: <CAOLK0pyKsS2hLagZ6pumMdfRokPig2P+KJambVOq7p+NU-OqgA@mail.gmail.com> (raw)
In-Reply-To: <20181212050353.GF22265@blackberry>
Hi Paul:
Thanks for your review.
On Wed, Dec 12, 2018 at 1:03 PM Paul Mackerras <paulus@ozlabs.org> wrote:
>
> On Thu, Dec 06, 2018 at 09:21:10PM +0800, lantianyu1986@gmail.com wrote:
> > From: Lan Tianyu <Tianyu.Lan@microsoft.com>
> >
> > The patch is to make kvm_set_spte_hva() return int and caller can
> > check return value to determine flush tlb or not.
>
> It would be helpful if the patch description told the reader which
> return value(s) mean that the caller should flush the tlb. I would
> guess that non-zero means to do the flush, but you should make that
> explicit.
OK. Thanks for suggestion and will update in the next version.
>
> > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
>
> For the powerpc bits:
>
> Acked-by: Paul Mackerras <paulus@ozlabs.org>
--
Best regards
Tianyu Lan
WARNING: multiple messages have this Message-ID (diff)
From: Tianyu Lan <lantianyu1986@gmail.com>
To: paulus@ozlabs.org
Cc: linux-mips@linux-mips.org, kvm <kvm@vger.kernel.org>,
Radim Krcmar <rkrcmar@redhat.com>,
catalin.marinas@arm.com, will.deacon@arm.com,
christoffer.dall@arm.com, "H. Peter Anvin" <hpa@zytor.com>,
kys@microsoft.com, kvmarm@lists.cs.columbia.edu,
mpe@ellerman.id.au, the arch/x86 maintainers <x86@kernel.org>,
linux@armlinux.org.uk, michael.h.kelley@microsoft.com,
Ingo Molnar <mingo@redhat.com>,
benh@kernel.crashing.org, jhogan@kernel.org,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
marc.zyngier@arm.com, kvm-ppc@vger.kernel.org, bp@alien8.de,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
"linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
ralf@linux-mips.org, paul.burton@mips.com,
Paolo Bonzini <pbonzini@redhat.com>,
vkuznets@redhat.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int
Date: Thu, 13 Dec 2018 15:47:31 +0800 [thread overview]
Message-ID: <CAOLK0pyKsS2hLagZ6pumMdfRokPig2P+KJambVOq7p+NU-OqgA@mail.gmail.com> (raw)
In-Reply-To: <20181212050353.GF22265@blackberry>
Hi Paul:
Thanks for your review.
On Wed, Dec 12, 2018 at 1:03 PM Paul Mackerras <paulus@ozlabs.org> wrote:
>
> On Thu, Dec 06, 2018 at 09:21:10PM +0800, lantianyu1986@gmail.com wrote:
> > From: Lan Tianyu <Tianyu.Lan@microsoft.com>
> >
> > The patch is to make kvm_set_spte_hva() return int and caller can
> > check return value to determine flush tlb or not.
>
> It would be helpful if the patch description told the reader which
> return value(s) mean that the caller should flush the tlb. I would
> guess that non-zero means to do the flush, but you should make that
> explicit.
OK. Thanks for suggestion and will update in the next version.
>
> > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
>
> For the powerpc bits:
>
> Acked-by: Paul Mackerras <paulus@ozlabs.org>
--
Best regards
Tianyu Lan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tianyu Lan <lantianyu1986@gmail.com>
To: paulus@ozlabs.org
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>,
christoffer.dall@arm.com, marc.zyngier@arm.com,
linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, jhogan@kernel.org, ralf@linux-mips.org,
paul.burton@mips.com, benh@kernel.crashing.org,
mpe@ellerman.id.au, Paolo Bonzini <pbonzini@redhat.com>,
Radim Krcmar <rkrcmar@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
bp@alien8.de, "H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu,
"linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, kvm <kvm@vger.kernel.org>,
michael.h.kelley@microsoft.com, kys@microsoft.com,
vkuznets@redhat.com
Subject: Re: [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int
Date: Thu, 13 Dec 2018 07:47:31 +0000 [thread overview]
Message-ID: <CAOLK0pyKsS2hLagZ6pumMdfRokPig2P+KJambVOq7p+NU-OqgA@mail.gmail.com> (raw)
In-Reply-To: <20181212050353.GF22265@blackberry>
Hi Paul:
Thanks for your review.
On Wed, Dec 12, 2018 at 1:03 PM Paul Mackerras <paulus@ozlabs.org> wrote:
>
> On Thu, Dec 06, 2018 at 09:21:10PM +0800, lantianyu1986@gmail.com wrote:
> > From: Lan Tianyu <Tianyu.Lan@microsoft.com>
> >
> > The patch is to make kvm_set_spte_hva() return int and caller can
> > check return value to determine flush tlb or not.
>
> It would be helpful if the patch description told the reader which
> return value(s) mean that the caller should flush the tlb. I would
> guess that non-zero means to do the flush, but you should make that
> explicit.
OK. Thanks for suggestion and will update in the next version.
>
> > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
>
> For the powerpc bits:
>
> Acked-by: Paul Mackerras <paulus@ozlabs.org>
--
Best regards
Tianyu Lan
next prev parent reply other threads:[~2018-12-13 7:47 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:21 [Resend PATCH V5 0/10] x86/KVM/Hyper-v: Add HV ept tlb range flush hypercall support in KVM lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 1/10] KVM: Add tlb_remote_flush_with_range callback in kvm_x86_ops lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 2/10] x86/hyper-v: Add HvFlushGuestAddressList hypercall support lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-21 9:32 ` Paolo Bonzini
2018-12-21 9:32 ` Paolo Bonzini
2018-12-21 9:32 ` Paolo Bonzini
2018-12-21 9:32 ` Paolo Bonzini
2018-12-21 9:32 ` Paolo Bonzini
2018-12-06 13:21 ` [Resend PATCH V5 3/10] x86/Hyper-v: Add trace in the hyperv_nested_flush_guest_mapping_range() lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 4/10] KVM/VMX: Add hv tlb range flush support lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 5/10] KVM/MMU: Add tlb flush with range helper function lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 6/10] KVM: Replace old tlb flush function with new one to flush a specified range lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-06 13:21 ` lantianyu1986
2018-12-12 5:03 ` Paul Mackerras
2018-12-12 5:03 ` Paul Mackerras
2018-12-12 5:03 ` Paul Mackerras
2018-12-12 5:03 ` Paul Mackerras
2018-12-13 7:47 ` Tianyu Lan [this message]
2018-12-13 7:47 ` Tianyu Lan
2018-12-13 7:47 ` Tianyu Lan
2018-12-13 7:47 ` Tianyu Lan
2018-12-13 7:47 ` Tianyu Lan
2018-12-06 13:21 ` [Resend PATCH V5 8/10] KVM/MMU: Move tlb flush in kvm_set_pte_rmapp() to kvm_mmu_notifier_change_pte() lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 9/10] KVM/MMU: Flush tlb directly in the kvm_set_pte_rmapp() lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 10/10] KVM/MMU: Flush tlb directly in the kvm_zap_gfn_range() lantianyu1986
2018-12-21 9:31 ` [Resend PATCH V5 0/10] x86/KVM/Hyper-v: Add HV ept tlb range flush hypercall support in KVM Paolo Bonzini
2018-12-21 9:31 ` Paolo Bonzini
2018-12-21 9:31 ` Paolo Bonzini
2018-12-21 9:31 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2018-11-08 14:46 [Resend PATCH V5 1/10] KVM: Add tlb_remote_flush_with_range callback in kvm_x86_ops lantianyu1986
2018-11-08 14:46 ` [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int lantianyu1986
2018-11-08 14:46 ` lantianyu1986
2018-11-08 14:46 ` lantianyu1986 at gmail.com
2018-11-08 14:46 ` lantianyu1986
2018-11-08 14:46 ` lantianyu1986
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOLK0pyKsS2hLagZ6pumMdfRokPig2P+KJambVOq7p+NU-OqgA@mail.gmail.com \
--to=lantianyu1986@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=hpa@zytor.com \
--cc=jhogan@kernel.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marc.zyngier@arm.com \
--cc=michael.h.kelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.